Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 20 Nov 2022 12:41:10 -0600
From:   Jeff LaBundy <jeff@labundy.com>
To:     Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <uwe@kleine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 247/606] Input: iqs5xx - Convert to i2c's .probe_new()
Message-ID: <Y3p0xgsvyWLwzzWb@nixie71>
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
 <20221118224540.619276-248-uwe@kleine-koenig.org>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221118224540.619276-248-uwe@kleine-koenig.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?iDKVO1bfzGnOEpYqCjOGg3dkwCsRrRgHrqp6TCMKBYqrpSW43yJkyaQbOV?=
 =?iso-8859-1?Q?oXErgqJfjHeSVSNiVe7y49OMgBD+I6AUrqh5T2K5Y8wdP5Ou8fBz+nBftD?=
 =?iso-8859-1?Q?Q9Fq7YrvOJBoqdGsPBCrh3I/4oLMr4zTKvDF6NdyPXBqdzltm+HooNfCcc?=
 =?iso-8859-1?Q?WBuJ9Fw+VG83UitbvyP9+TYTplbJQUM/b7P6FPYi98KZs4yyMxfA8M4Wx+?=
 =?iso-8859-1?Q?GPNQ8GzutvaFDxHe95Ix7wj7CtqivMDt1RgbUIiPZSQHqDDZKEvovuPyCr?=
 =?iso-8859-1?Q?SWzbPDO17aEzJjPVujp+g5WriuHNi2xLDa2dRosY2UaUYVv16YZMTeC9gU?=
 =?iso-8859-1?Q?MPOLW2jOglrqKbw3D/cA/EaPGwEHeLeqoRarbGo74lJI2T/cAkXq7mE+Pq?=
 =?iso-8859-1?Q?6hk8xjhe+qzVvuRQjtRCctLkauhPvGfmvp0TKBtzERta2J2oGMQep7uhU+?=
 =?iso-8859-1?Q?cvcBD1X3W6x0LYndT/3oH2iRA1hsA2HnmXAnHw6FP7xPiRfk7sl1qj2BT2?=
 =?iso-8859-1?Q?Q/byhrcZjIKvOCkHoqn4vs6F34A/Jo6ixfkiqOm85/yKQuus1/FobKQ5To?=
 =?iso-8859-1?Q?fTE40ESUPDBE68TMzfS675T3KdRoXIhTMHZDGm2WwlPqwhe0Kakph6ZnqY?=
 =?iso-8859-1?Q?0h9TDcenscbR/4iIHA1guT7ihgS1bhLj1ZPC8kq73k0KWj5xvMEOMcbyPz?=
 =?iso-8859-1?Q?5awFb01h1DfhltMM2CGwyewHf4C3kiduWk94jlOSFFgWtiADS/bqJCS/4c?=
 =?iso-8859-1?Q?Ie9QdxEIjAtwTTNoW1U7kciK4F8Dp1L9aEnbgAsyhwdzRGUpDl5Z/otcvR?=
 =?iso-8859-1?Q?GwcBtouEYJXenFmJdN/bqHECa/EaogjXTgy7ek9y05fNuMj6rjr9o4tVvu?=
 =?iso-8859-1?Q?Xym/u6rzWQ3psrgIe6LcozCY6B2NY5/hHNbYsO5a3ueA6mBdDZbsuJLDWt?=
 =?iso-8859-1?Q?QupN03kdr63XtWu1P1GEvKwZWIDo/AWdnv7eEDjLOoZDfd13Af0IMxhkx0?=
 =?iso-8859-1?Q?hPY/u3zkI+1gO0wmI///zYYvXlqIN8WPCwu7qKYPoSeJDwWQVtsx3mSfvG?=
 =?iso-8859-1?Q?qSoR8Yi+14j/welGSEqio4pJ1+S/x1qAndXgSSLJBssGSn4LrAhhoKm0Mp?=
 =?iso-8859-1?Q?3rCBCMgahyWiBfxWumg6bSObeSYLhlg9sKxmzVooTp8krQqvjVkUy0isCl?=
 =?iso-8859-1?Q?0SdlkxdqslI/ElUrQzQNY2eNOtk0auOz2OqGxhgka+SK/LOKf1zLWK1zn6?=
 =?iso-8859-1?Q?G0NYynxO9zGQZ+9vx+B3PcNGb1Qk9umxo5g5qPBhoN1F5BVLA6udjV9CN3?=
 =?iso-8859-1?Q?gCx3C9Uoe2WNr/9sNKHb7IXqPeAVuPlqSijvJ9Fy3f9zUTsaAXQdoqjj8M?=
 =?iso-8859-1?Q?fliR60P/i/0mfIKwF6qBAWqFIyTVhkDf5TCMZP162MgOH1YvTW9aN0Chsc?=
 =?iso-8859-1?Q?svLOq7JIFehqZXxTm6ip5YyBwEANgksB0ONAAmYIh27wlHncPNaHWNMmqv?=
 =?iso-8859-1?Q?UAPJimsp6sLJWau/EWuQkisqStW8BeAKFejrnv7dhv1aIiG48s0CpxRcBM?=
 =?iso-8859-1?Q?8S6BCxQWoheKwb7fcAyryJOU7aBzfJRj+HfZQCVYaiRs6NTRxq6Jd6dOFh?=
 =?iso-8859-1?Q?YL5xQ5THoC1ITI2RGZM0e0DcryFg/d4y7p?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35e4b31e-d9c5-46c7-ac45-08dacb26cc47
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2022 18:41:12.5291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WfcwshEM6qJ3kf9SvAfsBJ1d48w0/CyQfw1hXa7hga6v9Pakb+VRpXCdVpCweWUhn0mu1jCopKszWu3dwW3O8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0801MB3830
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 18, 2022 at 11:39:41PM +0100, Uwe Kleine-K?nig wrote:
> From: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Acked-by: Jeff LaBundy <jeff@labundy.com>

> ---
>  drivers/input/touchscreen/iqs5xx.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c
> index 34c4cca57d13..dc3137a34f35 100644
> --- a/drivers/input/touchscreen/iqs5xx.c
> +++ b/drivers/input/touchscreen/iqs5xx.c
> @@ -1019,8 +1019,7 @@ static int __maybe_unused iqs5xx_resume(struct device *dev)
>  
>  static SIMPLE_DEV_PM_OPS(iqs5xx_pm, iqs5xx_suspend, iqs5xx_resume);
>  
> -static int iqs5xx_probe(struct i2c_client *client,
> -			const struct i2c_device_id *id)
> +static int iqs5xx_probe(struct i2c_client *client)
>  {
>  	struct iqs5xx_private *iqs5xx;
>  	int error;
> @@ -1094,7 +1093,7 @@ static struct i2c_driver iqs5xx_i2c_driver = {
>  		.pm		= &iqs5xx_pm,
>  	},
>  	.id_table	= iqs5xx_id,
> -	.probe		= iqs5xx_probe,
> +	.probe_new	= iqs5xx_probe,
>  };
>  module_i2c_driver(iqs5xx_i2c_driver);
>  
> -- 
> 2.38.1
>