Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 00:42:14 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Renze Nicolai <renze@rnplus.nl>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Maxime Ripard <maxime@cerno.tech>,
        Andre Przywara <andre.przywara@arm.com>,
        Conley Lee <conleylee@foxmail.com>,
        krzysztof.kozlowski@linaro.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: add device tree for SOPINE on
 Pine64 Clusterboard
Message-ID: <Y3q7VnjHD+pLdl+H@lunn.ch>
References: <3351526.aeNJFYEL58@werkpc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3351526.aeNJFYEL58@werkpc>
Precedence: bulk

> +&emac {
> +	allwinner,tx-delay-ps = <500>;
> +};

Is this direct MAC to MAC without a PHY in the middle? And RGMII?

500ps seems odd. It is normally 1000ps. And you need to specify a
delay for both Rx and Tx. I could understand

&emac {
	allwinner,tx-delay-ps = <500>;
	allwinner,rx-delay-ps = <500>;
};

then each end adds 1/2 the delay on both Rx and Tx.

     Andrew