Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 08:55:15 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Paul E. McKenney" <paulmck@kernel.org>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        <linux-kernel@vger.kernel.org>, <john.stultz@linaro.org>,
        <sboyd@kernel.org>, <corbet@lwn.net>, <Mark.Rutland@arm.com>,
        <maz@kernel.org>, <kernel-team@meta.com>, <neeraju@codeaurora.org>,
        <ak@linux.intel.com>, <zhengjun.xing@intel.com>,
        Chris Mason <clm@meta.com>, John Stultz <jstultz@google.com>,
        Waiman Long <longman@redhat.com>
Subject: Re: [PATCH clocksource 1/3] clocksource: Reject bogus watchdog
 clocksource measurements
Message-ID: <Y3rMc2VbgVLHN9db@feng-clx>
References: <20221114232807.GA834337@paulmck-ThinkPad-P17-Gen-1>
 <20221114232827.835599-1-paulmck@kernel.org>
 <87mt8pkzw1.ffs@tglx>
 <20221117230910.GI4001@paulmck-ThinkPad-P17-Gen-1>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221117230910.GI4001@paulmck-ThinkPad-P17-Gen-1>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jlYZTxr46BY+faK8IMWDCEkHMOyR16afQTYAtPk8EkzYdgxAvjqWY6/mz5Y9?=
 =?us-ascii?Q?frzq5AffcJOxD9y31n8bx/sWS9X5DagK/AsEO6WoLQxauvPy4IotCR9oHGV9?=
 =?us-ascii?Q?DWcHgmf/C3DXNYJNccK3Nw4rdls3eISp5iBW6dP51A9zi9heVvC6oVIhfMeA?=
 =?us-ascii?Q?cfUmyQEr2rHHXgYDT12EhKeX8MP+3u/Od/GoQSL+B6UK+XPsRaWZnDyZOyLf?=
 =?us-ascii?Q?fGXTG0UeXVcXPIkkfK+7UZXU4nCSpC3YeE7OXGYZ3+2b/fd+41eBi+o4hMvE?=
 =?us-ascii?Q?VF+DbbDZGnExqZHlww7pfKJ3IWtGKDlomZANswtc3WkyZcdwIo5XZw5Zg7Re?=
 =?us-ascii?Q?0CFJepdyQbbJfQ+rgchsfxZFRzvqjduqlyBR1KRlvwVA1WF++SdWbItAFnw8?=
 =?us-ascii?Q?hyyTPbxTVUma/Xfir119sj4y1ZYjkaK4InRbBVfzuRyJLPJjCx6zIZ5AUl3K?=
 =?us-ascii?Q?1Y75+pbmcWBvnT/VEMmYXdYkJGP3h/W7B4RdJR8M3QPwthiOPqdIP0FVbTLf?=
 =?us-ascii?Q?pcx4ZnTQuH4x4jRElorA22PE88BZwS0OqdsG6j9tqoEbi2jq+x4LydvsBp8K?=
 =?us-ascii?Q?ht/GGCpY/aXNyIfFdvBf1q0OUebD3A+ounb62HRFSaototnanXpSOe3uvzVM?=
 =?us-ascii?Q?jAsykDirht7qmiE8Cdlei3ROokkJcB1jrRMcZiEfcXa/916y3IJRYTc7aNYA?=
 =?us-ascii?Q?wu1tTe7onJBlmEMPU0pIkw7B3caPvUHosCHLdz9FRzKD7Q1lEHriQRMXaBK9?=
 =?us-ascii?Q?1/sLaMFR/4XQuiRk/8K4P31wZrdL7t45k9f9hJhjy+nwt8hMzHG6ISJwlGdN?=
 =?us-ascii?Q?3aLVhL0O+qEY9TLgxBMQVfD821CuQpOZHWez+6A8ufitueoiIGyaLD3o/T03?=
 =?us-ascii?Q?kQo2iOZXTkshlo3STCT81/VObAvpaCy8hdS+dB/dsjwmOt86x0s4zUwRgdio?=
 =?us-ascii?Q?3Mnk125P9yBoc6hqyp1X+IZ+3VFOVPpW7TVIKa/scOpxl1NVbNsQiSLfZtK6?=
 =?us-ascii?Q?FKg5h0fehO1NCzzeYu/D/IKqivwxrzhOh3ZxTCveuaUwL5E21RbQIXDAliJX?=
 =?us-ascii?Q?l5xa8GljOEMnKm2CRaGS+lc69u/vVYcRz+RTq8uZ+9dNJP+05GfLpuagIEO5?=
 =?us-ascii?Q?mhkS6XZ/VkLPU9rOqqJLAbhJTt7Nvtli6b+x5NL2LDohg3GIcdUgwC06dw0w?=
 =?us-ascii?Q?RPGIOA4l+RB3dHvPvZQ2FIlsaaBMFzFtJVZk/AV8iZKnvbcF8nhFfCkSsupI?=
 =?us-ascii?Q?4Uw4LkDV/TD3h1NuM/qzxQWMrgBdvW2z1VgfOV/v6q38x1+EWmlnmDyDx3YH?=
 =?us-ascii?Q?87zn0ViY8z8BhnLqGvAWiO/Nb8pdzER1nLR11g+uEtjJZRYCLe+qoy3hC+Dj?=
 =?us-ascii?Q?Ezs5M/b7oKpa5bufDi7FFPSyEOAAuY+xAi7Bfh3hECwRdoTVxnd78eWU1khO?=
 =?us-ascii?Q?yW23SvRbb5+Lej/fgL6cg/tZceMlicZoHSdvf1s/8yQa2MkRjDcXywRGFzJQ?=
 =?us-ascii?Q?seWFBOcaKeR0YikfELeLaq4v9nR8Gi+H0GClgnecW2RIGma0ud6yHnVaDDIw?=
 =?us-ascii?Q?ii5TMPMcjQ50yVW6VDeDLiZ5lXf+cUFBPnqjG/Hb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a18c9cdc-eb39-4299-348b-08dacb5b8221
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 00:58:31.4522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ASeyuyHhVr/ZNjOCisc9s3m+fLRa8peim4GXWL164LqTL2o5jOHtXYnh9+ObScDwtFl23t9qvXJcRbBPu0GmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4840
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 17, 2022 at 03:09:10PM -0800, Paul E. McKenney wrote:
> On Thu, Nov 17, 2022 at 10:57:34PM +0100, Thomas Gleixner wrote:
> > Paul!
> > 
> > On Mon, Nov 14 2022 at 15:28, Paul E. McKenney wrote:
> > >  
> > > +		/* Check for bogus measurements. */
> > > +		wdi = jiffies_to_nsecs(WATCHDOG_INTERVAL);
> > > +		if (wd_nsec < (wdi >> 2)) {
> > > +			pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advanced only %lld ns during %d-jiffy time interval, skipping watchdog check.\n", smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL);
> > > +			continue;
> > > +		}
> > > +		if (wd_nsec > (wdi << 2)) {
> > > +			pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advanced an excessive %lld ns during %d-jiffy time interval, probable CPU overutilization, skipping watchdog check.\n", smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL);
> > > +			continue;
> > > +		}
> > 
> > This is really getting ridiculous.
> 
> I have absolutely no argument with this statement, and going back a
> long time.  ;-)
> 
> But the set of systems that caused me to send this turned out to have
> real divergence between HPET and TSC, and 40 milliseconds per second of
> divergence at that.  So not only do you hate this series, but it is also
> the case that this series doesn't help with the problem at hand.

The drift is about 4% which is quite big. It seems that this is
either problem of HPET/TSC's hardware/firmware, or the problem of
frequency calibration for HPET/TSC. TSC calibration is complex,
as it could be done from different methods depending on hardware
and firmware, could you share the kernel boot log related with
tsc/hpet and clocksource? 

Also if your platform has acpi PM_TIMER, you may try "nohpet"
to use PM_TIMER instead of HPET and check if there is also big
drift between TSC and PM_TIMER.

Thanks,
Feng