Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To:     "Weiny, Ira" <ira.weiny@intel.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>
CC:     "Weiny, Ira" <ira.weiny@intel.com>,
        Gregory Price <gregory.price@memverge.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "Li, Ming4" <ming4.li@intel.com>,
        "Verma, Vishal L" <vishal.l.verma@intel.com>,
        Lukas Wunner <lukas@wunner.de>,
        "Schofield, Alison" <alison.schofield@intel.com>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: RE: [PATCH] PCI/DOE: Remove asynchronous task support
Thread-Topic: [PATCH] PCI/DOE: Remove asynchronous task support
Thread-Index: AQHY/GXd/0D4hRhIPkuRQ8htDgun0a5InQpw
Date:   Mon, 21 Nov 2022 02:01:32 +0000
Message-ID: <IA1PR11MB6171B27750AB469AFE47CD5E890A9@IA1PR11MB6171.namprd11.prod.outlook.com>
References: <20221119222527.1799836-1-ira.weiny@intel.com>
In-Reply-To: <20221119222527.1799836-1-ira.weiny@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?WU5sbjhhaFA1M1cxNkhXaWRFNHZ2SGVLeVpMMkRoVkRxOVNEZ1FLMmo4?=
 =?iso-2022-jp?B?WDhDSmZmQUs3OWdWWCtIbk9pY1dpSDlvQ3dRejU2MFJ4YmwrV0NFNC9C?=
 =?iso-2022-jp?B?TmtmQlBVd2Q5WmM2T3lRanlPNmM5RHhKQzlaZENPSEdiZDVzT1JsdmNr?=
 =?iso-2022-jp?B?V2hqNmExMms4eTZaaUlNaTBXeXdBZkp1L3gxYmlmSGxZOU9ZVDVhQ2dW?=
 =?iso-2022-jp?B?UkdjVkpCcGFyWVdoWnlaRFBpQ0Q2aXgyOHR3Z3RMTTJOQzB1MEhBRGR1?=
 =?iso-2022-jp?B?QnBpZTNyT1dxL29uYUY0Mk5MTmxYR1g4Mll6TGlJRmgyS1FyWXE1b2w5?=
 =?iso-2022-jp?B?MVVvNmh0S2l5cXdQOExJVmdIMFdjOE9aOTJ4ZGpPNlFxK0RQbmpsMzV6?=
 =?iso-2022-jp?B?MXBaam5EVHZ6d3pzY1BQbENqMzdIUGNDUnJsV0JYVFlqcGVWWjQ4cVdo?=
 =?iso-2022-jp?B?cWhqeUM0SGZYSnRNeEl0OUZnbDlhcTYySEhzdUVOYmVjUE05MEJEOWRW?=
 =?iso-2022-jp?B?L3NBdGw1Ykt1blVGY2F6SGpOdnN5S3JnYmFNU29uK05GSkJmSkgvdWha?=
 =?iso-2022-jp?B?eUM4QTFXSk8zL01iRWdzLzhHQkZIQWNGN2RYU3l5T2VoblBsQ1p5Qjla?=
 =?iso-2022-jp?B?UHBCVlJDWGRZbGdUTFNGSTNJNHlLTFp4MjUxQVlqdm9LcG1JNWdBUGFo?=
 =?iso-2022-jp?B?ZjVmT3ExZVRLOGNQZXZLenVSK3luNWhNTHpHWTZBaUUrODdZYUM2WGlT?=
 =?iso-2022-jp?B?b2FlTStmMWpkeWdYTEpHd1U1TEk4WlZrUkRwVXhaYkxqMTNkZm1yV0NL?=
 =?iso-2022-jp?B?Q3Q3OW5DbkhCR2JielZ2UTR4N2NNeEVuaCtUS2E3K0E5bWRnU3JHS05y?=
 =?iso-2022-jp?B?Nko0cDBIVTErRkxENHk5ZWhBL0hkcnJsZFIzZkI4SXFaUUZ5cVVrM3hh?=
 =?iso-2022-jp?B?MXNaZkxLc3hNTEUrUDZLNEZFVEZKV3RHbDd4d0hEbVZlOW1udXg5MFRS?=
 =?iso-2022-jp?B?TUlQV0ZVdzFRUWhnUExwNGxNMDhKVTdJSHNVWWo3eGJISGpucDNRWGds?=
 =?iso-2022-jp?B?TnZScTlVYWlxUWJUaGg1OG5PSThNU3BkNVlwdlU3cUVLTlBTd1plR1Z5?=
 =?iso-2022-jp?B?MXN6SWwxc0o5eXZ2TFpZNDYzbm9qUENTMTdHZHJPSHhVWi9INmFHQkxz?=
 =?iso-2022-jp?B?VGFwZFJTNUdtb0FXdHVTd3ZGbnhweFc0bkhRNE56ZWZybC96V2k3R2RB?=
 =?iso-2022-jp?B?N3FLVGVCRlhEKzJHSWFHY01QQVR0ak9oYzdFc0Z4WGVRMnVHWFJnR0d6?=
 =?iso-2022-jp?B?Y3RPSGNveURmc2RGN2g3NkJUKzVuajhNWEo4UUUxSnRhbHVsellveFNt?=
 =?iso-2022-jp?B?YmNUdkZxK1FHdFZoUzZRWjJ5N0ZvRnNyVGc4Sk9pWjFhRkpISFR6WFV5?=
 =?iso-2022-jp?B?NWRaSHVLMHUzdnI3cjM0VzVpWGhzNjNkc2NaWEV0WEJzeFVhUjZGVkxa?=
 =?iso-2022-jp?B?V1VKM2o3cUVrL2plMUVUaVBmNFRacHlBZG5zdmF1RGxNdE1wc01SMXJw?=
 =?iso-2022-jp?B?d2xmT0xUbkdsU2xQNVdvUWhzajhZenFPazVvSVRUdlB5amtzeUVtZmdK?=
 =?iso-2022-jp?B?c0ZUcThMMEZ1VTgzbWVOQXpybWZJWjZnRVc0ZlQrWW9GdW5HM2ZFekxG?=
 =?iso-2022-jp?B?NS9sMmxaVGVOQTdteVBZWUZqV1Z1U0E1SXBDZU5QTmhVMWpIcERwTkN3?=
 =?iso-2022-jp?B?bUhlSkJEb0g5TXk5aDdvdUlCN2YyekFRUitWcUk4QWloMjUwb21Yald2?=
 =?iso-2022-jp?B?RitKanQ2ejdEK3J2cUdxRy9CZXJmMU5vTE9CNWE1VjdROEdIQWNsRGFS?=
 =?iso-2022-jp?B?R1RuV1B2UE8vUGk0NUZMK3ErSVptMXFwYjdoMnkyKzBoYW85bThpTTQ3?=
 =?iso-2022-jp?B?MzQ3TEFjUHNhdXZPeXJjR3BmK3l6NXIxVmVWOVJhaW5Ha1B3djZzT1FI?=
 =?iso-2022-jp?B?YXIvR2kxSUQ4dGhXVU13YUlvejFXbExjbERIZnVmS3NKcWpDNlhUa0FK?=
 =?iso-2022-jp?B?ZHhHN2dqd0xSc0hSQ3Q0ZjVGdGw1ZTNPRmRWZE82WE52dnJBZ2lDd3Nx?=
 =?iso-2022-jp?B?d0paYkQ5RnlHd1hSWWxxSzlzMVFMU3dOKzZuelVXeEhpVGJaQzNDRFZz?=
 =?iso-2022-jp?B?VEZzUE1CUHg0NlhVaEZPSTMvQXh3V29MVFdmaWI1ZzVDQmFVNENSNC9z?=
 =?iso-2022-jp?B?M25lZDcvM3NWTTBaYmxOaW1RcWZ0RDZqbDAxQmlyZnJiMEpSQjFldUwy?=
 =?iso-2022-jp?B?bWcraw==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6171.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08f3a3ea-63bd-4e97-6329-08dacb64503b
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 02:01:32.9115
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YzIIe/kBMDd0DpCg99TytrdGilC4VRrpCDH2OCdajbF3zQB9XPwmbGJ9boJ1Kl2ec8khr6S9CdQ8OFVz+NZ4BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5978
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Ira Weiny <ira.weiny@intel.com>
=1B$B!d!!=1B(B...
>=20
> @@ -423,25 +399,13 @@ struct pci_doe_mb
> *pcim_doe_create_mb(struct pci_dev *pdev, u16 cap_offset)
>  	doe_mb->pdev =3D pdev;
>  	doe_mb->cap_offset =3D cap_offset;
>  	init_waitqueue_head(&doe_mb->wq);
> +	mutex_init(&doe_mb->exec_lock);

In real world, not sure whether there is a case that pcim_doe_create_mb() i=
s invoked by=20
multiple drivers to create multiple DOE mailbox instances? If there is such=
 a case, we may=20
need to ensure there is only one DOE mailbox instance for a physical DOE of=
 pdev @cap_offset.

-Qiuxu