Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        "Chatre, Reinette" <reinette.chatre@intel.com>
Subject: RE: [patch 15/20] genirq/msi: Provide new domain id allocation
 functions
Thread-Topic: [patch 15/20] genirq/msi: Provide new domain id allocation
 functions
Thread-Index: AQHY9dWAtezPKicU9k+8s39P1gVnWK5EOeAAgABsaICABB/0YA==
Date:   Mon, 21 Nov 2022 03:26:10 +0000
Message-ID: <BN9PR11MB5276F29068E4B9BEBD088F648C0A9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20221111131813.914374272@linutronix.de>
 <20221111132706.892426212@linutronix.de>
 <BN9PR11MB527679752FAA7294E33619C98C099@BN9PR11MB5276.namprd11.prod.outlook.com>
 <87iljcjvny.ffs@tglx>
In-Reply-To: <87iljcjvny.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CsmR/+zRa3dExHs4RiRiZy0warQcbun4euKWYeVvKb1a3JnD3/NpF1piylde?=
 =?us-ascii?Q?FjxDCE8yzRLOE67izQdS+59wH0fglTdD7BV9U7fLRAgD7kEXV1jQRZh3MF21?=
 =?us-ascii?Q?iqJOBpPoiUXUa+g8XPey89waAAxi7TPCWZP+fYH/vTQkVZH8dgli1FzkhyqI?=
 =?us-ascii?Q?EmLLMsAfBDzrrcH8pmBfQ7SqKdzitiGmLxr3wUnizGgKvG94FDPxnBze0jlE?=
 =?us-ascii?Q?WPww1OON9ysxW/M2FN+S89uCsB7ufgMlIsoZ7IqZ7lxgOCJ9U4qaZJd7CUsW?=
 =?us-ascii?Q?AIGCW4aclXQKzNeBh2wHR0rrnSD2+Cm4KBREuekHYxHnsbkBPTykTswlmr1U?=
 =?us-ascii?Q?jqGkZjoOjRJbjvf3SWzcaop+pBXCDDfsHRaYbyPdXuEgneLQj43tcXfLLH1V?=
 =?us-ascii?Q?l+1+ZTtmJrgmFdsuxc1rApnJe4aiVV4rgDD13uVCsnXmorSsH7bdcdAuAXdV?=
 =?us-ascii?Q?sxh6/u+EULFiVGWu723tdaSyuwtD6lBTvgb48wy08o995PW2ftJRsc8H2OJb?=
 =?us-ascii?Q?MDafCRgvc8zPw1fWm9qfqNApqhMQhS/7mnH+vLiUt33BY9zsVRshV1EARDkL?=
 =?us-ascii?Q?4R7lVvFZsQgg1BzMQ0E8vr8MRL7NY2n4AcQXxrlguPQhIkY8s/oe4dznWGuP?=
 =?us-ascii?Q?W02GsijZEzIdTkpZR5oudltwAHejWpGZCH0Kp4GgI+RgY3OfZeGnzngqbYsV?=
 =?us-ascii?Q?7ocu/gdCEAY892eEyc8j2LcXJ4Qa0oAylZX5ShQisX0mj4NMWbcpRCziUPOh?=
 =?us-ascii?Q?dpQnHFNHk0A3NFlAhdLf4QyBr957dm6N70YfatJqehZBAriEb4gQ9YTErxAh?=
 =?us-ascii?Q?gCGkqgRNHd9ByZbsYAVQtZEtIrr+SBk1m5/oASPHDO+DKBTyYgHVOYws9wq5?=
 =?us-ascii?Q?8TvG3ouAOmz1WsXlSkJYGrrBhHVZ1PSB46X5zGQpLJD6b74gz1Kghlma4YHS?=
 =?us-ascii?Q?r9iPc1XtvziGdDN2xN4uiMKf/HPmAo0hFHy/WIXleQ1NQlIyNYt1vKGxxMcq?=
 =?us-ascii?Q?lxECd1n8899AZSLgyY8ZxsyHFKb3/Q3R0WzRrzL/AMtXrs96XheaewXlpA77?=
 =?us-ascii?Q?9hxO15SE/JQGctu5gBrQySwWlTxdENE8eNg0pQHeGvxPXh7IAGMy4AO+LS4Y?=
 =?us-ascii?Q?1oKfJLqucp4De0PZrurYu7YJGai5g8hos/eYdARFSn8oURYuxfjvfc5L4b36?=
 =?us-ascii?Q?d3s9nGUN3BV57HKI8QMdN3ULuIkh7Vb16LEhoebSbiH0tUS8IqpJsTHAGrOA?=
 =?us-ascii?Q?iYPdE895WGjZ3Gw5cIXggcdT2bc9wboP84H927gWu5oTBxAMxlYaMnfUHiud?=
 =?us-ascii?Q?ej552IUki1aK5iQm5F1+kuH57dtD0YKFyDFbf2/bMSeyzs4AA6D2C+RupYTF?=
 =?us-ascii?Q?wRrvs8Xxgea8cO9Co1g0Pn41nIrE44qDoXyhpjrzw+pVFO5GSEKDOIG7zavG?=
 =?us-ascii?Q?CIH7ew2+Lnv4kGausYOfpQjRmuItgn3SFkEYs8s2/D9vgXUTT4JACnbduuTE?=
 =?us-ascii?Q?qGSBbKybO/kaj3UkNIES32cM0ywW4rReZs2z8hTdN/gG8PrmcIT+VX8/slUK?=
 =?us-ascii?Q?DqUkcg8qHWsghYSF5HJpM1vxsVf8aYU1aooUet1e?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0958a70d-ac72-440a-f52e-08dacb7022df
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 03:26:10.8069
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZJx5+6lp9s7NCRZ53FYU1vu4p6+uH7yzeOd1PkqDUjpQZHH/miuDQiJ3m2DAtKdvGE/9Gozkoe/MW8ZoQps0ZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5309
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Friday, November 18, 2022 8:26 PM
>=20
> >> +	xa_for_each_range(xa, idx, desc, ctrl->first + base, ctrl->last + ba=
se) {
> >> +		if (!msi_desc_match(desc, MSI_DESC_NOTASSOCIATED))
> >> +			continue;
> >> +
> >> +		/* This should return -ECONFUSED... */
> >> +		if (WARN_ON_ONCE(allocated >=3D ctrl->nirqs))
> >> +			return -EINVAL;
> >> +
> >
> > why is "=3D=3D" an error?
>=20
> because if you get here _after_ having allocated all interrupts already
> then you have more descriptors than what you want to allocate, which
> should never happen right?

yes