Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        "Chatre, Reinette" <reinette.chatre@intel.com>
Subject: RE: [patch 17/20] platform-msi: Switch to the domain id aware MSI
 interfaces
Thread-Topic: [patch 17/20] platform-msi: Switch to the domain id aware MSI
 interfaces
Thread-Index: AQHY9dWDKC7bX1kJYkW+2YkiV/i4l65EaQ8QgAA9XQCABCAEoA==
Date:   Mon, 21 Nov 2022 03:42:20 +0000
Message-ID: <BN9PR11MB5276EB567D822DA9148BEB3A8C0A9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20221111131813.914374272@linutronix.de>
 <20221111132707.005001510@linutronix.de>
 <BN9PR11MB5276453E63A0C02A4BB386F58C099@BN9PR11MB5276.namprd11.prod.outlook.com>
 <87fsegjvn3.ffs@tglx>
In-Reply-To: <87fsegjvn3.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fPMUCQDIYv5kpd36jtkp6FGSh18d9UkFKgXfyz3v9e4l168/vjhHuM7+NkrU?=
 =?us-ascii?Q?hkZTH5ihAQi/F96B+WyWr1j6+OkXmwXOPXi32KJ0Abn9hV0hcia7FzEoly47?=
 =?us-ascii?Q?mRV+aD89cqFJLWS7hBfN1Z0bvyN9vxq6SFBo/xf9vCw/mUrqxunp13dnHrnh?=
 =?us-ascii?Q?OQ/y5uAtswDzXGafZvxvae+De+mZfcqCieJPXz9/qAC3ij/mxS1ZNY8pvAHc?=
 =?us-ascii?Q?Bg5Q9rCJIixYkqomEzAa20WwXuTP6pzRDao1qGIvn79iDheedSuygHX0Jljd?=
 =?us-ascii?Q?+mGblmL+6bgS5G4qbKYPV1Xr8DbR5FjuzxlwOFPsOqjZYN9HI9sv2IEOhqAm?=
 =?us-ascii?Q?WuhL1w38E9arui7iNuJqW5I9JcCDTH+1ipectx3qliRA/DMJiarLBm6IUYW7?=
 =?us-ascii?Q?zNq/TGkRsVnLx0q6KyBsIFJC4ey7lQD9HSG2HqZXsJZwZmlpJONchEK8FaQo?=
 =?us-ascii?Q?Gr58q68Rss3Woudv9sQ/XA2JYST5iWsh5f9HfKgidQqFAUJtHVu66ovt0x3t?=
 =?us-ascii?Q?wVhe3xOzWKtDPBnyqjYcRShDTgEwcvBNeFWcQijOiLplc3vWCqPpGQhWdr6D?=
 =?us-ascii?Q?/CTQVHKsGQME8Yih5d1Lo8++qa4LgUbPs0VJ5ITeujQkk6IVRnznf0Jq6uXq?=
 =?us-ascii?Q?wroHxasqRIWPB7Muxvm52vg0uUKPPbct5J3eCbeeKDCHq6sD0LziUG6u2G7C?=
 =?us-ascii?Q?dxdRA1+pe+Vhh7rl7JBI8Hr+vI/8U+PgvzvaHMxYb6j3sMITj/0AEL/2OT47?=
 =?us-ascii?Q?bHx3qbwaRjgY9ljWYXuXxw1vTiTDjCK5Fm4cJkzhgAWNHhaMWosuJgmraD90?=
 =?us-ascii?Q?DaweVzZ+mhMnFKAwN4eKLR7r9qI1qmJ5GmhWFdluvEwVZ54CdEYcfaMb1kJp?=
 =?us-ascii?Q?+eXmyUsTs9v31dKF7zwqmcra8xertevc2CaU5+VrgrYSH4rwEc9THIUC55fh?=
 =?us-ascii?Q?6imr0B+lpL9VdngTpsItvP7iKLj0klJH6kovHmiS4JJlsJ5p2fwnaO3hjPL1?=
 =?us-ascii?Q?QP5X2OQYECwqbEkH8HN9No33NVeqfz2vjiCp8h1CEoaCdAcgbx7QAMdI7CQf?=
 =?us-ascii?Q?oIi43uP1K1qtQCikOZ52M53OslL2P0o0QcOFcaqCdrzEliwBXBRE4rRYeKl3?=
 =?us-ascii?Q?2CgTXGq1eiDis6mcmzokyKqzSxRjIs5JHTULWllJQJaH/6yeS0AB4Vw+yknv?=
 =?us-ascii?Q?7EXsxNZRSNWx+akkVJRzc86/94vtRFz5QKmpMgIXZ5wv7SctBAX+lWEQj4oT?=
 =?us-ascii?Q?AjQTLyK8DBhfRCHIVMM7mn8zZjx02asGArOWq2uCi1Qkb8k0PmHK0cotsgj+?=
 =?us-ascii?Q?NzpwGjfxs8b4+fiL568KUsipSJQ6YXa9B5gSX95dIEpFGMZ2NszD4iMhm8mK?=
 =?us-ascii?Q?n4SD08D2YjyGhajT3nOANxbwVMEdOESf9ZpHcqcmlvWbpN/rCqRkBA1duLrH?=
 =?us-ascii?Q?m3lHiB3ub68DQjqDvkIEic2bXn0ykXtNpu3aRWLKgSFMAX1GvvB/VLdWVm+2?=
 =?us-ascii?Q?4tdf/mBaOqnBQmAeHGJ6DDwkn8uc6WTzzPLiNWJwmspGeZfGEPBFVsAjfytg?=
 =?us-ascii?Q?82mvu5x1LY31AUNhtUHMtPf5bLIKPXmI9RkACWxV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: afb1d144-2303-4b9f-b256-08dacb7264a2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 03:42:20.0790
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g8mQ9Ku8H/WM62Q4YSjSFqMb+IOY0YuHEHB2EojjxBfz43nXvTJum31ShQqjYY2Q1G89gsH3nIKJWfpgYccNeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6393
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Friday, November 18, 2022 8:27 PM
>=20
> On Fri, Nov 18 2022 at 08:53, Kevin Tian wrote:
> >> From: Thomas Gleixner <tglx@linutronix.de>
> >>
> >> -	err =3D msi_domain_alloc_irqs(dev->msi.domain, dev, nvec);
> >> +	err =3D msi_domain_alloc_irqs_range(dev, MSI_DEFAULT_DOMAIN, 0,
> >> nvec - 1);
> >>  	if (err)
> >>  		platform_msi_free_priv_data(dev);
> >>
> >
> > Out of curiosity. Why don't we provide an unlocked version of
> > msi_domain_alloc_irqs_all()?
>=20
> -ENOUSER

msi_domain_alloc_irqs() and msi_domain_alloc_irqs_descs_locked()
are a pair.

What I didn't get was why the unlocked invocation in this patch
is replaced by a range-based helper while the locked invocation
in previous patch16 was replaced by an all-based helper:

	if (domain && irq_domain_is_hierarchy(domain))
-		return msi_domain_alloc_irqs_descs_locked(domain, &dev->dev, nvec);
+		return msi_domain_alloc_irqs_all_locked(&dev->dev, MSI_DEFAULT_DOMAIN, n=
vec);

The reason could probably be marked out in the commit msg.