Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3808319rwb; Sun, 20 Nov 2022 22:51:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ph3UIXVfr6NibWDw863rISnqTDZw8K4q6K955SvkEr9P3FCWNMRI9gP7WVQVgTmQ9gLWs X-Received: by 2002:a17:902:ec82:b0:176:be21:409c with SMTP id x2-20020a170902ec8200b00176be21409cmr10702484plg.14.1669013497047; Sun, 20 Nov 2022 22:51:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669013497; cv=none; d=google.com; s=arc-20160816; b=ykMRmEm1zXZ50uHn79d8QvxuDKvgMXPx4pzIx3rje3UqMw+NvM/+FYHJ+i5sBEJ4Pi Vz9Q5C73sXxQJoQ7AA7xSK4EcE83+ADd7JrqrxqK0yItaavgUng/2E+o0Kx+D15tUBJ9 JbTeM6vBflW67B1zEmdDnurOpSoE+E0y0vXwCARQXQXH7wG8cnquWvJk7q0MzKj/MPam e6Subzns01VjBfe8zsx0rpJdokuZO1QlRX6IxuDNNiPBEfyX4/tOigPvviQglRd9aR3o PL1qEY2WIeC/7djkvSfRmnNcIhClIPxdIBp4hnqXqcF1OGeiu5OPweQE0WAfndE20vIq xYag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=EOs0qwxAH2/pioGUQjAqQZCo5hozuq4moR5tVBbEUtg=; b=gBQQGs89AFxJnmJzxZKD2TCbYxAD9CYCyQdtjbByskxM11RJ4GcAObBRcbJyOSE7s3 LyGM5enNLXAefHGDlKtmfNo+WTDhopQfuM+vVTRO/NEdUN6GpNk0xUTaMxTEHa9Xk41T FLBm1vtycFWTkEqxsW82a/yLve1hVClIIQ2Si9VYSnNtzRUY9b9TWyG84usjzr9jrTdr hS5SeyRZWYw4QqKC7fuZZwBz2K8010vy4sGCscT83TDNlRzQwFNFv+mYb6BN3vzpVY9l /YaD3FV4bSp2hp9y+dxvTmWI1DUefaoKl/RADXDGRKshHsB27OfToKcA5iUjCcuq72I0 SuGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KfOTHl7g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j15-20020a170902da8f00b001872e6c5c63si12301545plx.49.2022.11.20.22.51.24; Sun, 20 Nov 2022 22:51:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=KfOTHl7g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbiKUG0G (ORCPT + 92 others); Mon, 21 Nov 2022 01:26:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbiKUG0E (ORCPT ); Mon, 21 Nov 2022 01:26:04 -0500 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B90A26571 for ; Sun, 20 Nov 2022 22:26:02 -0800 (PST) Received: by mail-qt1-x82b.google.com with SMTP id cg5so6715246qtb.12 for ; Sun, 20 Nov 2022 22:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EOs0qwxAH2/pioGUQjAqQZCo5hozuq4moR5tVBbEUtg=; b=KfOTHl7grc1+6ZofGZsTdaxAlmOrRNoG6BfBMqSr8xX4NIhIqXAva2jAsFnxYEkdkS Ee1Zgia2BPvpj4cOA6FtPSgT7119UG5yKsQdECWZj+M32SeyC9RtXIhWjM4Y6c+rogP+ IupooRNF5leuyXXUTOqGEBswe0AdgqCvZHERasju3qalsZmMIIMJxFdXiYGCzMeexGSI YL49rQ0fwc42sA0G9WcDi2jlbQyUwB7ZYuR5uNrllf2n9LwJe5HE/2EJ6Ow25nR9ZMOa Lv4Ux0oYjcysVysviLeqSLSw8pHzabg4Dmc3qwxyOG1Kzavve2uh6WZFC9U5n7QFZ4/l tKPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EOs0qwxAH2/pioGUQjAqQZCo5hozuq4moR5tVBbEUtg=; b=craIOr/lAkR6IwN8zs+u4L/Am8oDjg+su9HslxRGcquwmg2P8kQAU4RJsr8qeZmhuo +0UiNV0alKRFoffnVfVybiXwHv3mU9wz+6OnzzkHsbHlXNh2mNDfNKqAOnq99ooNjLvy woAAmnMjQwXDFI566W5Z/mzXtIwMZKAjIaKNrPwyOAjL6KGo2jZdblLv9+jjBKQ7RziW RNE4HVdztdLI0saczHn1CaMVZpB1jqFCukcwbNeT+/iNIpwufvPlwjtOPc7TUBGk/WLJ LbnEX+RdhjdkSOb950TGWK6S+ty1DMePJ87pHEELZDKLzhUabcK7BxqlsOcyfzY6I3rs W36g== X-Gm-Message-State: ANoB5pkCrpdQLbcVnMKI0fR8VDLqpPt3EIGiH7jGouEqIr4PlaByhJdi u0jKWe8/mgJKxmA5WqqkNRWvPIeGmp3h9k3XvAI= X-Received: by 2002:ac8:7cbb:0:b0:399:83a8:c28b with SMTP id z27-20020ac87cbb000000b0039983a8c28bmr4786015qtv.447.1669011961658; Sun, 20 Nov 2022 22:26:01 -0800 (PST) MIME-Version: 1.0 References: <20221119204435.97113-1-ogabbay@kernel.org> In-Reply-To: <20221119204435.97113-1-ogabbay@kernel.org> From: Dave Airlie Date: Mon, 21 Nov 2022 16:25:50 +1000 Message-ID: Subject: Re: [PATCH v4 0/4] new subsystem for compute accelerator devices To: Oded Gabbay Cc: Daniel Vetter , Greg Kroah-Hartman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Yuji Ishikawa , Jiho Chu , Daniel Stone , Tvrtko Ursulin , Jason Gunthorpe , Jeffrey Hugo , Christoph Hellwig , Kevin Hilman , Jagan Teki , John Hubbard , Alex Deucher , Jacek Lawrynowicz , Maciej Kwapulinski , Christopher Friedt Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Nov 2022 at 06:44, Oded Gabbay wrote: > > This is the fourth (and hopefully last) version of the patch-set to add the > new subsystem for compute accelerators. I removed the RFC headline as > I believe it is now ready for merging. > > Compare to v3, this patch-set contains one additional patch that adds > documentation regarding the accel subsystem. I hope it's good enough for > this stage. In addition, there were few very minor fixes according to > comments received on v3. > > The patches are in the following repo: > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > registers an accel device using the new framework. This can be served > as a simple reference. > FIx the nits Jeffery raised and the one I brought up and I think we should be good for this to be in a PR. Reviewed-by: Dave Airlie