Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <795deac4-71fe-d40b-a3b6-855eb3875ad1@linaro.org>
Date:   Mon, 21 Nov 2022 09:26:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 1/8] dt-bindings: power: supply: Add DT schema for
 Qualcomm SMBCHG
Content-Language: en-US
To:     Yassine Oudjana <yassine.oudjana@gmail.com>
Cc:     Sebastian Reichel <sre@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Alejandro Tafalla <atafalla@dnyon.com>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Yassine Oudjana <y.oudjana@protonmail.com>
References: <20221120154625.57095-1-y.oudjana@protonmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20221120154625.57095-1-y.oudjana@protonmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/11/2022 16:46, Yassine Oudjana wrote:
>>> +  interrupts:
>>> +    items:
>>> +      - description: Charger error
>>> +      - description: Charger inhibited
>>> +      - description: Charger precharge safety timer timeout
>>> +      - description: Charger charge safety timer timeout
>>> +      - description: Charger pre to fast charging switch threshold reached
>>> +      - description: Charger recharge threshold reached
>>> +      - description: Charger taper threshold reached
>>> +      - description: Charger charge termination threshold reached
>>> +      - description: Battery hot
>>> +      - description: Battery warm
>>> +      - description: Battery cold
>>> +      - description: Battery cool
>>> +      - description: Battery overvoltage
>>> +      - description: Battery low
>>> +      - description: Battery missing
>>> +      - description: Battery thermistor missing # unconfirmed
>>> +      - description: USB input undervolt
>>> +      - description: USB input overvolt
>>> +      - description: USB input source detected
>>> +      - description: OTG regulator failure
>>> +      - description: OTG regulator overcurrent
>>> +      - description: Automatic input current limiting done
>>> +      - description: USB ID pin changed
>>> +      - description: DC input undervolt
>>> +      - description: DC input overvolt
>>> +      - description: Power OK
>>> +      - description: Temperature shutdown
>>> +      - description: Watchdog timeout
>>> +      - description: Flash failure
>>> +      - description: OTST2 # unknown
>>> +      - description: OTST3 # unknown
>>
>> It seems you listed register interrupts, not physical pins. This should
>> be interrupt lines.
> 
> I'm not sure what I'm supposed to do here. I couldn't find an interrupt-lines
> property used anywhere so that's not what you meant, right?

Are these physical interrupt lines this device has, register offsets or
virtual interrupts (e.g. passed via irq_chip)? Definitely not the first
and rather offsets for qpnpint_irq_domain_translate. Devicetree is not
for describing register layout of devices. IOW, register layout does not
change on different boards, because the device is exactly the same, so
there is no point to put it into DTS.

Best regards,
Krzysztof