Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5df2c4d5-f426-e3ea-8e6d-f772ec7091b6@intel.com>
Date:   Mon, 21 Nov 2022 10:25:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH 0/3] mmc: Improve block layer requeueing behavior
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>,
        =?UTF-8?Q?Christian_L=c3=b6hle?= <CLoehle@hyperstone.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>
Cc:     Avri Altman <Avri.Altman@wdc.com>,
        "vincent.whitchurch@axis.com" <vincent.whitchurch@axis.com>
References: <f30ec7fe7d834c1d8e116508500110cf@hyperstone.com>
 <c1e1281e-0977-cbf7-041e-db911ee722a7@intel.com>
 <d1a1340a-f5f8-6953-e066-b8c6095d63fd@acm.org>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <d1a1340a-f5f8-6953-e066-b8c6095d63fd@acm.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 18/11/22 19:27, Bart Van Assche wrote:
> On 11/18/22 02:47, Adrian Hunter wrote:
>> On 26/10/22 10:30, Christian Löhle wrote:
>>> Mmcblk relies on block layer requeueing to fulfill some requests under
>>> certain conditions. Improve the handling to get nicely ordered requests.
>>>
>>> Using the terms a bit loosely to get a point across:
>>> Current behavior for 512 blksz and max_blk_count = 1 the scenario would
>>> be as follows:
>>>
>>> - request for page 0 lba 0 to 7
>>> - request for page 1 lba 8 to 15
>>> - request for page 2 lba 16 to 23
>>> - request for page 3 lba 24 to 31
>>>
>>> mmcblk modifies data->blocks = 1 for each and requeues,
>>> this leads to:
>>>
>>> Access lba 0
>>> Access lba 8
>>> Access lba 16
>>> Access lba 24
>>> Access lba 1 (1. Requeue for page 0)
>>> Access lba 9 (1. Requeue for page 1)
>>> Access lba 17 (1. Requeue for page 2)
>>> Access lba 25 (1. Requeue for page 3)
>>> Access lba 2 (2. Requeue for page 0)
>>> ...
>>>
>>> Of course we would rather have lbas consecutive.
>>
>> Does anyone know why the block layer does not support
>> (max_hw_sectors << 9) < PAGE_SIZE ?
> 
> Hi Adrian,
> 
> Does this mean that the following patch series would not only be
> useful for UFS but also for MMC? "[PATCH 00/10] Support DMA segments
> smaller than the page size"
> (https://lore.kernel.org/linux-block/20221019222324.362705-1-bvanassche@acm.org/).

That patchset still does not allow max_hw_sectors = 1 which is
what Christian's case needs.