Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH] f2fs: introduce discard_submit sysfs node
Date:   Mon, 21 Nov 2022 16:28:03 +0800
Message-Id: <20221121082803.58694-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I2AgKfoR2COIp5YrbYjmxp5ayEDbZMfVPOlRu8s6+r5kzYpNDqx+7AMtoZRi?=
 =?us-ascii?Q?zZB7oDqOfNx+TfIYUx73mXFpN2xdmu1A7E2GEDVfGfyHk8fmX7ZsNrbbcFgR?=
 =?us-ascii?Q?WStty1Xl+hXpE1bWprangvW2O0GTt9wK70BRdNj0dKvRLxWNkpUVROMnrIFp?=
 =?us-ascii?Q?OKhfeFcwUtCUJ5eSygwLYqHxMfqBVE8ouJ10Nxi1J9auVec22nDhvKMVgotk?=
 =?us-ascii?Q?mDYRmBxJKJUEyWi3cZYOMprXwSHqPk6wfb3RUkkNgBz1QXgQd2ieXelJiMiw?=
 =?us-ascii?Q?fuwZgJRgKNSM4qjv11dR3b80yM2zwang2UQk3Axahz0Ov9uTzqvC+8FQoHP3?=
 =?us-ascii?Q?lZV5YMiF1yauS1YtrK9iLI0wHjPvVJiV1bAQkOrtEV0dv2zG1fJuTHC3iF63?=
 =?us-ascii?Q?+bLxKYRcKWrIQj9qp8vEb4tCW5FhCVYzyxIf/axwOQYFlOn7xWx/fllLrdlh?=
 =?us-ascii?Q?o2SGegsVx1yebSgNTASMcuDQ76J9TGuTeHqCZWM8aPxn6IlZosgPFMAzaD7l?=
 =?us-ascii?Q?QKIJIrD0w7UMMjud72dkZ6Hco9nrt/3YjtVozWC82eOJepRKXEO0B0s+KCdv?=
 =?us-ascii?Q?YXBpwFM5mYMJUmr+cJsP8kTP4elLLIvhwFUtZ3vWO+c8FTHHz9XZJT/Dh5SL?=
 =?us-ascii?Q?vNzGt3Qba1SvdIG9kcKK35oQprCBT0iQQ1JHVBLLMFsynTYkCcQ5dpyLG35V?=
 =?us-ascii?Q?1gpt0yoPdlXzpYOJLeN52smbEW8FpEF0G+WYGYPk4SaS2lM0zURo8SqURxI1?=
 =?us-ascii?Q?Q1JRwMjvliz6QxIf+P1s+YF9qC/gDCjseuMz7Y7zLV6jYHkHDlsyNfOkxZOy?=
 =?us-ascii?Q?/arlsJekg1+AgNYN4XR2v8eB5W22XQiy28kVPbHK1RfIlJmFsGue/e9f/nM5?=
 =?us-ascii?Q?Uw8W4lXAOOmdVnBcdmKFwtI0luOK33JcnrKbSOY7Kv554ZjBGgGqbgoqSn4M?=
 =?us-ascii?Q?9bOaC95XPTvbH9ndfttn7W89bSqQ3R7ieKTbqtEnw4tSnv4Z6lvsigE63pec?=
 =?us-ascii?Q?1nPfmEydqVnfwdMv6XA8Q38UUifjJ+G2a4mJ7vb8JFzWF73xzvUX4IIBLebG?=
 =?us-ascii?Q?krioY4lSzSyszyXqyT5Hqx0qi5yGPlkLqxEnL0PgVrrxuIWC5ISpfJ3hQFfk?=
 =?us-ascii?Q?MYmnPCNyQ/RK4IyxYEYqwktxWVDgt+M4K2zVvL4qeZpruRLPMN+4xBjA+cH1?=
 =?us-ascii?Q?Ws2RWreUZn4P8+flKmnBPMP/1x7uMj8mC10YKpaIx5mecmd73qvs+WjA/Grw?=
 =?us-ascii?Q?zi43QmaXTclxI2wKdn/S5dIZ5G609NTCjI57wYkQ76IaVwRWfx5RGd6lLwie?=
 =?us-ascii?Q?nrSqVMd+q5gPQeWf7beLUSjfjbIYpJVDVt6KiDJJb1HJEYeJjQhklHeeEt2e?=
 =?us-ascii?Q?7JJxI6rYeJdrmO/GK93zvoKZ1ujRUBtcmVAot67A2NJs/+fkzNBSocfiCuHY?=
 =?us-ascii?Q?ku9WHKKzqPJyTx/65+vpW9EsAmEa+fhUfvIRFI9SDBgO5uKb+6n6FuTCK197?=
 =?us-ascii?Q?K6JSyv9nciLe0ZPfMC9mGyrCN80RQg9GZM/tKKk3N+qOrXiPs4BDyhtDEXTV?=
 =?us-ascii?Q?kv7/yCGcPBVGnBAuoJ+bTAn2K5qVUxBHgY9ECfye?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ca5f25c-261a-47e3-984d-08dacb9a54c6
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 08:28:13.5612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jMV9TKMAq6e9Bcai402pFZ1rwZJ2Wj7o4am8rbdN/z+XgWjvnZjVa/RbwjZCtkiSpoEu46tfEPD7vA4N8J/6zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5001
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

'discard_submit' sysfs node controls whether discard
threads are allowed to submit discard commands. And
writing a non-zero value to this node will force the
discard thread to wake up immediately.

Some scenarios where this node can be used:
  1. A large number of unsubmitted discards have accumulated,
	 and the thread still runs at the max_discard_issue_time
	 interval, and the thread needs to be woken up.
  2. A large number of discards have been accumulated, which
	 will affect the submission of other commands of the device
	 when submitting.
  3. In some specific scenarios, it is necessary to observe the
	 regularity and distribution of the discard command to
	 optimize the discard merging algorithm or other.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 Documentation/ABI/testing/sysfs-fs-f2fs | 10 ++++++++++
 fs/f2fs/f2fs.h                          |  1 +
 fs/f2fs/segment.c                       |  8 ++++++++
 fs/f2fs/sysfs.c                         | 11 +++++++++++
 4 files changed, 30 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs
index 24e7cb77f265..2f42ce42ab9e 100644
--- a/Documentation/ABI/testing/sysfs-fs-f2fs
+++ b/Documentation/ABI/testing/sysfs-fs-f2fs
@@ -646,3 +646,13 @@ Date:		October 2022
 Contact:	"Yangtao Li" <frank.li@vivo.com>
 Description:	Show the current gc_mode as a string.
 		This is a read-only entry.
+
+What:		/sys/fs/f2fs/<disk>/discard_submit
+Date:		November 2022
+Contact:	"Yangtao Li" <frank.li@vivo.com>
+Description:	Controls whether discard threads are allowed to submit discard commands.
+		When set to 0, the discard thread running time will be changed to max_discard_issue_time,
+		and the discard command will not be sent to the device. Otherwise, writing other
+		values to this node will force the discard thread to wake up immediately, and
+		the discard command will be allowed to be sent to the device.
+		Default: 1
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index f0833638f59e..81e5816e4b34 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -420,6 +420,7 @@ struct discard_cmd_control {
 	atomic_t discard_cmd_cnt;		/* # of cached cmd count */
 	struct rb_root_cached root;		/* root of discard rb-tree */
 	bool rbtree_check;			/* config for consistence check */
+	bool discard_submit;		/* allow submit discard cmd or not */
 };
 
 /* for the list of fsync inodes, used only during recovery */
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 8b0b76550578..5b0a67ccdac3 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1115,6 +1115,9 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
 		return 0;
 
+	if (!dcc->discard_submit)
+		return 0;
+
 	trace_f2fs_issue_discard(bdev, dc->start, dc->len);
 
 	lstart = dc->lstart;
@@ -1717,6 +1720,10 @@ static int issue_discard_thread(void *data)
 			wait_ms = dpolicy.max_interval;
 			continue;
 		}
+		if (!dcc->discard_submit) {
+			wait_ms = dpolicy.max_interval;
+			continue;
+		}
 		if (!atomic_read(&dcc->discard_cmd_cnt))
 			continue;
 
@@ -2085,6 +2092,7 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
 	dcc->min_discard_issue_time = DEF_MIN_DISCARD_ISSUE_TIME;
 	dcc->mid_discard_issue_time = DEF_MID_DISCARD_ISSUE_TIME;
 	dcc->max_discard_issue_time = DEF_MAX_DISCARD_ISSUE_TIME;
+	dcc->discard_submit = true;
 	dcc->undiscard_blks = 0;
 	dcc->next_pos = 0;
 	dcc->root = RB_ROOT_CACHED;
diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
index 33ec467b3772..b6f017b4d565 100644
--- a/fs/f2fs/sysfs.c
+++ b/fs/f2fs/sysfs.c
@@ -661,6 +661,15 @@ static ssize_t __sbi_store(struct f2fs_attr *a,
 		return count;
 	}
 
+	if (!strcmp(a->attr.name, "discard_submit")) {
+		struct discard_cmd_control *dcc = SM_I(sbi)->dcc_info;
+
+		dcc->discard_submit = !!t;
+		if (dcc->discard_submit)
+			wake_up_discard_thread(sbi, true);
+		return count;
+	}
+
 	*ui = (unsigned int)t;
 
 	return count;
@@ -800,6 +809,7 @@ F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, max_discard_request, max_discard_req
 F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, min_discard_issue_time, min_discard_issue_time);
 F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, mid_discard_issue_time, mid_discard_issue_time);
 F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, max_discard_issue_time, max_discard_issue_time);
+F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, discard_submit, discard_submit);
 F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, discard_granularity, discard_granularity);
 F2FS_RW_ATTR(DCC_INFO, discard_cmd_control, max_ordered_discard, max_ordered_discard);
 F2FS_RW_ATTR(RESERVED_BLOCKS, f2fs_sb_info, reserved_blocks, reserved_blocks);
@@ -930,6 +940,7 @@ static struct attribute *f2fs_attrs[] = {
 	ATTR_LIST(min_discard_issue_time),
 	ATTR_LIST(mid_discard_issue_time),
 	ATTR_LIST(max_discard_issue_time),
+	ATTR_LIST(discard_submit),
 	ATTR_LIST(discard_granularity),
 	ATTR_LIST(max_ordered_discard),
 	ATTR_LIST(pending_discard),
-- 
2.25.1