Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <902bb40e-3eb8-cee6-cd6e-849d2fd87f15@huawei.com>
Date:   Mon, 21 Nov 2022 17:32:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] ubifs: Fix build errors as symbol undefined
To:     Richard Weinberger <richard@nod.at>
CC:     Sascha Hauer <s.hauer@pengutronix.de>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        yusongping <yusongping@huawei.com>
References: <20221115083335.21211-1-hucool.lihua@huawei.com>
 <23feff35-6f2d-5cd7-57f9-ff2591a3c74e@huawei.com>
 <433070166.256175.1668893150374.JavaMail.zimbra@nod.at>
 <ed4618a5-67b4-7ee5-f172-a2709ee738fa@huawei.com>
 <540631712.260900.1669017601995.JavaMail.zimbra@nod.at>
From:   "Lihua (lihua, ran)" <hucool.lihua@huawei.com>
In-Reply-To: <540631712.260900.1669017601995.JavaMail.zimbra@nod.at>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Follow your suggestion, I will push a new patch，Thanks.

在 2022/11/21 16:00, Richard Weinberger 写道:
> ----- Ursprüngliche Mail -----
>> Von: "Lihua" <hucool.lihua@huawei.com>
>> An: "richard" <richard@nod.at>
>> CC: "Sascha Hauer" <s.hauer@pengutronix.de>, "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel"
>> <linux-kernel@vger.kernel.org>, "Wei Yongjun" <weiyongjun1@huawei.com>, "yusongping" <yusongping@huawei.com>
>> Gesendet: Montag, 21. November 2022 02:54:53
>> Betreff: Re: [PATCH] ubifs: Fix build errors as symbol undefined
> 
>> You can verify it with the config in the attachment. TKS :D
> 
> Thanks for your .config, I was able to identify the problem.
> When CONFIG_CC_OPTIMIZE_FOR_SIZE is set the compiler does not optimize this construct:
> 
>          err = ubifs_node_check_hash(c, buf, zbr->hash);
>          if (err) {
>                  ubifs_bad_hash(c, buf, zbr->hash, lnum, offs);
>                  return 0;
>          }
> 
> With CONFIG_UBIFS_FS_AUTHENTICATION not set, the compiler can assume that
> ubifs_node_check_hash() is never true and drops the call to ubifs_bad_hash().
> Is CONFIG_CC_OPTIMIZE_FOR_SIZE enabled this optimization does not happen anymore.
> 
> So we need a no-op ubifs_bad_hash() for the CONFIG_UBIFS_FS_AUTHENTICATION=n case.
> 
> Thanks,
> //richard
> 
> .
>