Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d01e43f-62da-5413-e76d-f12b72944d08@intel.com>
Date:   Mon, 21 Nov 2022 12:49:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] ASoC: Intel: Skylake: Fix Kconfig dependency
Content-Language: en-US
To:     <lili.li@intel.com>
References: <20221121104742.1007486-1-lili.li@intel.com>
CC:     <tiwai@suse.com>, <perex@perex.cz>, <broonie@kernel.org>,
        <kai.vehmanen@linux.intel.com>,
        <pierre-louis.bossart@linux.intel.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20221121104742.1007486-1-lili.li@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkRxekpTd0hhdUJJRURuN3FucUIweE5LRWI4NkNUT0kzNHMzQkcvMmhyc1Q3?=
 =?utf-8?B?QkxHalBaQ0VPbEx4UE9XdFd5S3JweCtDWG1XaVBYMVJ4dlM3VzBDbmRCQzcz?=
 =?utf-8?B?a2QwbUpZc1ZESmlzZ0tQZmRCbldEL0NpYzVsNTFBRVZTQnczbTF4ZjFKOWhj?=
 =?utf-8?B?NlJGRTlhQmZmMGk1K1hIamZQaXQwU2xQaHE3UkYrSGVsZVdaV2JTdUtnN3Jy?=
 =?utf-8?B?UmNvNk11SU5vZzZ4RTZ3eDZhM3BweDl3bzE3a0JNY2EySThrZXhUVHNZREZQ?=
 =?utf-8?B?OFlPZlptSzRUdExZbE5UT3VFd3IxdlViOFZVNitpVlF6RkUxK2ZveXhwb3ho?=
 =?utf-8?B?elZPZUQ4NGhDS25KWmp0c2tNbUE3ZVJHdzZ0emtaZmw2bnE4bFZKNE5WK3dw?=
 =?utf-8?B?ZmlXRzN6QkxmMTB0MGVaemxDRGp1V2tzbE9CNnFsanFuSWdqcEdvbHd3Yjdu?=
 =?utf-8?B?bzQzSHAwK0RnSTFkczlLOUhkQ2F3VFZGMG1yUzdrbFV5b0oxWHFSSnhaaHVV?=
 =?utf-8?B?N0hRTW5pdXRmNFdpWUVhV1IxcDFKRmFnVlZEMHRYa1J6VFNWQXE3TTgzSlRR?=
 =?utf-8?B?THVFSHFTYm81aWRYeFpOS2F4N2F6Wi9heUlnbkhXdk1Qb1RBdWYvSXk2NXdJ?=
 =?utf-8?B?bG83bC9sNGhnaWV4QlZUSUE4c3NwMG1sOU9aRjNDQ1JxTkJlYldtYU1yaFpj?=
 =?utf-8?B?ckp5YnhzK1JGZ1cvbU1uaWxVSTE5SFU2ZDQwbFdycm1aUDJOSVpZY29qMlhs?=
 =?utf-8?B?UTB6cGEvYjgzcmFNY3lzVmRyZEduM1gzOVQwUHR3Y1dvdkgreVFrSXZNdmNF?=
 =?utf-8?B?WFNCOUJLcFNMK1pydnh1cVhZUkttK3RpbDAzck1YQUJpOGNoZTE3YW1MZnRl?=
 =?utf-8?B?SE1QVDhqaEFlZWczc3UzK285Mm5nYWVKd0ZOYWhwT3lxTjdFelNwVk9iWGF4?=
 =?utf-8?B?WWQyTS9KSGRmNlFCYkRRWnRsQVlFeklIemdtTW9SUitqRk0rZmJrOGphbDBJ?=
 =?utf-8?B?RFZxZGxIdDAzKzlLVmU3dnN1dExiZHZiQWtGbHJoSUcrempEcHdHUFZ0d3Nz?=
 =?utf-8?B?cDkrVVJTT0VuMzk1Nmw3SFR5ektqNUVlUVlJcXhlS3hBZm10bE80ZUQwdldu?=
 =?utf-8?B?Mmp6RFJFOStqVVFXNE1ncFZDWjhKRHhTRWdMK1lqaXVHRmM4aU84M0FqSkFC?=
 =?utf-8?B?ZVlpS043R2ZJNFFnMjh1TmpVZFZRM2NRMm8zdk9JWTlwdWluZmdOa1IwNVBt?=
 =?utf-8?B?bG9qc0JjUEdLVnBxR2RWVm94VmZnM1ZZM3U3c2tYWDNidCtaQUtoTzN4aEtS?=
 =?utf-8?B?VE9tWDFZRDdPZml0M1hqZStoMVZ0ZXEzL29ISmNkUVIwaW5ySWFyVk9mdW8z?=
 =?utf-8?B?ZE52UG05ZGZwSjB2NTMzK2o1cElkaGloUG9VN1FzOXJpRXUwV0F6S1IyUnlJ?=
 =?utf-8?B?RXZNTTY1U3JkdW1RUEd5ZGtVNlFrb3c2TTlyY0NqeHpoMmoxSUVqelE2Z2ZO?=
 =?utf-8?B?V25pRGdVaW1nRDlHdVBIcUNZYTR0UXpTZU0yNVlmTVVIbVgxdW04MXNaMVVF?=
 =?utf-8?B?OWRoMmNIYUg3V2kzTEp1TStDVUxqVXVTL0hVMFphVUV6dlpLMUoyd2tVbHQ5?=
 =?utf-8?B?QVozRU9jTXQ2Z3lJMFR5UVBzWlYyY2pScXkyei82eWc0bkNwcXJzWWFnRktO?=
 =?utf-8?B?TS9ITHpOMHZhbGhyTk1RSHZkN2t0QVZ5YUNHQkhyVVIxcC92K3Y4WkNiMno4?=
 =?utf-8?B?ZURZNE9iMXg0S2RqNGxqZEIzenBwUnlEVFFPZ0pVeDlYdExGNWxTeTVCL0hE?=
 =?utf-8?B?YU1UYVdMRlpKa1FRSnpWUVI4K09yUkJ0TjRYSXdMS0EwUE5TdmhnemVFOFVH?=
 =?utf-8?B?bm16cmVXTHdsUVVhZVowbUJFLytidTFQaTdCZTgxekhoa1hyTFc0WUlsbzZJ?=
 =?utf-8?B?WFlDOWxxbXRnWmFuMDBNVHZBeExEMVVQN2JnWkNyNE84Q2FNMHM4QzE3WHJK?=
 =?utf-8?B?OXBQNTFQeFU2bXNlaEoxeG82QXE2a2ptS2p6NGhGRHZLMmtmY1U4S1dLdVVU?=
 =?utf-8?B?bGlkbHB3ak96VFpVdCtUOGl1NG5la0VIbWdTKzF2bWg0QkdCL1p6amdjRkVE?=
 =?utf-8?B?OFFEZkh0eGVZVmxxTlo3VzRDOU83dm5VMm5ITDRBL283aklPZE1rak9SZEdP?=
 =?utf-8?B?RWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e37e6ded-8975-4921-d815-08dacbb670ba
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 11:49:26.4000
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MZ/Z1UnebxYnUDW/T0+LFSYxLyoW6g4CPQ3exlujV1lcURARNa8aRbeJwNf647wkRPfa5I4Z22Kgf7uwdVJmmz5Fj6URabEYyfhD6irZoW0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7647
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-11-21 11:47 AM, lili.li@intel.com wrote:
> From: Lili Li <lili.li@intel.com>
> 
> Commit e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and
> exit routines") introduced HDA codec init routine which depends on SND_HDA.
> Select SND_SOC_HDAC_HDA unconditionally to fix following compile error:
> ERROR: modpost: "snd_hda_codec_device_init" [sound/soc/intel/skylake/snd-soc-skl.ko] undefined!
> 
> Fixes: e4746d94d00c ("ASoC: Intel: Skylake: Introduce HDA codec init and exit routines")
> Reviewed-by: Junxiao Chang <junxiao.chang@intel.com>
> Suggested-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Lili Li <lili.li@intel.com>
> ---
>   sound/soc/intel/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index d2ca710ac3fa..ac799de4f7fd 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -177,7 +177,7 @@ config SND_SOC_INTEL_SKYLAKE_COMMON
>   	select SND_HDA_DSP_LOADER
>   	select SND_SOC_TOPOLOGY
>   	select SND_SOC_INTEL_SST
> -	select SND_SOC_HDAC_HDA if SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC
> +	select SND_SOC_HDAC_HDA
>   	select SND_SOC_ACPI_INTEL_MATCH
>   	select SND_INTEL_DSP_CONFIG
>   	help

Thanks once again your for report and input.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>