Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e84f8d00-616e-14d7-5427-61065c88c015@gmail.com>
Date:   Mon, 21 Nov 2022 13:33:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH] mfd: rohm-bd9576: convert to i2c's .probe_new()
Content-Language: en-US
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Lee Jones <lee@kernel.org>
Cc:     linux-kernel@vger.kernel.org, kernel@pengutronix.de
References: <20221121102454.15664-1-u.kleine-koenig@pengutronix.de>
From:   Matti Vaittinen <mazziesaccount@gmail.com>
In-Reply-To: <20221121102454.15664-1-u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thanks Uwe!

On 11/21/22 12:24, Uwe Kleine-König wrote:
> The probe function doesn't make use of the i2c_device_id * parameter so
> it can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
>   drivers/mfd/rohm-bd9576.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/rohm-bd9576.c b/drivers/mfd/rohm-bd9576.c
> index f37cd4f27aeb..c854ab5bcd80 100644
> --- a/drivers/mfd/rohm-bd9576.c
> +++ b/drivers/mfd/rohm-bd9576.c
> @@ -88,8 +88,7 @@ static struct regmap_irq_chip bd9576_irq_chip = {
>   	.irq_reg_stride = 1,
>   };
>   
> -static int bd957x_i2c_probe(struct i2c_client *i2c,
> -			     const struct i2c_device_id *id)
> +static int bd957x_i2c_probe(struct i2c_client *i2c)
>   {
>   	int ret;
>   	struct regmap *regmap;
> @@ -180,7 +179,7 @@ static struct i2c_driver bd957x_drv = {
>   		.name = "rohm-bd957x",
>   		.of_match_table = bd957x_of_match,
>   	},
> -	.probe = &bd957x_i2c_probe,
> +	.probe_new = &bd957x_i2c_probe,
>   };
>   module_i2c_driver(bd957x_drv);
>   

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~