Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221102152808.2978590-1-kajetan.puchalski@arm.com> <Y3ttlCCezC+SvFDH@e126311.manchester.arm.com>
In-Reply-To: <Y3ttlCCezC+SvFDH@e126311.manchester.arm.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 21 Nov 2022 13:50:34 +0100
Message-ID: <CAJZ5v0hi0Shr4ae7_Fj=eZ6GUsALJnhwxWJic0ASr=FR5C++Ug@mail.gmail.com>
Subject: Re: [RFC PATCH v4 0/2] cpuidle: teo: Introduce util-awareness
To:     Kajetan Puchalski <kajetan.puchalski@arm.com>
Cc:     rafael@kernel.org, daniel.lezcano@linaro.org, lukasz.luba@arm.com,
        Dietmar.Eggemann@arm.com, dsmythies@telus.net,
        yu.chen.surf@gmail.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 21, 2022 at 1:23 PM Kajetan Puchalski
<kajetan.puchalski@arm.com> wrote:
>
> Hi Rafael,
>
> On Wed, Nov 02, 2022 at 03:28:06PM +0000, Kajetan Puchalski wrote:
>
> [...]
>
> > v3 -> v4:
> > - remove the chunk of code skipping metrics updates when the CPU was utilized
> > - include new test results and more benchmarks in the cover letter
>
> [...]
>
> It's been some time so I just wanted to bump this, what do you think
> about this v4? Doug has already tested it, resuls for his machine are
> attached to the v3 thread.

I have some comments, but it's being pushed down by more urgent things, sorry.

First off, I think that the information from your cover letter should
go into the patch changelog (at least the majority of it), as it's
relevant for the motivation part.

Also I think that this optimization is really trading energy for
performance and that should be emphasized.  IOW, it is not about
improving the prediction accuracy (which is what the cover letter and
changelog seem to be claiming), but about reducing the expected CPU
wakeup latency in some cases.

I'll send more comments later today if I have the time or later this
week otherwise.