Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: IDFkde88uIhqIuazuSsBcx8V2er/8gNMGMAO7IxC4GwRUAMHOt2cS8XUqZOgg9A4mmmcobop4Y
 bFExUl/CyJWoQe+XUirCB8H4tH9RKRkId3UmCtYfAqWkHIoK4t/aUYlrmUxmFYmymxqcjuNzCU
 STI1iE4Nvrq7E0l5wcPQPw0EOeq88oVY1E6f9NRXiA3Oe9mBxvyZFifIR6uxY7NCS5njyyaRCZ
 vH+jnLRPy+ixqlLUTJ939CoCbXU8phywHbZt95gNg80SVl32PrxvkZCf12xrGgXDx08UcuWxYr
 mcM=
IronPort-SDR: pIdHGWUiBzpb3AiEnAclfU/VggKXworgWBTdCTCOO6/3R0/jvYu3ngnzkdKdh7Y0qnmWFKzvKV
 ebxy0umwqA9i9ytFN4QtXng5vdOGrF7NKvfFIpdhybt/xLEI1JnO5gzacBK9HvYUSGKyP9J1+2
 zsDYvucLwh3ZHHRGnCAamw3+IGK7TFGA9Oq9CbI7OsF5s85d/qLAX1y+1Z26OSuFmHuQuN2HMd
 4CG9R+g3hU0mxrWor7Kd1UBdKJfCedB6yGnlwTWK1Za1mknqbTvIitkOan+HtblMly2BenVMFu
 MjU=
WDCIronportException: Internal
Message-ID: <83c29cc2-9bf4-265f-4f8a-ab83d8b6271b@opensource.wdc.com>
Date:   Mon, 21 Nov 2022 21:33:10 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH 2/2] scsi: core: Use SCSI_SCAN_INITIAL in
 do_scsi_scan_host()
Content-Language: en-US
To:     John Garry <john.g.garry@oracle.com>, martin.petersen@oracle.com,
        jejb@linux.ibm.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221121121725.1910795-1-john.g.garry@oracle.com>
 <20221121121725.1910795-3-john.g.garry@oracle.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20221121121725.1910795-3-john.g.garry@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/21/22 21:17, John Garry wrote:
> Instead of using hardcoded '0' as the do_scsi_scan_host() ->
> scsi_scan_host_selected() rescan arg, use proper macro SCSI_SCAN_INITIAL.
> 
> Signed-off-by: John Garry <john.g.garry@oracle.com>

Looks good.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/scsi/scsi_scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 6cc974b382c1..920b145f80b7 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -1920,7 +1920,7 @@ static void do_scsi_scan_host(struct Scsi_Host *shost)
>  			msleep(10);
>  	} else {
>  		scsi_scan_host_selected(shost, SCAN_WILD_CARD, SCAN_WILD_CARD,
> -				SCAN_WILD_CARD, 0);
> +				SCAN_WILD_CARD, SCSI_SCAN_INITIAL);
>  	}
>  }
>  

-- 
Damien Le Moal
Western Digital Research