Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <208d4106-97e9-79b7-4077-788cdafa1b16@redhat.com>
Date:   Mon, 21 Nov 2022 13:48:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH -next] mm/hugetlb: stop using 0 as NULL pointer
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, mike.kravetz@oracle.com
Cc:     songmuchun@bytedance.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20221121102037.75307-1-yang.lee@linux.alibaba.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20221121102037.75307-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21.11.22 11:20, Yang Li wrote:
> mm/hugetlb.c:1531:37: warning: Using plain integer as NULL pointer
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3224
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   mm/hugetlb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 222937d512c4..b6c2fc882f21 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1528,7 +1528,7 @@ static void add_hugetlb_folio(struct hstate *h, struct folio *folio,
>   	}
>   
>   	folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
> -	folio_change_private(folio, 0);
> +	folio_change_private(folio, NULL);
>   	/*
>   	 * We have to set HPageVmemmapOptimized again as above
>   	 * folio_change_private(folio, 0) cleared it.

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb