Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Corey Minyard <tcminyard@gmail.com>
Date:   Mon, 21 Nov 2022 07:02:04 -0600
From:   Corey Minyard <minyard@acm.org>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <uwe@kleine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        kernel@pengutronix.de,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 605/606] ipmi: ssif_bmc: Convert to i2c's .probe_new()
Message-ID: <Y3t2zHgeMlTRGE0t@minyard.net>
Reply-To: minyard@acm.org
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
 <20221118224540.619276-606-uwe@kleine-koenig.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221118224540.619276-606-uwe@kleine-koenig.org>
Precedence: bulk

On Fri, Nov 18, 2022 at 11:45:39PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.

Thanks, queued for next release.

-corey

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/char/ipmi/ssif_bmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index 2d8069386398..caee848261e9 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -797,7 +797,7 @@ static int ssif_bmc_cb(struct i2c_client *client, enum i2c_slave_event event, u8
>  	return ret;
>  }
>  
> -static int ssif_bmc_probe(struct i2c_client *client, const struct i2c_device_id *id)
> +static int ssif_bmc_probe(struct i2c_client *client)
>  {
>  	struct ssif_bmc_ctx *ssif_bmc;
>  	int ret;
> @@ -860,7 +860,7 @@ static struct i2c_driver ssif_bmc_driver = {
>  		.name           = DEVICE_NAME,
>  		.of_match_table = ssif_bmc_match,
>  	},
> -	.probe          = ssif_bmc_probe,
> +	.probe_new      = ssif_bmc_probe,
>  	.remove         = ssif_bmc_remove,
>  	.id_table       = ssif_bmc_id,
>  };
> -- 
> 2.38.1
>