Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b0ca9bc-00ba-1055-8bd9-68affd47b1bd@huawei.com>
Date:   Mon, 21 Nov 2022 21:32:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH -next] pinctrl: pinctrl-loongson2: fix Kconfig dependency
To:     <linus.walleij@linaro.or>, <zhanghongchen@loongson.cn>,
        <zhuyinbo@loongson.cn>
CC:     <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <yusongping@huawei.com>
References: <20221121131422.217806-1-renzhijie2@huawei.com>
From:   Ren Zhijie <renzhijie2@huawei.com>
In-Reply-To: <20221121131422.217806-1-renzhijie2@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi all,

     I misspell the email address of linus, please ignore this email. 
Thanks.

Ren

在 2022/11/21 21:14, Ren Zhijie 写道:
> If CONFIG_PINCTRL_LOONGSON2=y and CONFIG_OF is not set,
> gcc complained about undefined reference:
>
> drivers/pinctrl/pinctrl-loongson2.o: In function `pinconf_generic_dt_node_to_map_all':
> pinctrl-loongson2.c:(.text+0x1c4): undefined reference to
> `pinconf_generic_dt_node_to_map'
>
> To fix this error, add depends on OF to
> config PINCTRL_LOONGSON2.
>
> Fixes: f73f88acbc18 ("pinctrl: pinctrl-loongson2: add pinctrl driver support")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
>   drivers/pinctrl/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 35f167f70829..7d5f5458c72e 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -260,7 +260,7 @@ config PINCTRL_FALCON
>   
>   config PINCTRL_LOONGSON2
>   	tristate "Pinctrl driver for the Loongson-2 SoC"
> -	depends on LOONGARCH || COMPILE_TEST
> +	depends on OF && (LOONGARCH || COMPILE_TEST)
>   	select PINMUX
>   	select GENERIC_PINCONF
>   	help