Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221121132608.230645-1-renzhijie2@huawei.com>
In-Reply-To: <20221121132608.230645-1-renzhijie2@huawei.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 21 Nov 2022 14:36:34 +0100
Message-ID: <CACRpkdb9Aw-8wXUFYnBy_LOpuTeB2RpnUB+QwWQiZ9R6BcwbGw@mail.gmail.com>
Subject: Re: [PATCH -next] pinctrl: pinctrl-loongson2: fix Kconfig dependency
To:     Ren Zhijie <renzhijie2@huawei.com>
Cc:     zhanghongchen@loongson.cn, zhuyinbo@loongson.cn,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        yusongping@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 21, 2022 at 2:31 PM Ren Zhijie <renzhijie2@huawei.com> wrote:

> If CONFIG_PINCTRL_LOONGSON2=y and CONFIG_OF is not set,
> gcc complained about undefined reference:
>
> drivers/pinctrl/pinctrl-loongson2.o: In function `pinconf_generic_dt_node_to_map_all':
> pinctrl-loongson2.c:(.text+0x1c4): undefined reference to
> `pinconf_generic_dt_node_to_map'
>
> To fix this error, add depends on OF to
> config PINCTRL_LOONGSON2.
>
> Fixes: f73f88acbc18 ("pinctrl: pinctrl-loongson2: add pinctrl driver support")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>

Patch applied!

Yours,
Linus Walleij