Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4338133rwb; Mon, 21 Nov 2022 06:33:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf6o0SoFY+1YNPNKeIUeOCsWiQEc/E8B5tpoePP4L7pIKq7pLj5489XJKLYS0K6IjDvoRzZb X-Received: by 2002:aa7:d0d4:0:b0:461:b1b9:bed0 with SMTP id u20-20020aa7d0d4000000b00461b1b9bed0mr8308159edo.122.1669041205106; Mon, 21 Nov 2022 06:33:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669041205; cv=none; d=google.com; s=arc-20160816; b=wiIh8Xq8LkBYlqocrVATaEhfWMXebD9GS5sRb6J8kaxm7AXy9OFLTaSG6Q2Cx5fhuP M6O+BLzk0fCXfJLpAXk9Oz9FowDWKzsg+oJjz/XPpVhMYcpwLLomoWrh7QorLC5nn2Pt qnHRbqPoiRfL9GRYVFYWZZ8YcREh9pA3vzmJZNDsKiblSpGWgyzKJTlGkcGNAZhCEM7f ShFGSP80ui/5LprUcJZUfhtMILHD35/MmueTuzEwk4KDnw30XU2P8SLqkALaxTMpTrAR /9XLSVRcu0a8NLtKELs2eZ4pG1IcXq5nB1amaTS0x0QBdwEchg3ZOQelrIxru5aEIixo MzOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=wOeAKZsIWWhR1y5lfaHV9lwAOGty8w3MswjsshInFsk=; b=G7e2r7EFILNANb25he4wAk+QFNmp2CgYb13p5KC3v+xFtbovAif0UPbURn7grzBTEX le7fuMDaMoiw23IRvqEmyMNWtVVsaUEBACK6nL40wQY0DuiwgQFuGT87kJjgixGeTq2/ H3yguQIrgqkdz2vGGSxYttkv5P1iF7vzLd0yutqULV1prLP7yM/3LYIbYnwkfSEtmLnf n6tV84LzRLHZOdMgN6FE6uQM1oDLQ+z5nCLig7KOibvitPXGnPb/wcE8UcpbmK4JWFuY KZMUb/wEipf2X/VYvrmNPD2/dbzjyNNZAw8KACCLktciS5VNbUj5WU946dMvqG9avjF6 gZbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020a1709063e5200b0076f0940cb28si7673968eji.175.2022.11.21.06.32.48; Mon, 21 Nov 2022 06:33:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbiKUOa4 (ORCPT + 92 others); Mon, 21 Nov 2022 09:30:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbiKUOaw (ORCPT ); Mon, 21 Nov 2022 09:30:52 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0686C735; Mon, 21 Nov 2022 06:30:51 -0800 (PST) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NG8tj1trCz15Ml8; Mon, 21 Nov 2022 22:30:21 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 22:30:48 +0800 Subject: Re: [PATCH 1/2] scsi: core: Use SCSI_SCAN_RESCAN in __scsi_add_device() To: John Garry , , CC: , , References: <20221121121725.1910795-1-john.g.garry@oracle.com> <20221121121725.1910795-2-john.g.garry@oracle.com> From: Jason Yan Message-ID: <0973e45f-eb1e-ffaf-4637-9b49f69f8106@huawei.com> Date: Mon, 21 Nov 2022 22:30:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20221121121725.1910795-2-john.g.garry@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/11/21 20:17, John Garry wrote: > Instead of using hardcoded '1' as the __scsi_add_device() -> > scsi_probe_and_add_lun() rescan arg, use proper macro SCSI_SCAN_RESCAN. > > Signed-off-by: John Garry > Reviewed-by: Damien Le Moal > --- > drivers/scsi/scsi_scan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Looks good, Reviewed-by: Jason Yan