Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4401027rwb; Mon, 21 Nov 2022 07:13:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf4bBToE7zgcRF2wuVet++7IORaAJrgw+4ixzrC/SESM+IEmBpgqE5ESYYelU8Y3S2oAtDBT X-Received: by 2002:aa7:9159:0:b0:572:24c7:34da with SMTP id 25-20020aa79159000000b0057224c734damr2427868pfi.73.1669043616896; Mon, 21 Nov 2022 07:13:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669043616; cv=none; d=google.com; s=arc-20160816; b=CkyNoQ9uCtyFxN15SdByXobY2JcVejPvEl/XLKCGSEs+6gCC48yC4IDMmCpvuAaKel uFzsgAMb1/SVv83m4Wgcu6xf3fiHgG0ZzY3EqoH6/0IKIewYSbWKy6KTb5Sq9TBR0nEu NH0dq+QvNAJJhEDx3K25S4nisPwjRZCMOoDez0tMVWQOp2hDVL2NS+Wb3Znyhl17ExYg EE8rpTTdzMBTY1pqS2YHcoSxpzcnk4Fz2Biurx55lwllOZEPDPshwJDHJKj0QLn41ACM sbBWUaZnBXafdLHgEt9FszirJgr8KkZMD2HGKSDKZbC7yW0EwAhm3t8slZu1HMwxXYgO 77XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xCGd6hIfxBt7cfQnfEqxSw7FPCqLC4Ck4a/q2jKRpXs=; b=mSW1HD2Q4PMx27C19nzy/tsFMcAPaMOGZcCBHSVjsOmuyYgk7G6BsC53pE3J7RRPcp gzNmyRanTidIXKpTjU21IWSzO/3NBUrTRSrPzexj5IwOciwlZ7s6VZ/j0fNkyBUTYyF+ zbd93mf16u3LqQm5zF+uXjiRPWYs+vUgyQe06ula6G+A96mGOSD0R3sRwg0G2FOyofif y/aaEAK371Uvcz7/LoebeRKxoMf5FhgacHHT9pvGKl0ZrtWCcMdLQxzGyukL5W9VD5M6 oUKp8CSE+b9eJYDbXtaBygPd6nAeoWX7wHZ5g2WcDVlU8BFGQ8fAwKLiaBS+9CL+cAo9 KLVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=LYt3r1VG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020a63f506000000b004700a4a4a29si11886483pgh.663.2022.11.21.07.13.25; Mon, 21 Nov 2022 07:13:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=LYt3r1VG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230301AbiKUO4j (ORCPT + 91 others); Mon, 21 Nov 2022 09:56:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbiKUO4G (ORCPT ); Mon, 21 Nov 2022 09:56:06 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09A9ECDFD5; Mon, 21 Nov 2022 06:46:27 -0800 (PST) Received: from zn.tnic (p200300ea9733e725329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e725:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 728E61EC071C; Mon, 21 Nov 2022 15:46:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1669041985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=xCGd6hIfxBt7cfQnfEqxSw7FPCqLC4Ck4a/q2jKRpXs=; b=LYt3r1VGYpjFq2eY/1Ig8EB3IqiCf4tNl8mN6dMAnrQpepWGDiaxtPiv4BXj0A6jaCD+Kg K6ao66qLGGIogTA7O/cDGBLmoMgFJB0PO40fxjVY3RQwJbP6X4+tmXifRdjlV9jvmVnhxt RisyrBR0wBFbkpZYBwrRyZoAITaTgGY= Date: Mon, 21 Nov 2022 15:46:25 +0100 From: Borislav Petkov To: Michael Kelley Cc: hpa@zytor.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, luto@kernel.org, peterz@infradead.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, arnd@arndb.de, hch@infradead.org, m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com, brijesh.singh@amd.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, Tianyu.Lan@microsoft.com, kirill.shutemov@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, dan.j.williams@intel.com, jane.chu@oracle.com, seanjc@google.com, tony.luck@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [Patch v3 06/14] init: Call mem_encrypt_init() after Hyper-V hypercall init is done Message-ID: References: <1668624097-14884-1-git-send-email-mikelley@microsoft.com> <1668624097-14884-7-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1668624097-14884-7-git-send-email-mikelley@microsoft.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 16, 2022 at 10:41:29AM -0800, Michael Kelley wrote: > Fix this by moving mem_encrypt_init() after late_time_init() and > related clock initializations. The intervening initializations don't > do any I/O that requires the swiotlb, so moving mem_encrypt_init() > slightly later has no impact. I hope you're right. Our boot ordering is fragile as hell. But mem_encrypt_init() doesn't do a whole lot of important setup - that has happened a lot earlier already - so I'm not too worried. But we'll see what breaks in wider testing. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette