Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 15:22:06 +0100
From:   Johan Hovold <johan@kernel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     agross@kernel.org, andersson@kernel.org,
        konrad.dybcio@somainline.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] arm64: dts: qcom: sc8280xp: add audio support
Message-ID: <Y3uJjo820Ij3aKAr@hovoldconsulting.com>
References: <20221121130403.161817-1-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221121130403.161817-1-srinivas.kandagatla@linaro.org>
Precedence: bulk

On Mon, Nov 21, 2022 at 01:04:00PM +0000, Srinivas Kandagatla wrote:
> This patchset adds audio support for sc8280xp Lenovo x13s.
> Support for Headset Playback/Capture, Speaker Playback and DMIC is
> tested.
> 
> A prebuit ASoC topology file available at
> https://git.linaro.org/people/srinivas.kandagatla/audioreach-topology.git/tree/prebuilt/SC8280XP-LENOVO-X13S-tplg.bin
> 
> 
> Thanks to Johan and Kryz for reviewing v2.
> 
> Changes since v2:
> 	- removed lots of stray lines.
> 	- ordered include files.
> 	- moved all the nodes before pinctrl
> 	- fixed subject line to include x13s.
> 	- rebased to latest qcom dts branch.
> 
> Thanks,
> Srini
> 
> Srinivas Kandagatla (3):
>   arm64: dts: qcom: sc8280xp/sa8540p: add gpr node
>   arm64: dts: qcom: sc8280xp/sa8540p: add SoundWire and LPASS

Only noticed now, but the commit prefix here should just be:

	arm64: dts: qcom: sc8280xp: ...

sa8540p is based on sc8280xp but you don't have to point that out in
every commit (there was one exception where I was also updating the
sa8540p dtsi due to platform differences).

>   arm64: dts: qcom: sc8280xp-x13s: Add soundcard support
> 
>  .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 213 +++++++++++
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi        | 359 ++++++++++++++++++
>  2 files changed, 572 insertions(+)

Johan