Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <049a8f8a-baf8-744d-6250-575fc0dc533e@suse.com>
Date:   Mon, 21 Nov 2022 17:00:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v2 2/2] module: Merge same-name module load requests
Content-Language: en-US
To:     Prarit Bhargava <prarit@redhat.com>,
        Luis Chamberlain <mcgrof@kernel.org>
Cc:     pmladek@suse.com, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, David Hildenbrand <david@redhat.com>
References: <20220919123233.8538-1-petr.pavlu@suse.com>
 <20220919123233.8538-3-petr.pavlu@suse.com>
 <YzdR0gRNQI2BGnJ9@bombadil.infradead.org>
 <aa8d9456-b260-d999-0296-8e6ab876af7a@suse.com>
 <Y07xX2ejlg0oFoEy@bombadil.infradead.org>
 <d0bc50e3-0e42-311b-20ed-7538bb918c5b@suse.com>
 <Y277Jb9i2VeXQoTL@bombadil.infradead.org>
 <e070839f-c224-047b-9411-91143c1d8394@redhat.com>
 <Y3Jg8X7qv2AKPU1J@bombadil.infradead.org>
 <5467e66d-55de-ca8f-c1ae-ffe6efe7290d@redhat.com>
 <Y3Pol5H4kJioAV9W@bombadil.infradead.org>
 <c2e841b7-e2b3-09f9-8187-328131d72c5d@redhat.com>
From:   Petr Pavlu <petr.pavlu@suse.com>
In-Reply-To: <c2e841b7-e2b3-09f9-8187-328131d72c5d@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU03TGN6YzNYRmRaT0IvNldRQ2VaTUFhSXUwRGthZ2JyQlI5TEEwZU1sZS84?=
 =?utf-8?B?Z01zbndRR1Y5UU1OZlR6a2Izc25DR3M4ZHVOVXVBZTQxVldyMU5Kb1E3YTN1?=
 =?utf-8?B?NzJiRmx5QzFVazRXWHlhTmxKTHFuTC85K3NPTFJhZmdJY0dDQjdRMVpEQXlK?=
 =?utf-8?B?OTlKREUrb3pRQW5BUHdCT0dJTFJ2bmVsVEVWZnVONVZtY3R2a0dUMkxWeFNF?=
 =?utf-8?B?dGk5a3Nqc0xCU3FtcG1zQ0M5cmE3QkgrVjloODl4RlRCSU8zQXo2bUp1R3B0?=
 =?utf-8?B?M0lVb0s2WjcybGlaVDBIalNwWllsMHJVYzhxcjI3WmgzNTV6VzlXcVRBT2Z3?=
 =?utf-8?B?ZGZrWHdVOFJBMFFJbk1PTWNuOUlYSVRFcjRueDJ2bWUwVzFjN0VYaTBGMU40?=
 =?utf-8?B?VzI5MEtnbmxNSkZES00rTStiYTUyUWxKalQ4UnZiRUFQZ1diMkN6WUlja294?=
 =?utf-8?B?U3ROSUVvQUNSem1MYXFnNFIxem9wNm5FTWRheGxWMmFtQTFpWDdyaTRaZTZY?=
 =?utf-8?B?Y0EwbHdXV01BSDhvcTVaM00veHBZZENjUHhNQkZVRytzVnpxQnErOFBnMjRO?=
 =?utf-8?B?RVpveVBCT0FuUmxsejBTMm5GTkZtUGhMcG8wOXN2TmxSRWc3VGRTcWdjTWtE?=
 =?utf-8?B?MGswR0FWV3ZkOVR4ZE1kSlkvcEhTNzNHdjZCT1R0UGhhQ1JYYWI5em9wZjA1?=
 =?utf-8?B?VnJWeTRMUWt1U2trUjl4L2h4YXBsQUdOaUtNYmpQbnY4d1hYL3ZHVm93c2Nl?=
 =?utf-8?B?dm1VdnBIRkxFdjU0cTNZRzFIeHRPa0Y0VVY5WnpzUnB4YVp3NVpNNGdyZkxw?=
 =?utf-8?B?MFphZ3dReTFPek5Mbndlc2hvN3MrQURwMUhOVE5NZ0tSN1dOczVJTkEyMlBr?=
 =?utf-8?B?STZ4TkEyTnQxVjNJMHJHUnFxd1dWWkthR3VrK1VtTGVPS2NzUDE2dzVxQjh1?=
 =?utf-8?B?R2M3UjlUR3ZiYnBlV3htS2JzbksyU2NrcmpFM2tSdGVQVVQrQUxKQUFORnJD?=
 =?utf-8?B?Z05mbTdCOVo0OFhYa1hIOWh6S3NMV0YxSndtcUR3K2NUNTBYbExEWnRFczdO?=
 =?utf-8?B?c3RYcUhuMkd1c3YzZ0VtV1VNWElUR0pjaXZ1SWgvOEk4WC9GZXVjVlAreG4z?=
 =?utf-8?B?cVZhLzFtd3I1MnNoKzhFZXo1YnkzWnhHaXpURXlWN1lMbUd3SFFjTDIyL1lR?=
 =?utf-8?B?MzJqb1A4b1g1Zlg0MStubENiREowRWhOU3FieWw3OXJPZjFMZ2FoMlFqU1Fr?=
 =?utf-8?B?MFVWVGFib3pRdEZ6dzZUenZmTmRjb0Zod0pDeHhOVEsyTS82WnRFUjVqbEZo?=
 =?utf-8?B?MnltWTFKZkQzQnQxU3RIYlNycHNnNm8zdFRXTTFvdmNCZDJHMEMwbmNjR2N1?=
 =?utf-8?B?Y2NpckJGZ0RlTUtTZzBRRjV5RDJXOExIVm9iUjdJL3d3ZmtrbC9ybjhxV3Bm?=
 =?utf-8?B?a1Q3bm9GNlRCMDRWV2VKSVJXQy9YWTZPcG1tZWIrRE5nb3dybHlqMnFzelMy?=
 =?utf-8?B?bWdrWTZVL2duaVJaVDlLYlloM1dFRE0vdC9TZjlZQk1wcE9zYjNRYTBXYlh0?=
 =?utf-8?B?dzFpbFlva0k0bVJOellsWE9QQUxMYWhWa0x1WE91cnhUVjJtd3YyVHNiK2hN?=
 =?utf-8?B?WDMrTTM1bFZHTXhkVEoyM21WeGRkMG1kZnJvb29zdTRFOVR5RUNScVd5THlH?=
 =?utf-8?B?WFhwdEdZUFZSZlhPUThGOUpUaS9NdzQwbWp1elBnT2xnTW9EamtlK0NGbXdO?=
 =?utf-8?B?S1RBV2hNRzh4R21jeEZrTjU0NEp5SURmd3p6bmZxbkhKVXYwekNRSEkwK0Vz?=
 =?utf-8?B?bUl4b3hnZXV5V0xXVWgxTituUWhqYUF4bW1lSG0ydU80SVVyMk9EQk1uVkt1?=
 =?utf-8?B?ZVlXQUFGa2xUTjM5bWZObENjcVRJWGJsVktFS3lkMTFSWGEydW5UMzFzVjcy?=
 =?utf-8?B?U0xyYkNGd2phQi9RUkFxelhsRjJ1ejdSZk1ROHJxQW1tVk9ZVXAveERnRWhu?=
 =?utf-8?B?WXlueXRRMnJvTDM3M1lyZ3JvdGk1YW1nWjFzMm8wYjk2TjFWbTBNWUdLYnlr?=
 =?utf-8?B?c3BQNnNvVkU2TVFINkZpblRBMzlyMDQrYytrRFpFRjgvQXVnSm4wL1ZJUnVl?=
 =?utf-8?Q?f8fZfj6dl6xHNZxAm4k5rAb91?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29343155-428f-49dd-8668-08dacbd98fef
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3395.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:00:51.7339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pDWfAIGMwXBoYdmBAJB4ThN6JaTCmOLNk8ou05UCxHW3n5ukqWdInqnsxMiFhJDYQJgBgR8d7Lde+K2nZmmw6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6912
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/16/22 17:03, Prarit Bhargava wrote:
> On 11/15/22 14:29, Luis Chamberlain wrote:
>> On Mon, Nov 14, 2022 at 04:45:05PM +0100, David Hildenbrand wrote:
>>> Note that I don't think the issue I raised is due to 6e6de3dee51a.
>>> I don't have the machine at hand right now. But, again, I doubt this will
>>> fix it.
>>
>> There are *more* modules processed after that commit. That's all. So
>> testing would be appreciated.
>>
> 
> Can anyone tell us if
> 
> https://lore.kernel.org/linux-pm/20221102195957.82871-1-stuart.w.hayes@gmail.com/
> 
> resolves the module loading delay problem?

This patch unfortunately makes no difference on my test system. In my case,
the kernel has already intel_pstate loaded when udev starts inserting a burst
of acpi_cpufreq modules. It then causes the init function acpi_cpufreq_init()
to immediately return once the check cpufreq_get_current_driver() fails. The
code modified by the patch is not reached at all.

Petr