Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220901171252.2148348-1-song@kernel.org> <Y3expGRt4cPoZgHL@alley>
 <CAPhsuW4MaiJBTNnwVhqkmxPxBn8e1cn9PPGm9PkgF6YaO0AWKQ@mail.gmail.com> <09ac46a0-45fe-e280-cabb-682e05c7fddc@redhat.com>
In-Reply-To: <09ac46a0-45fe-e280-cabb-682e05c7fddc@redhat.com>
From:   Song Liu <song@kernel.org>
Date:   Mon, 21 Nov 2022 09:32:11 -0700
Message-ID: <CAPhsuW4OTB+_nq6oRuyY1=sA00ik7X19W2TwoYL7WVDBccZxrw@mail.gmail.com>
Subject: Re: [PATCH v6] livepatch: Clear relocation targets on a module removal
To:     Joe Lawrence <joe.lawrence@redhat.com>
Cc:     live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz,
        x86@kernel.org, linuxppc-dev@lists.ozlabs.org,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Petr Mladek <pmladek@suse.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 21, 2022 at 8:32 AM Joe Lawrence <joe.lawrence@redhat.com> wrote:
>
> On 11/18/22 12:14 PM, Song Liu wrote:
> > Hi Petr,
> >
> > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek <pmladek@suse.com> wrote:
> >>
> >> On Thu 2022-09-01 10:12:52, Song Liu wrote:
> > [...]
> >>>
> >>>  arch/powerpc/kernel/module_32.c |  10 ++++
> >>>  arch/powerpc/kernel/module_64.c |  49 +++++++++++++++
> >>>  arch/s390/kernel/module.c       |   8 +++
> >>>  arch/x86/kernel/module.c        | 102 +++++++++++++++++++++++---------
> >>>  include/linux/moduleloader.h    |   7 +++
> >>>  kernel/livepatch/core.c         |  41 ++++++++++++-
> >>
> >> First, thanks a lot for working on this.
> >>
> >> I can't check or test the powerpc and s390 code easily.
> >>
> >> I am going to comment only x86 and generic code. It looks good
> >> but it needs some changes to improve maintainability.
> >
> > Thanks for these comments and suggestions. I will work on them
> > and send v4.
> >
>
> Hi Song,
>
> I'll help with testing the arches (at least ppc64le and s390x, I can
> only cross-build ppc32).  I can either pick up the patches from the list
> when you post, or if you want to run them through testing first, lmk.

Thanks Joe!

I am on vacation this week. I will pick this up next week.

Song