Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 18:51:44 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v2 net-next 3/3] net: mscc: ocelot: issue a warning if
 stats are incorrectly ordered
Message-ID: <20221121165144.yuwmdqkhtxyv5mia@skbuf>
References: <20221119231406.3167852-1-colin.foster@in-advantage.com>
 <20221119231406.3167852-1-colin.foster@in-advantage.com>
 <20221119231406.3167852-4-colin.foster@in-advantage.com>
 <20221119231406.3167852-4-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221119231406.3167852-4-colin.foster@in-advantage.com>
 <20221119231406.3167852-4-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o6f+g+hQ//ti8MuAs2ue6PCaSf33h8Dhd265mtgJlGqbD+yh2xMPcC2Bpdmo?=
 =?us-ascii?Q?TKc9RW4n7R3evJ6+/hoOYgV4PvVeYtZ0vBGXv46c2GNLFsO0pTX//uYpULQX?=
 =?us-ascii?Q?0B17HiSCfvfXNtYA1A06ax1RuEi/J/Ywol+RmwgP4cDFBLcJqYc5P2QuKP9U?=
 =?us-ascii?Q?F0bu1k2UV21feUyKoeFaKFTBA4Q0QpH4hhp5lIHGRenTaOVs1BhiX4qLmacf?=
 =?us-ascii?Q?KQmQC96TRCRi8jKbwqZI3jDdCaCiKZ3mrRzwdIucUY2QSOg6BYWXak9I/1Pd?=
 =?us-ascii?Q?TGkazlN1qgen8EzpqfN7rZ1gNQNr1Ld5wAirQ3EzJozBqE1wsl7UJOzN7ANR?=
 =?us-ascii?Q?TpAsechsoYTAX0DMywUVWrNWz8PGNP/KYT/HXiWy4236a5FjOdYHd8N+QiWv?=
 =?us-ascii?Q?rZLSlAVdBT9hFzS1fnlrg06OZxyja18xiQIKUoPHMal5u0H0nALR3r2trP+0?=
 =?us-ascii?Q?bnsJnDMzFEzUUluHOlevANmzGQblCjocDJfmaqpzi2g8QA8vQFZPAb+DfsEG?=
 =?us-ascii?Q?xJJ9n6efElwTl5wxeDVCy/38qYaAMyzu69mFI0rmrSRFLaBf9CHVjw+hb1O5?=
 =?us-ascii?Q?bqtd8njMh6UN3ahQhIeHd6B7IVu/QjCAiDD3/7ZmQ0AznwSbxwIt6jepUigr?=
 =?us-ascii?Q?rhii3v7yBQs6Nc4uOtrVljy24R90+oxqmiCTUi7NnU56Xr7EINwlnMH7IM8x?=
 =?us-ascii?Q?eUTdWUGPFtddKp0G2/8L0V11g/4mnnHLdpWlDhOc0n73nPMfc5uzQqvOT+Q9?=
 =?us-ascii?Q?gEt6+1PD055Lvp2vQtJubobA5EGC1OnkBNB38lswCtwkAAo77K6aMsMFSyLw?=
 =?us-ascii?Q?FBci7mj9CqixWvcDX948cSBxf+U9y0DepHO8gPvDQTQuWsBCS72jB1K1BEpp?=
 =?us-ascii?Q?DxBkMhAF12WT+UtoNecTiO2PPeMFy7EGDT9LDiIovjFJdTzbpvlnH0Rq+8fY?=
 =?us-ascii?Q?TvxH5gVqVDdqD6G3nqiZjPKcbmsAY3Qevv1G0UmBay5uwxazq9Krdj5655if?=
 =?us-ascii?Q?JHDHPEY20dklume2XUaRoX2kHK2WBlU3F5oDNnPaefAVBwKwTjUYnwx2Nobz?=
 =?us-ascii?Q?o1KiVHhgROOMN4t7Z2QW6K/sQGPLkGn1WB21NbhrUqXYL5mNHqaRbry8CF/Q?=
 =?us-ascii?Q?DMzQDZNK2rjEIe/orRHPXlrrhbC+bzHq0kZXSbazDffSBASfMqPVeywS1VQn?=
 =?us-ascii?Q?DtgyT9Vpnn4eMSNOBC5mBRvW4J2rU+EeRvXuVpyG4wgR8sjQzFOazgspfVOe?=
 =?us-ascii?Q?nR+2g1yds0EyCelRVbfumEQAo9tuE/steDoYXVaASjzk/I4zu+eqnVC2Xwj1?=
 =?us-ascii?Q?2gNgJV7AWixBmt68Vj25nxfnRalujgXtQJZVCPbigjE4fNZJ9vyP6TuwiakR?=
 =?us-ascii?Q?zphogAGNNGn2bgQ/jHFB2hQDE8ZAua6jGtAZ2Bx8hHnNCg1iKAx0oyRIGeSk?=
 =?us-ascii?Q?khEJKUNEDtQuOW5/9F/HluRBZRG0gnATZ/wJiyqc8hzzmy9gZLwhABK5RMRd?=
 =?us-ascii?Q?pmRzeMxCfwffhMf7J2Nns6ZdUkgC7JmABMivTdZxAoQH6xomr6erLwpCnj4t?=
 =?us-ascii?Q?0eatNhMLaLqxOI702UoiMD2P/2sdSwYH820AwvOFuU68ifRnxUyWq54H66+L?=
 =?us-ascii?Q?QQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 718f0e9b-3512-435d-d671-08dacbe0adb9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:51:47.5815
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wJT1PSlsk09Zx5ILZhgQt8WRBr7ETBQm9ieDPUy+2LSIelmxhE7jSUjvRO25vrThLKeIsODlN44QbhlqsLg58g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7356
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Nov 19, 2022 at 03:14:06PM -0800, Colin Foster wrote:
> Ocelot uses regmap_bulk_read() operations to efficiently read stats
> registers. Currently the implementation relies on the stats layout to be
> ordered to be most efficient.
> 
> Issue a warning if any future implementations happen to break this pattern.
> 
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Co-developed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Assertion holds even with my MAC Merge patch set that's in preparation,
so things are good.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>