Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <99cea0ba-9791-45dc-8c78-04d724a11cf4@oracle.com>
Date:   Mon, 21 Nov 2022 16:34:47 +0000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.0
Subject: Re: [PATCH v2 9/9] KVM: x86: remove exit_int_info warning in
 svm_handle_exit
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, kvm@vger.kernel.org
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org,
        Chenyi Qiang <chenyi.qiang@intel.com>,
        Yang Zhong <yang.zhong@intel.com>, x86@kernel.org,
        Shuah Khan <shuah@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Colton Lewis <coltonlewis@google.com>,
        Borislav Petkov <bp@alien8.de>, Peter Xu <peterx@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Jim Mattson <jmattson@google.com>,
        linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Wei Wang <wei.w.wang@intel.com>,
        David Matlack <dmatlack@google.com>, stable@vger.kernel.org,
        Liam Merwick <liam.merwick@oracle.com>
References: <20221103141351.50662-1-mlevitsk@redhat.com>
 <20221103141351.50662-10-mlevitsk@redhat.com>
 <3d25a0b4-6957-d070-db11-69ec9e0132ba@oracle.com>
 <30b8e07970f2cfbba0ebee82aa3b46a047a0f43b.camel@redhat.com>
From:   Liam Merwick <liam.merwick@oracle.com>
In-Reply-To: <30b8e07970f2cfbba0ebee82aa3b46a047a0f43b.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qi9JbUZFTjFvSHVUcktkRDJhekQwTGdhclhHMEl2eTQwLzhNMlV4VzNpeDIy?=
 =?utf-8?B?Nmk0ZUJrS2tPK3JRWmRINEJTUWlwQTF3NjNGU1RzZTBNaG5kQmlHZEVFM3hJ?=
 =?utf-8?B?dDM0OW14U1ZHYllES0MrOXNVdk0wazhxQWlaR1VLTVJaTkJib1NlM09GVWhv?=
 =?utf-8?B?UDNjS0I1QWc3Q3pGQ2NRNGh2VVlOVmtFMDArc0VvWVg0ZXgzK2RQdnFDMnNv?=
 =?utf-8?B?Y0p1RmF2VnZIdlJjMG9OV0tCN1VVQlNZOXBZSUlOME0wU01IejBKQmxhN054?=
 =?utf-8?B?dnBwQ2ROdUZTVEFGdzM5bTluK2dzM2V1RExEVU0xUktOdnRPRG52UUI5SUdW?=
 =?utf-8?B?MU1sOUxEeWhObVQyUEtoQkk5TmhHTnI1RzBjQ2d0UHcwbFpPQzlQT1dxWURw?=
 =?utf-8?B?WTZudlpxY1hQYjJiTVVGOUhzVlpINzZkVXlZb3k5RUtXd3dHM1FoVjQ5ait0?=
 =?utf-8?B?MmxORDBwS1B5ZGpaNjNTSUtFU1B6aEZ1dy9md3hsSVdrNXZ0U1B5NFFIWjh6?=
 =?utf-8?B?ckt1M0dOQ2tmVnp3aXFOcDB2S3BSaXZyK3BmOFZiZ0E3ek5KV3BIcGZ6U1d1?=
 =?utf-8?B?aW9ZQUNBRlkxOVgza0M2TEpNSFVJUStnTXV5MzJpZEcvekVqUHN4OHVEWTVq?=
 =?utf-8?B?bWh0YjA5NnBBZzEyTDVIM3VycnRjYlhJaFZpdUZDL3cxYmh4QmFVRnY3T0RR?=
 =?utf-8?B?bGlidFBNLzJjWVZDaDV0TmZzOXA5cDZjd0NKVWh1S05sSDZDWkRQdXE2VzJa?=
 =?utf-8?B?YTd4UEZhR2l4bzRIb0xHN0tIS0JtQ3dZcWI4Z3dORjNmdEdxcHJVUHJKUnY4?=
 =?utf-8?B?YkEwdXZBeGQ5aWMxRmdONkpSYUJXUFFyMWtKMEVvR2RjZUtOUlg0c3pRRjc3?=
 =?utf-8?B?N0lHbFdkdmxYb2xzQU9XNmM3TmJ4emNDbTFZUjBTSXBoWEhhbTZHdVdOLy9k?=
 =?utf-8?B?UTNDSndDRk9qV3NjQlZKUWpEViszKzBvUDNuQkZ3S3c3S2VwazRVWVhOSTgz?=
 =?utf-8?B?TGliMVZqWnZONUxjOGJ5ekhpWmNUbzhUYkJhdms5dzdYNHVKVjdkQ0RSUlZZ?=
 =?utf-8?B?cDRsL1BNSXdOM29uYWJsTnFoOHdxSkVxK281VXhqRDNsODZJa3FjKzZieXpp?=
 =?utf-8?B?dUtkcDMzdGlJMlBRNmRZOGJmVDVNWitQSENJQWxTcy9JZ095Z1Q5ditzTVZH?=
 =?utf-8?B?ZEE3VFU1QS9hNWxXZzZrSFRYU0xGaFNnVTZBSTMvQmtMcEdMK2FjRXhOOWRL?=
 =?utf-8?B?b2RVMWRkeXFnUFhqOHZnb0VuYmpxMFV4MDNWRld3YVJlRExUN3ExSDd0cUhp?=
 =?utf-8?B?UGxTTVh3YnViZ0ZoMnZiK1FQTy9hbXVkc1Z0dTBWdmpPR3hGaVpOSmtaK0JE?=
 =?utf-8?B?K0hJV3ZGZjdxYUhMU2YrS2locVNmWVU2Z2owOW9NcUozSk0rOHdkT1BUVXRk?=
 =?utf-8?B?SUxSMENtMXFnODlHSlJnc2hwazN2d1Z3Y1VKUWVRK3MvZmVjMHRSVW4zR2ts?=
 =?utf-8?B?dEpsbE1nNlJOR2lJWHJteVRGUk1UbytQMDh3cHN4cmRaTDNhcnNEYmx4c0Uz?=
 =?utf-8?B?bVR4d1JRN0dYZjNwRDB2bG90K0pIUFpJdzJaUlZxc1BwbmJMZm45NnozNUtN?=
 =?utf-8?B?Z2l3NkxBdGM3UHhzNG0yVUxFdHBmbm43WDlPa0ZGRi9VdVpzeTNkUEhYdDc2?=
 =?utf-8?B?U3ZoSzJoTTdwelVDMjlPMWE1Y3BsOG9IOVBPQlhaRnMwL2VDNkJRNEYvR1dH?=
 =?utf-8?B?cnVuRndFcTN4SHVZcTRqS3Z4djVPZFphdXJMVnpKYXBoTHl2Sks2aGlLdEhR?=
 =?utf-8?B?VHY2eFIzUW1DU2wvbnkzdDY4cm0weC9pZTd2TUVIRzd2SFc3LzRZS0FPWjhL?=
 =?utf-8?B?TWVjdFBXbnB3dkhKdmNnbGErUXlrOXlrNkJGaXhBaUZNRzJrTlB4MSt0Zzda?=
 =?utf-8?B?M0xFTG5IbHpHdnFOWGtrQ0xaek82NWh6WTJsaWZLVGJsZXlYYkRsc2Irb29z?=
 =?utf-8?B?YndzMmI5T21IVUlDTk8vQmxWTXVVUXBjMWpvSWM0T2FTWjhqNVpUeDVNam56?=
 =?utf-8?B?THJzSWl4ckFIS3ovb1RKSDRkeUJyWGE0UlZKUHZYRmo5dUF2UGtrdmprZ2dY?=
 =?utf-8?Q?CRJZouxbgX+Y/3mXAdZHspzsI?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?L1hrOExzM0Y3TDFVNHBxcHJFS21uT3VLNXQyaTZNOVZuQVdaZ0NHYmtwZXdj?=
 =?utf-8?B?T0VCQWk4Q214cUhpTVBSYTRnRkFSN3hlbTJKK01FVCtOVzY5OUpzUXpicGYw?=
 =?utf-8?B?alNsZWgwNEJGdVJBWERXNTNvZDg2bTJ4Tis1ZjJBSFpzWWV0TjU1NEhnRW16?=
 =?utf-8?B?MHFKbUJpUEltQ05QbklQNzJlV1I3NytBd0JnT1JSVUNINS9sc1JueGxRaXpE?=
 =?utf-8?B?dTBZcFZCMGYwYVd5Vm1vYnQ1UGUyaFZrZGFRRVJiV1MxV1hyamR6WWdVN1pk?=
 =?utf-8?B?MmNuOW9tejRVaXZjZkFTMFVIZS9qeUZVdGlhWUhNcTU5SkhUYitLUyt2ak9D?=
 =?utf-8?B?SGpHZ01zOHUxZmJzTFFqQXBUdUNHK0tGVm5RMEJtWnB0NW9FOUZPbTRrdWtq?=
 =?utf-8?B?ZlpuTzFVcjJHR2h4WldMckIrWVQ2dVluR1E1Z2VOdllENUIzOFJUU3F6VkF3?=
 =?utf-8?B?eUZJMHp3a1p0SVFhcDJ3WGJLcXM3NG9yZUtlbDI1akFkQ3AzazJUcFdEZzZp?=
 =?utf-8?B?cUFPeUwwZ3ZKRDQvTnIwUDMwcm9GcnRUVmVVam5lWmpseVArZVlsRlBLM05H?=
 =?utf-8?B?QUhDUDNXTW9PcFZOMUxyVFdrNXpuTjBISThCeEVyNzd5VEJFZHNqTXBNbGRm?=
 =?utf-8?B?cEcxMVlKZnlzUXkyZ04waUFSazBpNEdkaGNMZVpCc0M0NjZmeWJCMm5MUmlK?=
 =?utf-8?B?bVA2d2VTSDJReFhNYU40YmlSS3kyMWc1TnpqZjA2R1lnUy94b1l3UUJVN2ZZ?=
 =?utf-8?B?SkVuRWEzRjNpOTJkVVM2UkRnb29XL2FNMTA4YVZWbEFqSHMyNVFuamVJK0oy?=
 =?utf-8?B?dHAxN0VUTnQyWkUzZ083ODZDN0N6aFBhTkducjd0a0V3UnlHOWRlNmVmRGdD?=
 =?utf-8?B?SFU4K1BQVFFLRndHSFdBMzhKVkI2WTN1WGwrM0FSaS9taG8xMnppSWxYZ1A3?=
 =?utf-8?B?dlV0MzN6azI1QWF2dW4vMTh1dml1N1dadGtURFQ5ckYzMktyRjduUzZsdGFL?=
 =?utf-8?B?WEtjdGc5SFJIL2Q2UWVOalBZTExjS0JnYW1Lb2o5alErTm9NR29WU1RrOEY4?=
 =?utf-8?B?WElKaTB0anFVVUZDWER3Z2FBbzVwcGNKdWNaU1V0RzN3aExiTFgwVVkxa1J2?=
 =?utf-8?B?aVdsTHlqUnFrMEtzeDlhWWZmd1QxeEhHa0VMS0I5VzIwRStOaGdQcWJpdDZB?=
 =?utf-8?B?QmFYc1lNSlcyc2JrdVNjdVZSVGw5c29ZaGh2c04raytBbi82UHcxWitVV1B6?=
 =?utf-8?B?MEZmVFFZS21zTFJqanpvZHF0UGFZaURYTklMajNqdkhYaHJJa3orOE5zWU5j?=
 =?utf-8?B?VWpnamt2Vm5RSkFMYUFzSEpzU21WYWZZUGlDR3VsU3VsbFQxa0d3ZjFxTk5R?=
 =?utf-8?B?WWlNSUxGRE1UZERPd0xORHJYTjZFd0l3eHhkSXplRUQwT1hlZ0tQbXNZVWls?=
 =?utf-8?B?NUFnUVEvUHFmVUpTeHhWNE5mdGM4dkdiSXErelNNNFlNUFZ5anA4aTJKNW1F?=
 =?utf-8?B?OVV4bzV4UkZuZFphZ2ZlOFNOUC9QcFEzaEU2VDFtczU1cHZpd2V0alNqd1kr?=
 =?utf-8?B?Ylh0MWE1Qlc2dGZPYU0xME5XSDFHVmVzTzNCb1ZKNVV2M1drNEsrSk02US93?=
 =?utf-8?B?MndFTC8yODRzQWdXejlNVDhhVHZnM2p6TVdwbnNFdjQ1TGdyOVYwMDVnMEx0?=
 =?utf-8?B?RHVDSFMyeXdJc25JbngwTGNucDFmU2FibEpFbFNLclVReUo0eUhKVkx0OVor?=
 =?utf-8?B?UGdJa25hT1F2bUJIYjk2cldPUDRLQUlmc2pGYm95U3BHTU05OVZMMTk3ekRT?=
 =?utf-8?B?RDU4dEdTL1UxRXJCamh4TzNvQkZWVVJJK2xvMWFJTTJZaGpLWTdibWpUOTZ4?=
 =?utf-8?B?M3JOOUUvcFFRTkhJdVkzRGpRait4TVFneWdUSkF0UCthN1E9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69885b4e-3155-4703-180f-08dacbde51f7
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5030.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:34:54.7016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wcw2dSiK2160UJP1+TvcWqAxIWmZqzsglHIYBmwccnfiK8rF7+L16QGmhX4lF1P7iwoHgDwbG8rnk0w91Eo2jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4836
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-21_14,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 malwarescore=0
 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211210128
X-Proofpoint-ORIG-GUID: ihsB0pvMBsKFXAfiDf_jar8nwUTFMbAD
X-Proofpoint-GUID: ihsB0pvMBsKFXAfiDf_jar8nwUTFMbAD
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/11/2022 09:15, Maxim Levitsky wrote:
> On Sun, 2022-11-06 at 15:53 +0000, Liam Merwick wrote:
>> On 03/11/2022 14:13, Maxim Levitsky wrote:
>>> It is valid to receive external interrupt and have broken IDT entry,
>>> which will lead to #GP with exit_int_into that will contain the index of
>>> the IDT entry (e.g any value).
>>>
>>> Other exceptions can happen as well, like #NP or #SS
>>> (if stack switch fails).
>>>
>>> Thus this warning can be user triggred and has very little value.
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
>>> ---
>>>    arch/x86/kvm/svm/svm.c | 9 ---------
>>>    1 file changed, 9 deletions(-)
>>>
>>> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
>>> index e9cec1b692051c..36f651ce842174 100644
>>> --- a/arch/x86/kvm/svm/svm.c
>>> +++ b/arch/x86/kvm/svm/svm.c
>>> @@ -3428,15 +3428,6 @@ static int svm_handle_exit(struct kvm_vcpu *vcpu, fastpath_t exit_fastpath)
>>>                  return 0;
>>>          }
>>>    
>>> -       if (is_external_interrupt(svm->vmcb->control.exit_int_info) &&
>>> -           exit_code != SVM_EXIT_EXCP_BASE + PF_VECTOR &&
>>> -           exit_code != SVM_EXIT_NPF && exit_code != SVM_EXIT_TASK_SWITCH &&
>>> -           exit_code != SVM_EXIT_INTR && exit_code != SVM_EXIT_NMI)
>>> -               printk(KERN_ERR "%s: unexpected exit_int_info 0x%x "
>>> -                      "exit_code 0x%x\n",
>>> -                      __func__, svm->vmcb->control.exit_int_info,
>>> -                      exit_code);
>>> -
>>>          if (exit_fastpath != EXIT_FASTPATH_NONE)
>>>                  return 1;
>>>    
>>
>> This was the only caller of is_external_interrupt() - should the
>> definition be removed also to avoid a 'defined but not used' warning?
> 
> I hate to say it but I have seen a warning about an unused function,
> but I really didn't expect that to come from this patch.
> I somehow thought that its some leftover in kvm/queue.
> 
> I'll remove the unused function in a next version.
> 

Reviewed-by: Liam Merwick <liam.merwick@oracle.com>