Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221121130418.53267-1-renzhijie2@huawei.com>
In-Reply-To: <20221121130418.53267-1-renzhijie2@huawei.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 21 Nov 2022 12:30:30 -0500
Message-ID: <CADnq5_Mi+dTQOdB0QV+TNSfA+jCbFEfZ1VvRbo2GJ_NB2XKOCg@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: fix unused-function error
To:     Ren Zhijie <renzhijie2@huawei.com>
Cc:     alexander.deucher@amd.com, christian.koenig@amd.com,
        airlied@gmail.com, daniel@ffwll.ch, yusongping@huawei.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        weiyongjun1@huawei.com, amd-gfx@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Mon, Nov 21, 2022 at 8:09 AM Ren Zhijie <renzhijie2@huawei.com> wrote:
>
> If CONFIG_DRM_AMDGPU=3Dy and CONFIG_DRM_AMD_DC is not set,
> gcc complained about unused-function :
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1705:13: error: =E2=80=98am=
dgpu_discovery_set_sriov_display=E2=80=99 defined but not used [-Werror=3Du=
nused-function]
>  static void amdgpu_discovery_set_sriov_display(struct amdgpu_device *ade=
v)
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> To fix this error, use CONFIG_DRM_AMD_DC to wrap
> the definition of amdgpu_discovery_set_sriov_display().
>
> Fixes: 25263da37693 ("drm/amdgpu: rework SR-IOV virtual display handling"=
)
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/=
drm/amd/amdgpu/amdgpu_discovery.c
> index 6b48178455bc..2509341df92d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -1702,11 +1702,13 @@ static int amdgpu_discovery_set_smu_ip_blocks(str=
uct amdgpu_device *adev)
>         return 0;
>  }
>
> +#if defined(CONFIG_DRM_AMD_DC)
>  static void amdgpu_discovery_set_sriov_display(struct amdgpu_device *ade=
v)
>  {
>         amdgpu_device_set_sriov_virtual_display(adev);
>         amdgpu_device_ip_block_add(adev, &amdgpu_vkms_ip_block);
>  }
> +#endif
>
>  static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *=
adev)
>  {
> --
> 2.17.1
>