Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 13:20:20 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jiang <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Ashok Raj <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        "Ahmed S. Darwish" <darwi@linutronix.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [patch 19/33] genirq/msi: Provide msi_desc::msi_data
Message-ID: <Y3uzVJ/7ecL8DBK7@nvidia.com>
References: <20221111133158.196269823@linutronix.de>
 <20221111135206.346985384@linutronix.de>
 <Y3U5xwujkZvI0TEN@nvidia.com>
 <871qpzkj9k.ffs@tglx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871qpzkj9k.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9SxHW9m1aDe5STSjxD06eugs9Tf5VJWkZZAUgZrHXSHuB7dfQlUguN+URS/z?=
 =?us-ascii?Q?o/vVNscCeK4ia5CtdC4gvqUFZr6JaW6p3Z3UDZ+v8egxi9foEwoq+K6kskkI?=
 =?us-ascii?Q?NHUQLUNiczJrXn8nXAeGcX3CFZwwTJ7v31AiVy0fhc3WfuF1W4cl0tNEY0sI?=
 =?us-ascii?Q?hA46mgiWr2MDdw5YL6NtKvFXWer6JxZBXFL80HBsIcp6VL8rq6bkHqBz4d5T?=
 =?us-ascii?Q?dIE6ypOvwC8rJ89fa7H94j7H021xg6JmAbX83/+tx83/Sy0qM5S4flfvzKd7?=
 =?us-ascii?Q?Jo/T0FYZT6vkloVK1lEkDejKJE3mx7PP5jMQlneD3z9vcajEaJWs96gEqxHn?=
 =?us-ascii?Q?+O6Ri6Dj3ouhdd0hbOB5jF/0IXkr6Gby2qK7V9Rx87bK/2EWJe7+8kiaoxF0?=
 =?us-ascii?Q?WkYtBWtd7xJreF99BeCSvmuQPU4mJ2wNrHFLHAioH4mmJvmZs3BKTCEDDm0r?=
 =?us-ascii?Q?KxNLSO3t88/vpud1jawn4ya8jdEEau/gH7uYiLx4U/S3fkSeYFw4maxm1ezt?=
 =?us-ascii?Q?6IOxWP8WV1xbNfbPTRqxvBLdv99KvFo4UolJaQ6pp9s+j5QUSRscUoWy9Ns3?=
 =?us-ascii?Q?hsm/UdQFXNE+OjT3jJrwWyWlNtVvj+Z8QOj9dYE8G1+P5Xpcyd7AKrQsbAiC?=
 =?us-ascii?Q?bqkUgTN3CGIipw401jnBgmKG0cvLWTpam92sZqXPhqHthtBvzvCiEJ60usYT?=
 =?us-ascii?Q?G/Z5U7X8jQ1qF59cmBmizbdYr8EdiLn0bK2eKpBQrvaZrrPx77wXrIoFj2AM?=
 =?us-ascii?Q?EZtgTbKU21dQd2DrqMyUKstFnNIOcZ7darXNBEAYXB3Z/d3K3UGIbTArX9LV?=
 =?us-ascii?Q?n5BpB9gHIJxRkPPko5tgBzUx3z8ZNzwG5KDwdj7XaVCByNFm0OzRVveVImI4?=
 =?us-ascii?Q?3o1kBsu500YykaZxh1dQWZxP5SZCCDI27CME5+udmbJYNQ8mPR00WywyLK3z?=
 =?us-ascii?Q?DeHdc0TcPxfA6ZLSTTtXHRnc8m9bUuf9MMV1KnEFdTPgTvxvxwQGxKREq/TM?=
 =?us-ascii?Q?N7PEFXCXz/n14GT2sGEYC19ewaB31XC4wzfZ+JqTbpCZHVPzL/R9ZWHYCKXC?=
 =?us-ascii?Q?RApgwmreiooHnxK5kBTz9juzdTmV1mRH5mbP6uoWXTWUoirTTMihUpnsPdQV?=
 =?us-ascii?Q?XcCphz7vYajBBkjvtof+5lIkr9m4RDkum7epgkb2fy7hC+LD9fR2OVGSO+wm?=
 =?us-ascii?Q?R7XXP5kVGKZ8/FZSr/g6rbmt4/g6qEImzoQUf7eqJNaemfOxxxfD73TyNS9y?=
 =?us-ascii?Q?TRrE/ZmI+c+aredRflmkP7nNUx+u0rfh1Iwa/YoY4OcSWAHednXJ19Xo74vx?=
 =?us-ascii?Q?SKQkWIPVEL4McOhyuW4wIo0FDIz+3yrdM3Ke0SAWPn2ok4g+scLZNIbZQzq8?=
 =?us-ascii?Q?eno1K/0gWhv4SPJLDy3GHsIbQNLmVcn2oX2N//vXhqe36IbkNsSI0kS1oDNV?=
 =?us-ascii?Q?h+aBFt6vmSnKINelZwTknqmo0azEvAdQwS96kYI8R1HsmE+wiGhGqVy7e7Jf?=
 =?us-ascii?Q?4+Y1SxpNE+8cACPLbw5zymf6Jj9i0EG+yUCaylRfKSxYBCaLRwltATIgcnSV?=
 =?us-ascii?Q?UyUqRYP4jaR7ghhK1PM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf30c9a6-8a13-41f9-fee1-08dacbe4ab89
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 17:20:21.8838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ISAGbCI0Tr8TpbnVp5KoJDE8dJcBjodAh2+W/cxmcnIkBqUQXVS2jVMLGu86j2dB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4219
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 18, 2022 at 11:08:55PM +0100, Thomas Gleixner wrote:

> I looked into this and it gets ugly very fast.
> 
> The above has two parts:
> 
>     iobase    is domain specific and setup by the domain code
> 
>     cookie    is per interrupt allocation. That's where the instance
>               queue or whatever connects to the domain.
> 
> I can abuse the fields for PCI/MSI of course, but see below.

I don't know that we need to store the second one forever in the desc.
I was thinking this information is ephemeral, just used during alloc,
and if the msi domain driver wishes some of it to be stored then it
should do so.

> Sure I could make both cookies plain u64, but I hate these forced type
> casts and the above is simple to handle and understand.

I guess, they aren't what I think of as cookies, so I wouldn't make
them u64 in the first place.

The argument to msi_domain_alloc_irq_at() ideally wants to be a
per-domain-type struct so we can folow it around more cleanly. This is
C so we have to type erase it as a void * through the core code, but
OK.

The second one is typically called "driver private data" in device
driver subsystems that can't use container_of for some reason - just a
chunk of data the driver can associate with a core owned struct.

The usual pattern for driver private data is for the core to provide
some kind of accessor void *get_priv() (think dev_get_drvdata()) or
whatever.

But I do understand your point about keeping the drivers away from
things. Maybe some other pattern is better in this case.

Jason