Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 18:50:22 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v2 net-next 2/3] net: mscc: ocelot: remove unnecessary
 exposure of stats structures
Message-ID: <20221121165022.bdljyrwwhalgzpsa@skbuf>
References: <20221119231406.3167852-1-colin.foster@in-advantage.com>
 <20221119231406.3167852-1-colin.foster@in-advantage.com>
 <20221119231406.3167852-3-colin.foster@in-advantage.com>
 <20221119231406.3167852-3-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221119231406.3167852-3-colin.foster@in-advantage.com>
 <20221119231406.3167852-3-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gK6xuVCPeKdr+oH79exK8+2tZbr9p7vLgRhgDmP1KbzkEJ7VvGiOB/h1G2FJ?=
 =?us-ascii?Q?yqBGCJ9cfYxSp+ncHEP+vdfaVtPrLBUnSwR6kmRf7IVwh5Qos8MmMBuszbHw?=
 =?us-ascii?Q?H0UkudY/oAvVWEGEg8UYBOgEyNSPpMol6qR7u9pY/GORvPEu+XJrRvBDRLd6?=
 =?us-ascii?Q?+gcsK4JbLMPhV6Ahj7tQDEAenxgmOTVbsTt0X1UVAQezk2fsaCxp/Dn78y6u?=
 =?us-ascii?Q?gZlYwh3ZSeNiIbRFiGOF/oJF4ocRT0szH/R7TTGlrdmiBi6CKWybqcro4rG3?=
 =?us-ascii?Q?W+S2XRj6ny0VkbVyk5Sa78YAsPiKxmuRkDQgzFKxwVxVXJoV47bzjeEcOP+F?=
 =?us-ascii?Q?K0goMgFVBaDackFUWPy5m/9sxaPdDPfrSoVZuj/OxlEVhBONwzr8s5NT8WOo?=
 =?us-ascii?Q?vqUaMQaO/Y0myZYmJoJxUn6y1uoa/29QRvrOT4zh0fDExuNd+M/EKXX2p4hy?=
 =?us-ascii?Q?ODiVFqgPEhi3JtZmxe/LGUpNT3NzHbyBEcEkBSQixv2i/G+tk+vUYPcHPlZ5?=
 =?us-ascii?Q?+/qQGUOOnL9568PwnNblrozGqOBcQ6Qa8LZNchWuMorruu5emqHwjQeBmTwd?=
 =?us-ascii?Q?FENAAZfeQ6qpfvxjJNWSdpVsESwmlTiMdPmml/E4BigkIa7suBe/BBzClOBk?=
 =?us-ascii?Q?kfT6pnRpn0yHVeif3o/UJGaE/XRIZc/YBQRU72uloRdcLsSPFKVKVu2KW0IM?=
 =?us-ascii?Q?24BNwydax47Qe5BHOIF+rNmp1sVIxAyGSq2x7M5KXJPOclhktXuQDevIcqw6?=
 =?us-ascii?Q?aVK8Mo8SNcFQeO+TQuPzlgcaLaPttuRozN0AH+sGY/KdZBcfneNhdTJwMGo8?=
 =?us-ascii?Q?IPLln3WfegICl/OeTEhyCd82Ei/XcTt/XaudJpwqjAJw4olJ5yeKaBg4BVvg?=
 =?us-ascii?Q?yt55tWX20fHZIS2HVNZ4tThahT7HDf7LbwhLkGx/llI3n5p1hj8vjUnxPiMf?=
 =?us-ascii?Q?CqSXWSK3v1NYsodE9FIQ9mMPhoxb9bFBc450BY+jc12BdkYGJQnxQxMvF/bd?=
 =?us-ascii?Q?p/bSLFe5vEniVH4vgR7nBUZ15WUa/bREjHuMijiJahTx+jGuZRmelM4g1BO6?=
 =?us-ascii?Q?HiBI3kdHc45gv6C1/n7KEG/8hw0nonDHC6tEwYXe44Bdbm3XwfrhDZdj5/Xk?=
 =?us-ascii?Q?MUhh3grybOxyknR0m+dXhCytAKHE7zxQFPjFA7KrLfAPJYLGccI76EvE01+0?=
 =?us-ascii?Q?dt5Qzjk9m2RKYBquGbuz84aWlUI7+1ZytEBgY6ksc/Fi1xIPIQQHtYuxykyS?=
 =?us-ascii?Q?9SgwpWewU5X+MCJiCUo7zrtGhWd4lTf2GfXBNkliR434e6BJBGzrfZq4ysse?=
 =?us-ascii?Q?wavMZFGHX+LLU7nv4JW5W3kxQzyj0jDXm4e2cu6OwBvkc+6QDpfByUZtYiHb?=
 =?us-ascii?Q?iVfl8jwuc0JdTdtZQw220N15dHpUspLhSTNxB8lXuHp9/0/9YORqtJ6eGItq?=
 =?us-ascii?Q?pn+EQ1tKjm5LgtK9Wnx3OTm3tLcn4AH7bUpKmDxwHTjbGVG+5DqrQaj2kXm7?=
 =?us-ascii?Q?QxCfpJLc35zClK1KG8a78Q0rinZZd0xGY8CzPAkd5bdie0hym6qwdLAVOhV6?=
 =?us-ascii?Q?sUWLRkqCRxyweJGk+2emP+Hobd16HNflzS1LEzUAD6gm9t8JNJtSTIP+fdSe?=
 =?us-ascii?Q?Ng=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 632b01df-11fa-4659-cff5-08dacbe07d07
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 16:50:25.8685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2gjKIfk4Wt+kw15nhBe7+VZ9IPPBcAUzfT8OaYlLNHIck0x1mIDZsyR8Ttt8vxAv0LOuvqJjApyX3yJOLASfeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7356
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Nov 19, 2022 at 03:14:05PM -0800, Colin Foster wrote:
> diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c
> index 5dc132f61d6a..68e9f450c468 100644
> --- a/drivers/net/ethernet/mscc/ocelot_stats.c
> +++ b/drivers/net/ethernet/mscc/ocelot_stats.c
> @@ -460,3 +675,4 @@ void ocelot_stats_deinit(struct ocelot *ocelot)
>  	cancel_delayed_work(&ocelot->stats_work);
>  	destroy_workqueue(ocelot->stats_queue);
>  }
> +

There is a stray blank line at the end of ocelot_stats.c which this
patch adds and which doesn't belong. Either you keep this patch set
and fix it up later (I don't see another reason to resend except for
this), or you resend it. If maintainers don't complain about the new
line while the patch gets applied, I'm okay either way.

Anyway,

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>