Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4634616rwb; Mon, 21 Nov 2022 09:52:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf4k0Z4wtJdW1HXYLigAFAFJrpJRES+saG+z+Q/SgPzk4zccErb3fSRIDpEzkmm5rI6oM0zS X-Received: by 2002:a62:1a8b:0:b0:572:7c58:540 with SMTP id a133-20020a621a8b000000b005727c580540mr1218197pfa.69.1669053177642; Mon, 21 Nov 2022 09:52:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669053177; cv=none; d=google.com; s=arc-20160816; b=BKqQCr2UxMHlu7AAVQOfMUZafqrj0B8uSGvtiiFFyOH65PYpB+kBKO+a7f3TicJpGw mrf+3DPLrQRgc1ITcwdWc7SSk6FeixlPhrFJknGwMqyDCoNo3PuHW1qdgIVXVbSzcHje b8Cn6SZ2Wy2Oj+YZWDX60E7hV7bJZs3B3RI2S8WqmPG0BPpzl+coy4wNrC8eM3xmJ+4j lOOIbySOhHckNgH8LUIAIUY8e+KtP8tvfrxVKjAatXcAqeHpw0DluJFprwrysIRwP1id gMXI9OzalJnf3axB8vldFI9ytgOdYS011wfsAVQhzgvH830CewIT8gSuvzRrmv3Wt3Y2 22tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xtv4h9c3AldnpSSbBkhgTkQdjwq0G0RPbTNhSWZQ0dw=; b=fKenlJqtLoRLYC5uA4l83WQG9ovEfm/DHlMmbEI1pMamvCSnItDhfGC7d5B7XO9ALl 6eb7qgBmtCAbJoZmgy/FqH+ehAkCNIPHyeXyY5ZM5Oi3nwrYkzE5D2LnVwmMiFLfDQal YQDVE/GzwJ6dkjNip2GrP0kaAjJwlgtNdV4liUQhC5Xui9eEuMMSmsEEzR95gMI0TcAR ZFDkqwq5hsONfPQVnmLfsY99myoVL1rEq9masN7aQf1MRr+xmE0NzYche+9sZ57sbPst izNiC6jmMChdVt6CHJy3M6UsOkBBuyctqe9lZ4eCL6VjOrXT9hIkRZW9sVuSjzBW143V CMmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TOb6az3j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w184-20020a6230c1000000b00571d4ca44ddsi10674446pfw.333.2022.11.21.09.52.45; Mon, 21 Nov 2022 09:52:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TOb6az3j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231284AbiKURQS (ORCPT + 91 others); Mon, 21 Nov 2022 12:16:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbiKURPo (ORCPT ); Mon, 21 Nov 2022 12:15:44 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DE2AD92CD for ; Mon, 21 Nov 2022 09:13:47 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id q9so11920183pfg.5 for ; Mon, 21 Nov 2022 09:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xtv4h9c3AldnpSSbBkhgTkQdjwq0G0RPbTNhSWZQ0dw=; b=TOb6az3jRFkBe4X0HzQjP8GYDWWbHNFZ9MxWe2M6asN1VtdRiqKVEQROwPVhV+vczh sNa8toL8xN+dXKiEB2JyK6nWXEZAngN9NOKmaKn1PqZsvQgW4W8jXV5COsjCdfg/KgV/ leOYIAnsVphTKt477QZtn/rV7TmS9Xyazf8h0V0VZy6fboV5bzuzgcfZOtfnEpyUze3W I9nAtf114C+ajWnYbP3b1K3nOeeUcElzvtqJp38XCz8NlQPnH2bulpdxpmcWIu8YRupm wNf60n23jRVSe03sA1pbkic2zuMvh+jfu9FICnmFbCdIYsiG6Y3sy2BeYM9NoPYpJF+t YPoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xtv4h9c3AldnpSSbBkhgTkQdjwq0G0RPbTNhSWZQ0dw=; b=EvAuYm7AX2xM2vLMKaLtUDRl+y0Vbc6XYR6UeJFmYVQNawBn1Hlkj7OghZucyaqbaK DQx0GS00SUV/eFz/AwpJxYGjXfIuj2jYC5hYyeTfBbv1iG9lI5AUF1zmKDFpC2AxBgWC 6rQ8v9K+0KkbWytERcSXCagAXMXwRqAEe3sg+6ltowYTboeq1aktyI+gTlvJxfkZLmfn AdY/tgOWlTA5IGzEPUrkaiLQ2QIMU70GGiE5udk3pfE28gf+ZLYCtDtHSzuI4c/o2127 HEp+zOTM6JXDQTfz6qVFINeUzBSIPW1hnp+L9HPX7fL5OyTvi9I65omScFNeiEpHiBQx BvfQ== X-Gm-Message-State: ANoB5pkgskDvUgYtEywqtSmsXn9WDF4OIqnMuCDGeclX1MVvctrUdvWY /Aj8CjrBJFeRABRF/OZ8L3q+jw== X-Received: by 2002:a63:da4d:0:b0:46b:3c3d:f618 with SMTP id l13-20020a63da4d000000b0046b3c3df618mr4676440pgj.423.1669050827057; Mon, 21 Nov 2022 09:13:47 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:8b90:bf06:8462:1d8b]) by smtp.gmail.com with ESMTPSA id e5-20020a170902b78500b001891177cb48sm5406001pls.140.2022.11.21.09.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 09:13:46 -0800 (PST) Date: Mon, 21 Nov 2022 10:13:44 -0700 From: Mathieu Poirier To: ye.xingchen@zte.com.cn Cc: andersson@kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH linux-next] remoteproc: core: Use device_match_of_node() Message-ID: <20221121171344.GA457869@p14s> References: <202211171541061366938@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202211171541061366938@zte.com.cn> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 17, 2022 at 03:41:06PM +0800, ye.xingchen@zte.com.cn wrote: > From: ye xingchen > > Replace the open-code with device_match_of_node(). > > Signed-off-by: ye xingchen > --- > drivers/remoteproc/remoteproc_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied. Thanks, Mathieu > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index cb1d414a2389..11c165ddf1fc 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -2112,7 +2112,7 @@ struct rproc *rproc_get_by_phandle(phandle phandle) > > rcu_read_lock(); > list_for_each_entry_rcu(r, &rproc_list, node) { > - if (r->dev.parent && r->dev.parent->of_node == np) { > + if (r->dev.parent && device_match_of_node(r->dev.parent, np)) { > /* prevent underlying implementation from being removed */ > if (!try_module_get(r->dev.parent->driver->owner)) { > dev_err(&r->dev, "can't get owner\n"); > -- > 2.25.1