Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 18:51:05 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Roger Quadros <rogerq@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove
 redundant ALE_CLEAR
Message-ID: <Y3u6iSiJOgcy38cL@boxer>
References: <20221121142300.9320-1-rogerq@kernel.org>
 <20221121142300.9320-3-rogerq@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221121142300.9320-3-rogerq@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gksZj5JOFEFa+sOlxVJTvxfjIBD8FsmpS/NUaQEIQUTyI4Lm6D7SXN/xcjia?=
 =?us-ascii?Q?fI8HCbuobVxAUsfSFB/ofFKH1Rxz3KTz+60s25Oz8u9CU7HuP7q1n2mgfjtI?=
 =?us-ascii?Q?SxbWDCx0lphQ1OzWg4IA6/olU4Fov7kkCdXtHoYyYuby3u/gFZrir7E4v8rr?=
 =?us-ascii?Q?0ms2ev3aoxPl1xwXa7p7BntFRmyRA2JFv/VyTnm6hmE99Fv86npUEniCJ15R?=
 =?us-ascii?Q?Ebmv37TdNYyGYgYOohwXl/4MMWmZJy5BepXIck/QGRq68PeYGp5i2ACK3XdU?=
 =?us-ascii?Q?TbAzOkTZxkU6mFbucxpN5gVHEqwlcpzTBxUNtizZMtzV1AHdcQFaFELig9eb?=
 =?us-ascii?Q?QyJ5XRBfUDPwHi7QgY2IVS1O6acm5+8KUrlg4lqRtaaMYfuDKTqPauHSaeWJ?=
 =?us-ascii?Q?LLJvG19JXEfTwYWMODU5W9K+Cv9oJMDB7RWKZcUtVRcFNKy33YPvVRcFqrrl?=
 =?us-ascii?Q?Gyy47AVX847wb7ykj2RZpymDMH2EZKKRWIaiUgrr7JPo16cucElXTFP/FWwo?=
 =?us-ascii?Q?ALNVAU1jtZIqymJ8pRYfZB1EipsdquTy8+Z1+8bfz+GDoYvhOKKVhpDhEmkl?=
 =?us-ascii?Q?eonNFpslcel0l/dbAbcGhBYy2uxZSrYopSOZrqhM5IhcR/FX4O+rEgVEmcF3?=
 =?us-ascii?Q?1mXSQHiZyqlWZmwaJrXpd6L+Jz4q6DZESMQDcF9vXwAN5mLke7IkY22TjlOs?=
 =?us-ascii?Q?ftAyEzCuBqvex/yoG3LtPj7+x4nnS9w7ChuohOjyay7TNKcucQljFvxLqTxr?=
 =?us-ascii?Q?4iQrRc8YEJ+h3/nuQEevyWxtzEvBxTNzeOdpIC8oO+2oXHUO8/Yq7IH9xHI1?=
 =?us-ascii?Q?WujGDn5focW0bk9c8MHavI8ncrOHL9avQE/6/56LqtWE3QflGLysyQDriyxA?=
 =?us-ascii?Q?IqN/f/07ltSBrePRhKCGYAzgI6FMtwl0wEY2waVHxFyrY/cfg+SaO0DYG7lS?=
 =?us-ascii?Q?x0RQshoCu1o5Zp8AtzcUUJXr3kQ37skLpALb8GMHcHzdaFZ1y3zlTk1zX2g8?=
 =?us-ascii?Q?APfQA8jC8cpvOwpP8gUtoIlIZXck0E3Jb/ZXmRJkZ7bDfvE0ZCimVtRR82KV?=
 =?us-ascii?Q?700WnoFM/sEWgErfz5mmWGcrPrsaJ5BFfuBFLie5xGgLEoDpmQBbcu2ntq4e?=
 =?us-ascii?Q?6O0W4SFbF66vUJbEHVkZXIsyCZemTPjcHUaMGiRz6Y44i0Kf1etV036kNDVh?=
 =?us-ascii?Q?LNUxmBO1taYdrNr6aqMpXmrdKrK3f1EB2YpLR+GkljHeyQzTvtcGVmTEa4sd?=
 =?us-ascii?Q?pIGNEoiqNBhUNFnHVijs6z9CT6SCC3zU8DjT50d58Gxz+y9IMSu+OETBhfq0?=
 =?us-ascii?Q?IOSDk17HX8dMiME0rCEqda+VvNb74TS8G5ujxev81p9N4qf2BTjGI2gm4sXb?=
 =?us-ascii?Q?ojooA++k3YErzKN/NXptUralc176S7/cyG4XHFoUZ9/fL3umSPvJhIEJlXIX?=
 =?us-ascii?Q?jJH5SKLjgurBwUNyUjfbryd8DNMgQXsJLBb/0hPcLZQbxotolVT2fKieUihI?=
 =?us-ascii?Q?H3YVYkBgMP9edIxByjk+/6DwaSZ4k5kgsiIUwXGUgdc91W+mknjYYL283KT7?=
 =?us-ascii?Q?kKBskXW9lkh12WRZEamejJdvaLTJJIX0WI+ow6ev1+p0ejFo0MKYjVIEBrN9?=
 =?us-ascii?Q?Yg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bde7cd3-dec9-41da-283c-08dacbe8f9fb
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 17:51:11.4277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cFD5KpELufa/B5xaAPJ8D23Jj1ac+iqdkpcuVCYBN3Vx0fLa+7JdLbU7MYVR0Z1mTotBt0AAbMNGNJ3UFh1xEHnJbkpK6tGdTG0czNcNmGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7120
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote:
> ALE_CLEAR command is issued in cpsw_ale_start() so no need
> to issue it before the call to cpsw_ale_start().
> 
> Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support")

Not a fix to me, can you send it to -next tree? As you said, it's an
optimization.

> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index 505c9edf98ff..2acde5b14516 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -404,7 +404,6 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
>  	/* disable priority elevation */
>  	writel(0, common->cpsw_base + AM65_CPSW_REG_PTYPE);
>  
> -	cpsw_ale_control_set(common->ale, 0, ALE_CLEAR, 1);
>  	cpsw_ale_start(common->ale);
>  
>  	/* limit to one RX flow only */
> -- 
> 2.17.1
>