Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 18:56:54 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Marge Yang <Marge.Yang@tw.synaptics.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        Hans de Goede <hdegoede@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: i2c: let RMI devices decide what constitutes wakeup
 event
In-Reply-To: <Y3e6tcmg1YAKsj9c@google.com>
Message-ID: <nycvar.YFH.7.76.2211211856450.6045@cbobk.fhfr.pm>
References: <Y3e6tcmg1YAKsj9c@google.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 18 Nov 2022, Dmitry Torokhov wrote:

> HID-RMI is special in the sense that it does not carry HID events
> directly, but rather uses HID protocol as a wrapper/transport for RMI
> protocol.  Therefore we should not assume that all data coming from the
> device via interrupt is associated with user activity and report wakeup
> event indiscriminately, but rather let HID-RMI do that when appropriate.
> 
> HID-RMI devices tag responses to the commands issued by the host as
> RMI_READ_DATA_REPORT_ID whereas motion and other input events from the
> device are tagged as RMI_ATTN_REPORT_ID. Change hid-rmi to report wakeup
> events when receiving the latter packets. This allows ChromeOS to
> accurately identify wakeup source and make correct decision on the mode
> of the resume the system should take ("dark" where the display stays off
> vs normal one).
> 
> Fixes: d951ae1ce803 ("HID: i2c-hid: Report wakeup events")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Applied, thanks Dmitry.

-- 
Jiri Kosina
SUSE Labs