Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4822408rwb; Mon, 21 Nov 2022 12:23:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf7vA+U7+t4cwWkYYRoWNPsuSQHf8enoXsBTY0rEOE69USff4NeKhfhyqbg3GHw4233UZeUt X-Received: by 2002:aa7:86c7:0:b0:562:45f0:df50 with SMTP id h7-20020aa786c7000000b0056245f0df50mr965011pfo.16.1669062211957; Mon, 21 Nov 2022 12:23:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669062211; cv=none; d=google.com; s=arc-20160816; b=MfT24VfCy0Tc9WXf7PINqT6SaxR7+pkTuyYgqdcnAZjN20PFgQXds0ZBK5uTe99JcW P6Nkl7Fe4YBW0p2a3BJzxGTnRuIpuz+/FjCNQSEhy4qeavgNUSRyGFuTd54EibAA3gA6 jHYxk/WHQsYswz8PMghmJ86jwBkY7VSIINo//Y328vDlgru30RrTv0DgMOMeXiLD4RjU Ni6xYdriRp4SXCCwLG8DXmoTpy5Lry8sGLTFjbjD8yO29iE+7RA2Qujh0QCQZ09ZG7e9 2ASjvS7Y0xkS/MnKlljll8jnUWHuhUnfD9zcSKmY6DoQAv47m9v4qzuBXUFeJwSK32bW HlbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=pj+rWb3ytQFP4QveAZn4tdgw+NbRHtWTFzBRppaEAis=; b=MAugrGMcZemHZQ4QRFA4WgllqaSajIQpbCLP5p/YD7XZVlQlJ2ZHtqmQgT020JQzpD 9X9VUOycgfWPMFxDeaXIQjW2S2+rKPlILlre6eNumYiYyDZj8MMgcgDGXTSh3vbr78zF vC5wSgrP9ol/Nzzpva7KkDczTNmTAWFfUw4Soe85LZNzF8lYSsrUcYbpuunvsP4642l1 SXwGs6l+fpvkxHH+ubKnTO8jM24L2568HW5FkI6REpUsvAWfIM+rRdoDyCquU2BhUIhH ot/97IE8oS05DIYAhgLI6yAOUsnoGqeSSp16bJ4HL3B7VxhqqM0Auzgy/BBBP3ZtOIJb XwjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JNoIE5h9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p36-20020a635b24000000b00476d73d3a98si10698024pgb.510.2022.11.21.12.23.20; Mon, 21 Nov 2022 12:23:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JNoIE5h9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231804AbiKUUFK (ORCPT + 91 others); Mon, 21 Nov 2022 15:05:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKUUFH (ORCPT ); Mon, 21 Nov 2022 15:05:07 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9778E26AE1; Mon, 21 Nov 2022 12:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669061106; x=1700597106; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=v4/dXwdobEr3YAeZGZ6dCnpN201n0xj1YOPpe7MPrB0=; b=JNoIE5h9LHvXdh5T/SzkCCCP7pGM1JbQPVSb0z46BMEZ/N6nEXLNH3kp hDOQLjtCgEcB9R8v70oQvOqC/E5XvgYX3aLvKsPtP2yIWu1L4sOKTkdDk UEfeJ2FrKnJm8O1af2DerNEHslngmW23JxFTXBQ81dbcWPDp1c0BmoKoL jiTYqHhdcWvRKBqM65LkUIomksjw9hGE1K6hIaBSSdLDs0ZrmLtNiKM2O SGdzdR9ByKfLtbNducy4hecYCVZ+n/AizhUejBhfYr6z+hjA5xdOR17xb IUHb/p+Rml+hkA757t7TS0JoNrvnzwTbaA3QSbcff0ziTfVQQiaMpjxA8 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="377911056" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="377911056" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 12:05:06 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="709936413" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="709936413" Received: from ticela-or-327.amr.corp.intel.com (HELO [10.209.6.63]) ([10.209.6.63]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 12:05:02 -0800 Message-ID: <344c8b55-b5c3-85c4-72b3-4120e425201e@intel.com> Date: Mon, 21 Nov 2022 12:05:00 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 5/6] x86/hyperv: Support hypercalls for TDX guests Content-Language: en-US To: Dexuan Cui , ak@linux.intel.com, arnd@arndb.de, bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com, jane.chu@oracle.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org, x86@kernel.org Cc: linux-kernel@vger.kernel.org References: <20221121195151.21812-1-decui@microsoft.com> <20221121195151.21812-6-decui@microsoft.com> From: Dave Hansen In-Reply-To: <20221121195151.21812-6-decui@microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > #ifdef CONFIG_X86_64 > +#if CONFIG_INTEL_TDX_GUEST > + if (hv_isolation_type_tdx()) { > #ifdef CONFIG_X86_64 > +#if CONFIG_INTEL_TDX_GUEST > + if (hv_isolation_type_tdx()) > #ifdef CONFIG_X86_64 > +#if CONFIG_INTEL_TDX_GUEST > + if (hv_isolation_type_tdx()) > + return __tdx_ms_hv_hypercall(control, input2, input1); See any common patterns there? The "no #ifdef's in C files" rule would be good to apply here. Please do one #ifdef in a header.