Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <414c8bf5-f2ce-e042-05ff-0e463ab2613f@gentoo.org>
Date:   Mon, 21 Nov 2022 21:25:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
From:   zzam@gentoo.org
Subject: Re: [PATCH] [media] si2165: Remove redundant NULL check before
 release_firmware() call
Content-Language: en-GB
To:     cgel.zte@gmail.com
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220606014433.290667-1-chi.minghao@zte.com.cn>
In-Reply-To: <20220606014433.290667-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Am 06.06.22 um 03:44 schrieb cgel.zte@gmail.com:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> release_firmware() checks for NULL pointers internally so checking
> before calling it is redundant.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>   drivers/media/dvb-frontends/si2165.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/media/dvb-frontends/si2165.c
> index ebee230afb7b..3d167ca670a4 100644
> --- a/drivers/media/dvb-frontends/si2165.c
> +++ b/drivers/media/dvb-frontends/si2165.c
> @@ -513,10 +513,8 @@ static int si2165_upload_firmware(struct si2165_state *state)
>   	ret = 0;
>   	state->firmware_loaded = true;
>   error:
> -	if (fw) {
> -		release_firmware(fw);
> -		fw = NULL;
> -	}
> +	release_firmware(fw);
> +	fw = NULL;
>   
>   	return ret;
>   }

Acked-by: Matthias Schwarzott <zzam@gentoo.org>