Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4845344rwb; Mon, 21 Nov 2022 12:43:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf62o1CFj/YSR/LFkiK6gnurMrcW5neesCJUyZeQEtt7Ebe+Yo03WLfIzaLwFuYpNuyfBLkE X-Received: by 2002:a17:907:7611:b0:7ae:bc3b:d9c6 with SMTP id jx17-20020a170907761100b007aebc3bd9c6mr16104095ejc.770.1669063423440; Mon, 21 Nov 2022 12:43:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669063423; cv=none; d=google.com; s=arc-20160816; b=HYnZ1re32V/qv/IGUbkq9G1KmdihOposhZrsuTjHJYRUw3VbeHBLSjK4OaA8W15ARO sB33ZfSoGnA80mHvVJNUjA5iAoFdugOdyRTERx9CnWnK2BzUXec9asJySwS52saSxZsR b/CzlhLceCVmsm2TbEnow7Vwo4mkhyWxcX6WOXuYF8gnC5JufvahBvdLxWKfAwmxEwnc L1wSW/n0LCb7Tq26iUkNRdPMDAXidHIcMEnoE/wdW7RT7z2w4PRFZOPrxaIglZU1iIYn Sq9N2gCBHkHZDz5h2eLE5voKj5AwphxpD3x7UcV9z23nprb7rKX9r4frXyghBvPN4lX6 53pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=wQXpZ2y0tzapmh2ePEeQ8OQTZhwALZDxI6jvcwJF9GE=; b=dNgUHNCKJ+QFHgPeLB6MV1fGayYngrdPoC/OiILzs8hPxHprrlC1+c1gZpMoo0mHBa TUblrIYFUxQ+eJPp35UwPBwGADL94QmgPu1A2p2ljfxWIXdAC+lDOXv1o8yKJiZMSksd S1vIq/kHEmY/y0W8jA0RRYrQhTwaup02Y6/W0OyxVxE2KCnQbSeedjhme14Yiqha039T wU77tACepbNa0RqWXE1xrEW316J0cZMrxVm5RiR+2kCwRQR2m1YnFM7i07Mwj8BaAEzc x3kApQK+xGagfOiYkiRCzzBG1WjZYcBXpitLhzDtnUVmPCyaUKRS4C1XYptz4LXxwBL/ Gdig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uz5O4s0Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i11-20020a0564020f0b00b004615a57e292si9890935eda.426.2022.11.21.12.43.20; Mon, 21 Nov 2022 12:43:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uz5O4s0Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbiKUUNF (ORCPT + 92 others); Mon, 21 Nov 2022 15:13:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbiKUUND (ORCPT ); Mon, 21 Nov 2022 15:13:03 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D9C1D310; Mon, 21 Nov 2022 12:13:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 89651B8101C; Mon, 21 Nov 2022 20:13:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2AA2C433C1; Mon, 21 Nov 2022 20:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669061579; bh=G1aWu2eNylL7AnCEGaprf9Ch5gNCAnR+u01eObsqiyo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uz5O4s0YU0hU4FkIy8AzFKEKK4nLKm9rYuKXLC35La/ngQObCDX9Gula9d+m5R4sl 8MFPYSoYPa1ziBJmFnb+kM/A8cQPE3Ce9lJPOOdWxwfdJbJYEf1Bzrnx6xy7tYEAOG 3Xpiswts8AfuRZX45DysKhngAlfnlItS4lMQ/hp2UpMWkjupZxSvmdboWLMX0ZV43j VrsArtVQx4b3k/2VCkiSQ93b3wqKss51K1A32IWRKCiT9Jg/BPsZ9AbNY+VJU5ldA+ c0iUl+PrJ3c2VBvk/oP2ww6R9mEgoTi5Bmzex96CkevbOD2jmqgOyN+SuLsnY/ZH4Y A9pD/qjnOAGsw== Date: Mon, 21 Nov 2022 12:12:58 -0800 From: Jakub Kicinski To: Maxim Korotkov Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Guangbin Huang , Andrew Lunn , Tom Rix , Marco Bonelli , Edward Cree , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] ethtool: avoiding integer overflow in ethtool_phys_id() Message-ID: <20221121121258.4f359da8@kernel.org> In-Reply-To: <20221121075618.15877-1-korotkov.maxim.s@gmail.com> References: <20221121075618.15877-1-korotkov.maxim.s@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Nov 2022 10:56:18 +0300 Maxim Korotkov wrote: > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 2adc6edcaec0 ("ethtool: fix error handling in ethtool_phys_id") I'm leaning towards dropping the fixes tag, and applying to -next. Drivers returning high enough rc to cause an overflow seems theoretical, and is pretty harmless. Please LMK if I'm missing something.