Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 23:02:07 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     Alexander Lobakin <alobakin@pm.me>, linux-kbuild@vger.kernel.org,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Jens Axboe <axboe@kernel.dk>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Tony Luck <tony.luck@intel.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Derek Chickles <dchickles@marvell.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Daniel Scally <djrscally@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Brown <broonie@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        NXP Linux Team <linux-imx@nxp.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/18] dsa: ocelot: fix mixed module-builtin object
Message-ID: <20221121210149.fbv3lgi4vxnqw336@skbuf>
References: <20221119225650.1044591-1-alobakin@pm.me>
 <20221119225650.1044591-15-alobakin@pm.me>
 <20221121175504.qwuoyditr4xl6oew@skbuf>
 <Y3u/qwvLED4nE/jR@colin-ia-desktop>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y3u/qwvLED4nE/jR@colin-ia-desktop>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iqatE8oX5Xx7WEAG/XEsz+zwm+euxX9Z8uotFwauEHS6kJ1jSAyqRPwwh6V6?=
 =?us-ascii?Q?BntlCSPd4i+prgANNiM1Lr2MG7ZNWzQfPQtiRH78nNhPkOsWZrh1QRi/vxsd?=
 =?us-ascii?Q?KJiiXz0ibcT4JtaQ2ikDSVs7ufSK4+ZiZpqJb7NBUYm834ylmtfWOrLIOeDk?=
 =?us-ascii?Q?pkjG78chJsVyZjvz0UhlsGn9f+iwCvYABx9L6wI342IN+qmCJDIW1sYmg9Bv?=
 =?us-ascii?Q?uxmR6g/Espqh07fWMrf4/hkpECzXwdO4JUZaBueQDQqVhn25En0vzPtUUnGN?=
 =?us-ascii?Q?4W/ERdl+ZUBUUyw39tYeFmvLJBjK61MuXwsV19MjTFpr/+i96m6XLtTic3vw?=
 =?us-ascii?Q?AOXPB70cCMgVJHAHhL7x4y3HBCS/HtMOCmam1ctJpY1kaEkZEEQka/M77ph5?=
 =?us-ascii?Q?rbSKu0kP+CoUOzgmOhPJLgHwg3toI+hNR3kQRazFK5LrqXZsbCXy2Q4tGVTX?=
 =?us-ascii?Q?gJv/NFoKLDlUMFqeV5eFOubqUm6v5Ie9Qz+SiMlskObyzxPtD1pflGF+zN9z?=
 =?us-ascii?Q?FDxsSjfioKWXgkBfAgz25S0wZsRKCzEXrUaNE/JhRP3UJtb10vcBqMMK1FE+?=
 =?us-ascii?Q?pd2Vn8pF2vgms3vb5jbMyOb5a4xwEXhYii4TyJQcC3BXe2jU+BRjaGJ/8P4Q?=
 =?us-ascii?Q?auIR3F6DNBL2gDTNFOr1ImZBWrd3SGfJThLUuoDkmCJB4SWPbVbgLde2YQDX?=
 =?us-ascii?Q?8fUI06Fk4fxDzT0VWxOviyEtPaXIDnOeLSNkJSyQSFG0YcXVUCfGfkOqbMnO?=
 =?us-ascii?Q?Rw4x47SmWH5T2fkxNBFCjKqNFahQNgwvlnjUMf4fpOsWUB4edppfpk300bZv?=
 =?us-ascii?Q?zRd7dMabsd/L2AKr6ybstwGEEX+BftstilQw+6nhrRktk4fA8Ca0gTlTs2fM?=
 =?us-ascii?Q?eTGrxTrFvCphEK93fXc8PxGQ7C5y7yjOePxyzLIspe6enw+9QFSHYjcDg7oD?=
 =?us-ascii?Q?W3b/9cZTmtxx3/+9l9lfYVSwPBfuX/xtQQYFR/1FmmlyEbrjhum6aZfsXJh8?=
 =?us-ascii?Q?5KAcM2k9WKhBy5sY3WZa3syrD6i1Ypvwq4Ksdoi2fW4NEdyqeIn6zGWLZj5Q?=
 =?us-ascii?Q?6ZTgfinFrB8mn+Cm8GDtiXAzX9GgjYrxE0uO85BOiQfJwyC4G3B0AlxVLtXD?=
 =?us-ascii?Q?MxwgGBA/W8RPcSHXsR9UWvjwyqfA3U0soj+UjHfqigd9yQytx3IV+Xy4MX9g?=
 =?us-ascii?Q?vY1TMogCcaO/syBzO40XXPz4vtjj/NjzLnFLEfrE0Dq6PKKFWyRvXgoWraKH?=
 =?us-ascii?Q?9Y5HnwiQRN361Vq7f0PWRkdj7yR+ynaUyMNtp/7/pROXBEFsmp/QozUHI4Bo?=
 =?us-ascii?Q?MIocbYjqQZh9Cq1cykYeBAGVelIwh2o01cLksqYVbR7WKd28u113gctpCqMt?=
 =?us-ascii?Q?yrU5ipWUxrgfVC6CK0ZcFr4jUPwaYuNw1L/rxei5k1b8Km4BY1EdtL1AGMVz?=
 =?us-ascii?Q?CJabyZjelkceoOpeH6NXoaU1KJJc12CiC58ofMhIxbO4aXFoqYGUI8q3i12L?=
 =?us-ascii?Q?QnDCwjtT90RcVv+bhRMkIjA7jR63mxk1fE2Z/iHNtUeApwlWK8ngwCnm7hfU?=
 =?us-ascii?Q?KW3wYHl2lulcJLD/skxxCUpqoHzsoAjFrlvWAR6H2mZUP90H0z7EKSHs0/+Q?=
 =?us-ascii?Q?uQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61c35ff0-07ff-46bb-8ceb-08dacc03a879
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 21:02:11.1884
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mss6eTbgsES3MdtEReA/pqjhQSrIX2Bk3yIpzXB1pdSLXmAHUHWZ8ulQqc1aknjo9W/eBcT7y+TJQqijJSGSww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8827
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 21, 2022 at 10:12:59AM -0800, Colin Foster wrote:
> Good catch on this patch. "mscc_ocelot_dsa_lib" makes sense. The only
> other option that might be considered would be along the lines of
> "felix_lib". While I know "Felix" is the chip, in the dsa directory it
> seems to represent the DSA lib in general.

"mscc_felix_lib" could work too. At least it's more consistent with
felix.c and the function names.