Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 22:35:18 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Andreas Bergmeier <abergmeier@gmx.net>
cc:     lains@riseup.net, benjamin.tissoires@redhat.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] HID: Send SwID in GetProtocolVersion
In-Reply-To: <20221111194526.1375601-1-abergmeier@gmx.net>
Message-ID: <nycvar.YFH.7.76.2211212235120.6045@cbobk.fhfr.pm>
References: <20221111194526.1375601-1-abergmeier@gmx.net>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 11 Nov 2022, Andreas Bergmeier wrote:

> According to docs a SwID should be sent for GetProtocolVersion.
> > 0x10.DeviceIndex.0x00.0x1n
> where n is SwID
> 
> Signed-off-by: Andreas Bergmeier <abergmeier@gmx.net>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index a0c148a8df6c..964a523c3de7 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -896,7 +896,7 @@ static int hidpp_root_get_protocol_version(struct hidpp_device *hidpp)
> 
>  	ret = hidpp_send_rap_command_sync(hidpp,
>  			HIDPP_PAGE_ROOT_IDX,
> -			CMD_ROOT_GET_PROTOCOL_VERSION,
> +			CMD_ROOT_GET_PROTOCOL_VERSION | LINUX_KERNEL_SW_ID,
>  			ping_data, sizeof(ping_data), &response);
> 
>  	if (ret == HIDPP_ERROR_INVALID_SUBID) {

Applied, thanks Andreas.

-- 
Jiri Kosina
SUSE Labs