Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964806AbXHJPx2 (ORCPT ); Fri, 10 Aug 2007 11:53:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932452AbXHJPxR (ORCPT ); Fri, 10 Aug 2007 11:53:17 -0400 Received: from styx.suse.cz ([82.119.242.94]:40803 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932447AbXHJPxQ (ORCPT ); Fri, 10 Aug 2007 11:53:16 -0400 Date: Fri, 10 Aug 2007 17:54:23 +0200 (CEST) From: Jiri Kosina To: Renato Golin Cc: Dmitry Torokhov , linux-kernel@vger.kernel.org Subject: Re: joydev.c and saitek cyborg evo force In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1235 Lines: 38 On Fri, 10 Aug 2007, Jiri Kosina wrote: > Renato, does force feedback work properly in Linux with this device? If > so, that would mean that the device has logical maximum and minimum for > X and Y axes different in input and output, and we would need to handle > this properly (we currently don't). Renato, does the attached patch (against 2.6.23-rc2) fix the problem with axis ranges for you please? diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 8edbd30..97dbdb6 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -351,6 +351,12 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel if (field->flags & HID_MAIN_ITEM_CONSTANT) goto ignore; + if (field->report_type == HID_OUTPUT_REPORT && + (usage->hid & HID_USAGE_PAGE) != HID_UP_LED) { + dbg_hid_line(" [non-LED output field ]"); + goto ignore; + } + switch (usage->hid & HID_USAGE_PAGE) { case HID_UP_UNDEFINED: -- Jiri Kosina SUSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/