Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 21 Nov 2022 13:57:08 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Xu Qiang <xuqiang36@huawei.com>
Cc:     <pmladek@suse.com>, <mcgrof@kernel.org>, <elver@google.com>,
        <gpiccoli@igalia.com>, <bigeasy@linutronix.de>,
        <tangmeng@uniontech.com>, <andriy.shevchenko@linux.intel.com>,
        <yangtiezhu@loongson.cn>, <john.ogness@linutronix.de>,
        <daniel.vetter@ffwll.ch>, <linux-kernel@vger.kernel.org>,
        <weiyongjun1@huawei.com>
Subject: Re: [PATCH RESEND] panic: Add register_panic_notifier and
 unregister_panic_notifier
Message-Id: <20221121135708.47f9a852a81d664a9b695336@linux-foundation.org>
In-Reply-To: <20221119080305.111863-1-xuqiang36@huawei.com>
References: <20221119080305.111863-1-xuqiang36@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 19 Nov 2022 08:03:05 +0000 Xu Qiang <xuqiang36@huawei.com> wrote:

> Add two methods to manipulate panic_notifier_list and export them.
> Subsequently, panic_notifier_list is changed to static variable.

Fair enough, I guess.  But...

- It would be better to include a followup patch which converts at
  least some of the existing sites, so we know the code is getting
  tested.

- Better names would be panic_notifier_register() and
  panic_notifier_unregister()

- You forgot to make panic_notifier_list static to panic.c.