Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02c514c0-62c4-1cdf-5d3f-b3d8942ef005@amd.com>
Date:   Mon, 21 Nov 2022 15:06:44 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v4 0/4] new subsystem for compute accelerator devices
Content-Language: en-US
To:     Oded Gabbay <ogabbay@kernel.org>
Cc:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
        Jeffrey Hugo <quic_jhugo@quicinc.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Arnd Bergmann <arnd@arndb.de>, Jiho Chu <jiho.chu@samsung.com>,
        John Hubbard <jhubbard@nvidia.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Christoph Hellwig <hch@infradead.org>,
        Christopher Friedt <chrisfriedt@gmail.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Kevin Hilman <khilman@baylibre.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
        Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@gmail.com>
References: <20221119204435.97113-1-ogabbay@kernel.org>
From:   Sonal Santan <sonal.santan@amd.com>
In-Reply-To: <20221119204435.97113-1-ogabbay@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzhSejRCVGRWZlVHT29YTEM1eFRETnFWa0hRQ20zb0N5V1N6MFFlUEFqNW9a?=
 =?utf-8?B?UkdEdU9VTTVXTHg0cFJNWm1qWFVnYzFyOXhzWEVOSlVEcmZqZFNudzBXQllY?=
 =?utf-8?B?RjB6czJnUWIxc3ViZFdwTmk1RHFmWlV6QTVoUWJ2WVQ5a2dzWG1CdEtoaWo1?=
 =?utf-8?B?VC9INW5tR1BuRlQ4VWVOTlRlTGJSRmRrVDRnT0pyVXd0VWUwK01QYUZNZHdC?=
 =?utf-8?B?a0RrN1JTMFRNTVlZT2tYQlF4SWcyNjhZajdmcDJzY3pLTWlhUHdsdWpYZ1ZE?=
 =?utf-8?B?MkJWcVdtM1BPWUdzTVlxT0hYT1FYK0JjTWhVajZEaDltMXpkc282Y0lYQVF6?=
 =?utf-8?B?Ky80ZDEzemh2YWlzSHdWSU1RazZjWHByZHJUeFd5cnNQekt0MkwwVjdvWjlL?=
 =?utf-8?B?VW0xcTkvNFJrR0VWekk5NHhuZ0R6TEdST0MxOVlJOThicEZYeVNTTHBkNS9a?=
 =?utf-8?B?amRHSlh4bzVFRDVvMWNaOExpNzVWaUZ5QktCM0NQZFV4dzRXOGNXSTM3d2d2?=
 =?utf-8?B?NGlWTnBCUXVIZTdoNThGY1VaT3o1Q1hndG1ScVZZRUxSSndVL2pSMS9WdGZm?=
 =?utf-8?B?MnA2OUNjc1dLcm96QVdDT0hFU2Q4L1BrczFEak9WcUg2c21tVHVOMWs4SlRB?=
 =?utf-8?B?L1lHNjZ0MW55MmFZK0ozb3gydXNzVTd6K25DVGhCSkt0UFJYV1NIREJnSmVu?=
 =?utf-8?B?Vm9kckd4VWRJcnMvd25ZY2M1QzhOaTdJajJtalQ1dTdleDNrZTRIbDk3azBi?=
 =?utf-8?B?bnlURmZ1RVZBSFJqb3hpdU0yQVliWXp5aEV0M2sxdktEZnhCbzZjWmxqalIw?=
 =?utf-8?B?RE5oKy83d1lOMGZicXgyOUJSMldwOGtCMG0wWHZhbWV1TFVyVkxWbmdtUll1?=
 =?utf-8?B?K2ZsMjFseXhkWFE3OHA1b0hNZm43aXZNTTVuckJnLzIzMHl0UHQwQ29VdUhy?=
 =?utf-8?B?L3dzc2xPNkpuMEZjMzBvWk5aUk5pQkNpK3hubHpqL1pXbmd0c0RtMTRBOW95?=
 =?utf-8?B?VWJQMGhIc1pMa2VyOXBKWXdJbkkvRWE0dXgreC8rWjk4Ly9lV0l1V1hSNEM3?=
 =?utf-8?B?WUhOM283S3hlMnZNOHN4Tk5PZTAwUDd6WXJiVjVaRUw2TVMrcUprMHZ4U3V5?=
 =?utf-8?B?bUFraGRSQ2N2UHRsaTZnbHdmckNZSkZ3cm5SUjdmZ3JUQUxsTkpOWG4vSWZy?=
 =?utf-8?B?YVRTbWdiVGlJUkxQRWJWYjhCT2hKWEFOVmdBQ2o4TVkyK0FwYTFjZVUxUUJ1?=
 =?utf-8?B?RmhFeHlBcEE5cldvaVZHZ3RINVpXUUU1em94QWQyeHNvK3pzNXlJYkh0R29V?=
 =?utf-8?B?ZDZRdWtkdUFITTNsTi9qamxtNHF1UGJobmoycitrV2U2RFNVUWhqbkJRYS9n?=
 =?utf-8?B?UWh5R1djSmZWK1pLMlo4L2hoWUhlWms0a0NKdlBIazVtNzhqeTdKZThBZ2Nq?=
 =?utf-8?B?b3NCd1c4dEcwTFF3Vm1tendRVUhVRnczelBYR1ZoNTZHV0V0bWtRS1NoTGg4?=
 =?utf-8?B?TURPTUNGTVR0ZEdDbGhweTlSMWI2SVlIMTdEanpHY3JDVm51VjdyT1pWUTRs?=
 =?utf-8?B?WXRhREZBdk1aeEF6VHVhQlpWbEN6MGJTOTlYaC8xQjBWdEZScDZpV1FHOGlo?=
 =?utf-8?B?OXdBRTBLQnVUNHJXOFN5MGU3WHhLMGVDdGxCMU44bEdGRWhmNS9UeEI1YmNm?=
 =?utf-8?B?MzBmNUVvbWNhUDJmQjB1aE1mLytqNE1rOTZKNU5odFNzVTFtWGpKTW5hTzNH?=
 =?utf-8?B?M0pSMHRSa1FBemFSUmJiYXNzemJ3d0tvT0Yzb240OWxPa0hHcjQyaStETmdQ?=
 =?utf-8?B?MTVYeUtocU14UlpHbUNMYStqY1N5a2QyWXh6SG5zYlVjRVdHRG1sSWtQNHh2?=
 =?utf-8?B?bVk4S1RkR1J4UWpORkR6bHVROHZsbFpVVUpGN21XRjNpdm43N25haFVXMXlw?=
 =?utf-8?B?cjhTMm9qNWtsQWl1dlIxYlJMNnRlM0M2TXk5L3dML2g5Zkw0NzgzTTRKeGlR?=
 =?utf-8?B?SDN3MmMwVUtlQnVtMmx4clpFeTNrVFZZRVAwUGIraWY5K0NlZlRWWVNyQmo0?=
 =?utf-8?B?VHROd05QMXVDb0lRT3dtZ21sdjhaUlQxWVlhY2JrSWwrMzJzdkQyR0hOMEpx?=
 =?utf-8?Q?wJ+I52EPnySNFxdmqjeVu4CqP?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8d123d-9b9e-440b-5b15-08dacc151116
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4502.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 23:06:48.0965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VX1Qka41YHQW35T7ahutMLFFbvF6A863XA1QEjRPpxMd7ThJteFqQcBsB6Q+YV4t
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7563
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/19/22 12:44, Oded Gabbay wrote:
> This is the fourth (and hopefully last) version of the patch-set to add the
> new subsystem for compute accelerators. I removed the RFC headline as
> I believe it is now ready for merging.
> 
> Compare to v3, this patch-set contains one additional patch that adds
> documentation regarding the accel subsystem. I hope it's good enough for
> this stage. In addition, there were few very minor fixes according to
> comments received on v3.
> 
> The patches are in the following repo:
> https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4
> 
> As in v3, The HEAD of that branch is a commit adding a dummy driver that
> registers an accel device using the new framework. This can be served
> as a simple reference.
> 
> v1 cover letter:
> https://lkml.org/lkml/2022/10/22/544
> 
> v2 cover letter:
> https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/
> 
> v3 cover letter:
> https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/

Thanks for defining the new accel subsystem. We are currently working on
DRM based drivers for unannounced acceleration devices. I am fine with
these changes with the assumption that the choice of using classic DRM
or accel is left up to the individual driver.

-Sonal

> 
> Thanks,
> Oded.
> 
> Oded Gabbay (4):
>   drivers/accel: define kconfig and register a new major
>   accel: add dedicated minor for accelerator devices
>   drm: initialize accel framework
>   doc: add documentation for accel subsystem
> 
>  Documentation/accel/index.rst         |  17 ++
>  Documentation/accel/introduction.rst  | 109 +++++++++
>  Documentation/admin-guide/devices.txt |   5 +
>  Documentation/subsystem-apis.rst      |   1 +
>  MAINTAINERS                           |   9 +
>  drivers/Kconfig                       |   2 +
>  drivers/accel/Kconfig                 |  24 ++
>  drivers/accel/drm_accel.c             | 323 ++++++++++++++++++++++++++
>  drivers/gpu/drm/Makefile              |   1 +
>  drivers/gpu/drm/drm_drv.c             | 102 +++++---
>  drivers/gpu/drm/drm_file.c            |   2 +-
>  drivers/gpu/drm/drm_sysfs.c           |  24 +-
>  include/drm/drm_accel.h               |  97 ++++++++
>  include/drm/drm_device.h              |   3 +
>  include/drm/drm_drv.h                 |   8 +
>  include/drm/drm_file.h                |  21 +-
>  16 files changed, 711 insertions(+), 37 deletions(-)
>  create mode 100644 Documentation/accel/index.rst
>  create mode 100644 Documentation/accel/introduction.rst
>  create mode 100644 drivers/accel/Kconfig
>  create mode 100644 drivers/accel/drm_accel.c
>  create mode 100644 include/drm/drm_accel.h
> 
> --
> 2.25.1
>