Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5161646rwb; Mon, 21 Nov 2022 17:54:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Dz6ebV7Vfq6ifclKKEBpm9YCFm//0hqiFT2pDz0XKVDgsKfYxbbYXAYuKkKuciPuZkHsq X-Received: by 2002:a63:d54a:0:b0:476:c7f2:7b80 with SMTP id v10-20020a63d54a000000b00476c7f27b80mr1474895pgi.230.1669082077417; Mon, 21 Nov 2022 17:54:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669082077; cv=none; d=google.com; s=arc-20160816; b=kSy+WbrLBQqVuaYKP5UZbWuUK40+2zKYCFvyjiJJJmY6CS/3s1A3ROKc02qH6u1Cwa PMCRLpoLiEgDbkX4qivxAuITc5wCry+Nt3N8aa8UMzZYSh1UyqbKAGZeY5IjbqrTpwQR EpFGbWtVdWJPUJ0a35wt/UziTv3qmE4MHe3aO8bfD/XkdLT2FU29hBwSkTKZudVj2h7c HLPL+R5k+MMndUr3XUNKkhzsAFGpwImOwcub4CNhTjhEYsNYh5mQdTaNYiRZrYBkfeuF mWVFIQSnsBFQ6W1rNeXWtnMpdnZL1XO4vL+HyzrkRQzcdVnyczH9J6rrk3rrMP1ESU5J qx+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=W2nfk7sYOCq+1VT5YUgYpmiGCr6J+zO0iGjA64uRB3Y=; b=pw9s3k5p9n+C8qoof4YMJcDo1cOrEWexbeI6eawN3SQza2AAaAsOrdcsvA05otZB+W 248uznu9BBlDhchaDT2UZ+8+68TVmG51rtn38Jl5c4tQKX2okpow1tyyOjQ8LPkDKbnp Pek8u96Uk6yYsoWXMWsh8FGRoFu58j0twrmPJdoidOraYANqu6Sq5/4VKof7fJPBU9/U eNfMM6aUAXJ3AAWAyPLycKACELD/+MzL+YFGDW+CvZiLNZZs05FtK8h/y33oM6hocPOt d+vopk+5yWmSY4Uwf0tfYhFCe3g/LFVs/SdJu2iME4F+S2RB/CLpoqFB+rIcRrzKV7k/ cE7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=CBRArT89; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n38-20020a056a000d6600b0056e6d31b27asi11635536pfv.160.2022.11.21.17.54.25; Mon, 21 Nov 2022 17:54:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=CBRArT89; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbiKVBCo (ORCPT + 91 others); Mon, 21 Nov 2022 20:02:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbiKVBCl (ORCPT ); Mon, 21 Nov 2022 20:02:41 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7CBC1116F; Mon, 21 Nov 2022 17:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=W2nfk7sYOCq+1VT5YUgYpmiGCr6J+zO0iGjA64uRB3Y=; b=CBRArT89E3fBZWMJm/Fw3JaUjF 4o2LvmWiG1XXMfjd2psFwHfHlCbxIhcavrGwYgG9ijVvhtkCGXjFt1y9Wy8FVUcD8Zr1JB5Kr5z6m GWxA0oKjLJm1WXFZRNBLXkEb559onnHSmVCL7GiGThV2rlnxwNIpP2JWWI7m4HJUdz6A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oxHgD-0034LU-Ao; Tue, 22 Nov 2022 02:02:29 +0100 Date: Tue, 22 Nov 2022 02:02:29 +0100 From: Andrew Lunn To: Maciej Fijalkowski Cc: Roger Quadros , "davem@davemloft.net" , "kuba@kernel.org" , "edumazet@google.com" , "pabeni@redhat.com" , "vigneshr@ti.com" , "linux-omap@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove redundant ALE_CLEAR Message-ID: References: <20221121142300.9320-1-rogerq@kernel.org> <20221121142300.9320-3-rogerq@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2022 at 06:51:05PM +0100, Maciej Fijalkowski wrote: > On Mon, Nov 21, 2022 at 03:22:58PM +0100, Roger Quadros wrote: > > ALE_CLEAR command is issued in cpsw_ale_start() so no need > > to issue it before the call to cpsw_ale_start(). > > > > Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") > > Not a fix to me, can you send it to -next tree? As you said, it's an > optimization. commit fd23df72f2be317d38d9fde0a8996b8e7454fd2a Author: Roger Quadros Date: Fri Nov 4 15:23:07 2022 +0200 The change being fixed is in net-next. Roger, please take a look at the netdev FAQ and fix your Subject line. Andrew