Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] can: can327: fix potential skb leak when netdev is down
To:     Max Staudt <max@enpas.org>
CC:     <wg@grandegger.com>, <mkl@pengutronix.de>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>
References: <20221110061437.411525-1-william.xuanziyang@huawei.com>
 <20221111010412.6ca0ff1c.max@enpas.org>
From:   "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>
Message-ID: <cd51300f-34cc-3222-7bd9-ec349b9cd603@huawei.com>
Date:   Tue, 22 Nov 2022 10:10:50 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20221111010412.6ca0ff1c.max@enpas.org>
Content-Type: text/plain; charset="gbk"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,

Gently ask.

Is there any other problem? And can it be applied?

Thanks.

> (CC Vincent, he may be interested)
> 
> 
> On Thu, 10 Nov 2022 14:14:37 +0800
> Ziyang Xuan <william.xuanziyang@huawei.com> wrote:
> 
>> Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev
>> is down. Not tested, just compiled.
> 
> Looks correct to me, so:
> 
> Reviewed-by: Max Staudt <max@enpas.org>
> 
> 
> Thank you very much for finding and fixing this!
> 
> Max
> 
> .
>