Subject: Re: [PATCH 14/14] NFS: Use local caching [try #2]
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, steved@redhat.com,
       linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com,
       nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org
In-Reply-To: <24071.1186754680@redhat.com>
References: <1186687557.6699.167.camel@heimdal.trondhjem.org>
	 <1186683869.6699.136.camel@heimdal.trondhjem.org>
	 <20070809160438.17906.76348.stgit@warthog.cambridge.redhat.com>
	 <20070809160550.17906.40862.stgit@warthog.cambridge.redhat.com>
	 <21984.1186685548@redhat.com>  <24071.1186754680@redhat.com>
Content-Type: text/plain
Date: Fri, 10 Aug 2007 12:07:45 -0400
Message-Id: <1186762065.6642.5.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 925
Lines: 24

On Fri, 2007-08-10 at 15:04 +0100, David Howells wrote:
> Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> 
> > > > Dang, that's a lot of inlines... AFAICS, approx half of fs/nfs/fscache.h
> > > > should really be moved into fscache.c.
> > > 
> > > If you wish.  It seems a shame since a lot of them have only one caller.
> > 
> > ...however it also forces you to export a lot of stuff which is really
> > private to fscache.c (the atomics etc).
> 
> The atomics is actually a bad example.  These are referred to directly by part
> of the table in fs/nfs/sysctl.c.  Is there a better way of exporting
> statistics than through /proc/sys/ files?

/proc/self/mountstats

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/