Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: [PATCH v1] f2fs: avoid victim selection from previous victim
 section
Reply-To: yonggil.song@samsung.com
Sender: Yonggil Song <yonggil.song@samsung.com>
From:   Yonggil Song <yonggil.song@samsung.com>
To:     "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "chao@kernel.org" <chao@kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Message-ID: <20221122023656epcms2p4468d4feb97711516206e19890dad09ac@epcms2p4>
Date:   Tue, 22 Nov 2022 11:36:56 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20221102100756epcms2p23dfabe90c467313ce094c5c81a99c6d7@epcms2p4>
Precedence: bulk

When=C2=A0f2fs=C2=A0chooses=C2=A0GC=C2=A0victim=C2=A0in=C2=A0large=C2=A0sec=
tion=C2=A0&=C2=A0LFS=C2=A0mode,=0D=0Anext_victim_seg=5Bgc_type=5D=C2=A0is=
=C2=A0referenced=C2=A0first.=C2=A0After=C2=A0segment=C2=A0is=C2=A0freed,=0D=
=0Anext_victim_seg=5Bgc_type=5D=C2=A0has=C2=A0the=C2=A0next=C2=A0segment=C2=
=A0number.=0D=0AHowever,=C2=A0next_victim_seg=5Bgc_type=5D=C2=A0still=C2=A0=
has=C2=A0the=C2=A0last=C2=A0segment=C2=A0number=0D=0Aeven=C2=A0after=C2=A0t=
he=C2=A0last=C2=A0segment=C2=A0of=C2=A0section=C2=A0is=C2=A0freed.=C2=A0In=
=C2=A0this=C2=A0case,=C2=A0when=C2=A0f2fs=0D=0Achooses=C2=A0a=C2=A0victim=
=C2=A0for=C2=A0the=C2=A0next=C2=A0GC=C2=A0round,=C2=A0the=C2=A0last=C2=A0se=
gment=C2=A0of=C2=A0previous=C2=A0victim=0D=0Asection=C2=A0is=C2=A0chosen=C2=
=A0as=C2=A0a=C2=A0victim.=0D=0A=0D=0AInitialize=C2=A0next_victim_seg=5Bgc_t=
ype=5D=C2=A0to=C2=A0NULL_SEGNO=C2=A0for=C2=A0the=C2=A0last=C2=A0segment=C2=
=A0in=0D=0Alarge=C2=A0section.=0D=0A=0D=0AFixes:=20e3080b0120a1=20(=22f2fs:=
=20support=20subsectional=20garbage=20collection=22)=0D=0ASigned-off-by:=C2=
=A0Yonggil=C2=A0Song=C2=A0<yonggil.song=40samsung.com>=0D=0A---=0D=0A=C2=A0=
fs/f2fs/gc.c=C2=A0=7C=C2=A05=C2=A0+++--=0D=0A=C2=A01=C2=A0file=C2=A0changed=
,=C2=A03=C2=A0insertions(+),=C2=A02=C2=A0deletions(-)=0D=0A=0D=0Adiff=C2=A0=
--git=C2=A0a/fs/f2fs/gc.c=C2=A0b/fs/f2fs/gc.c=0D=0Aindex=C2=A04546e01b2ee0.=
.10677d53ef0e=C2=A0100644=0D=0A---=C2=A0a/fs/f2fs/gc.c=0D=0A+++=C2=A0b/fs/f=
2fs/gc.c=0D=0A=40=40=C2=A0-1744,8=C2=A0+1744,9=C2=A0=40=40=C2=A0static=C2=
=A0int=C2=A0do_garbage_collect(struct=C2=A0f2fs_sb_info=C2=A0*sbi,=0D=0A=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0get_valid_blocks(sbi,=C2=A0seg=
no,=C2=A0false)=C2=A0=3D=3D=C2=A00)=0D=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0seg_freed++;=0D=0A=C2=A0=0D=0A-=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0if=C2=A0(__is_large_section(sbi)=C2=A0&&=C2=A0segno=C2=
=A0+=C2=A01=C2=A0<=C2=A0end_segno)=0D=0A-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sbi->next_victim_seg=5Bgc_type=5D=C2=A0=
=3D=C2=A0segno=C2=A0+=C2=A01;=0D=0A+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if=C2=A0(__is_larg=
e_section(sbi))=0D=0A+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0sbi->next_victim_seg=5Bgc_type=5D=C2=A0=3D=0D=0A+=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(segno=C2=A0+=C2=A01=C2=A0<=C2=A0end_se=
gno)=C2=A0?=C2=A0segno=C2=A0+=C2=A01=C2=A0:=C2=A0NULL_SEGNO;=0D=0A=C2=A0ski=
p:=0D=0A=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0f2fs_put_page(sum_page,=C2=A00);=0D=0A=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=7D=0D=0A--=C2=A0=0D=
=0A2.34.1