Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5372656rwb; Mon, 21 Nov 2022 21:59:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf7S50UmGrR/U80Ph0HdmTkKk+heuKvFDoZy24+FJWLSfUcWOaoybTATcXNOtk0LchKyi7Kq X-Received: by 2002:a50:bb08:0:b0:469:1684:217d with SMTP id y8-20020a50bb08000000b004691684217dmr9777574ede.270.1669096745031; Mon, 21 Nov 2022 21:59:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669096745; cv=none; d=google.com; s=arc-20160816; b=JMRVqIgqIlR39D/ezqQdLC0D5NaGGFTG/c6UzRmOAQ/SCsj6c+hc6uHOLWAz3HvHvL QgrfUCLFx6z3A8Cp/MTwgTQG2QCsywc6cIAtOVs4TiNoOGDa+sgW72M1U8lyRrhu3Jwy fAJt2ZqjadaXr6lKMMAtWl/t8+2THoIQBZOX8meCEFds6B/p/wHNIl+ZMnYaxCap2NdU AO1B+cvA0aLUqq/pzHsvlt312R2dKqyH04xofSo19cKyCNDBephAvuWKoD4XZlsyyEXd jAMVkFqvm17JOXrde377MFhv1r67tDBrCP/4jWZY441/hHeRMSKlbIVAIpXFBATtKuCK Rkng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=jjiZg3BkKRa+5nrgX4c6pM7EemDt9g+l9eFKcUuBwg0=; b=sa43uSfvaltZaAs/X5kBgU8xszRmQEYfyHDWr7N8KsCtfsziBAAMkZYlVm62P0SLvG aaSApMGxZdi50LyuLpp4iUs2Cw6shSwPRy+yZ4XQkLl2EZpRIfIfS5vEMMbYbd75swja cA71IMF0VbRECTwurxZiEO8WosDkPI1tO5y/ZJtnuWj7dQIbrDYIrufs4kcleGT5ShTU j0SoJgF2xOC4cx3cVhBr2HcF/4GM63Nkx5PCOOzO5tjNTuWlagY4SF66CulPlM7ddLUk EJoHEsKiLqL8tqH5nEHOD/6dCpvgwjqXLVmRaP6cm1i3tKBG9FrphiUSlXFSlYaGncMK KA+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LGqR8sYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa19-20020a1709076d1300b0078db3ce1e59si12638537ejc.38.2022.11.21.21.58.42; Mon, 21 Nov 2022 21:59:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LGqR8sYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231641AbiKVFqp (ORCPT + 91 others); Tue, 22 Nov 2022 00:46:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbiKVFqk (ORCPT ); Tue, 22 Nov 2022 00:46:40 -0500 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F6902250C for ; Mon, 21 Nov 2022 21:46:38 -0800 (PST) Received: by mail-qv1-xf2b.google.com with SMTP id cz18so3164769qvb.13 for ; Mon, 21 Nov 2022 21:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jjiZg3BkKRa+5nrgX4c6pM7EemDt9g+l9eFKcUuBwg0=; b=LGqR8sYOlJCM7sRrnNFAfrnydhj12NbWtVQsTHjVpM+NG8nU/c+AyEea9A0AH/GN8G egm8+O5nltbpOQsSiAwk+bgqQg1m4tGzDJW1sKx2xz4pbY0owbTW+2+5iC0kh36cG3gD 8/dMVb8Vi/ul16v707s8H9Zet8YJOe+T2S6/0l9hVzzC7OAQFi0uowu/srq2MvqgLxW7 nv/Pr0jpYreeB5k1PbLe061bc3+dx2NO6DcMdO9uCk5Q/D6LlzpiKR+XKxqq4lfm7Ed+ XnTAwP0PMbj2VyUR7sgBUd2PoEGqCXs5PxBW7XiphSLH2H93UFPlG4Hb9AF2QkcZybyz ErLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jjiZg3BkKRa+5nrgX4c6pM7EemDt9g+l9eFKcUuBwg0=; b=2ZCwMc1FZSp/H1Tqkf6dwmftcwYBVUAqAU7Bs3fLot9YfXZ49xE3xb6vCWNVKBvMtk Qlo8N0gVHS5yZwj9QIoodtvGTFuUQQ7gqP8DVLhQa2wIIvUqciH3yQiGtx/0VBOoUA2v uu5qZFH+L6yZx0EzCPqkNG0GilT67/0QNKOHUfuw1LxXzPvMsQNx+7SUr5tIAlIa61Gl 3DyEAgRN1lqYtVykjG/OupDoi4TyxD2cTif8bw9D3mcLfYNxYc3+5jaBEpl8edCHgmQq QfKsLBoToKHza4z6WcH+/Bv9MqfpbjM9nfKUGh4YLv5jZ2dIg/pOcQLYe5BJSph1rVXK 8l9w== X-Gm-Message-State: ANoB5pkiPK9fghdgXEMQlQwOpnn7clXftf9VUpDMldyUu2dZ2A/Qb2+a X6p6qt/JqXBxziLeVhXQbZRng74iYwh1j+hiPjE= X-Received: by 2002:a05:6214:3712:b0:4bb:9358:2a1e with SMTP id np18-20020a056214371200b004bb93582a1emr4535379qvb.97.1669095997497; Mon, 21 Nov 2022 21:46:37 -0800 (PST) MIME-Version: 1.0 References: <20221119204435.97113-1-ogabbay@kernel.org> <02c514c0-62c4-1cdf-5d3f-b3d8942ef005@amd.com> In-Reply-To: <02c514c0-62c4-1cdf-5d3f-b3d8942ef005@amd.com> From: Dave Airlie Date: Tue, 22 Nov 2022 15:46:25 +1000 Message-ID: Subject: Re: [PATCH v4 0/4] new subsystem for compute accelerator devices To: Sonal Santan Cc: Oded Gabbay , Tvrtko Ursulin , Jacek Lawrynowicz , Jeffrey Hugo , Jason Gunthorpe , Arnd Bergmann , Jiho Chu , John Hubbard , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christoph Hellwig , Christopher Friedt , Thomas Zimmermann , Kevin Hilman , Alex Deucher , Yuji Ishikawa , Maciej Kwapulinski , Greg Kroah-Hartman , Jagan Teki , Daniel Vetter Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Nov 2022 at 09:06, Sonal Santan wrote: > > On 11/19/22 12:44, Oded Gabbay wrote: > > This is the fourth (and hopefully last) version of the patch-set to add the > > new subsystem for compute accelerators. I removed the RFC headline as > > I believe it is now ready for merging. > > > > Compare to v3, this patch-set contains one additional patch that adds > > documentation regarding the accel subsystem. I hope it's good enough for > > this stage. In addition, there were few very minor fixes according to > > comments received on v3. > > > > The patches are in the following repo: > > https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git/log/?h=accel_v4 > > > > As in v3, The HEAD of that branch is a commit adding a dummy driver that > > registers an accel device using the new framework. This can be served > > as a simple reference. > > > > v1 cover letter: > > https://lkml.org/lkml/2022/10/22/544 > > > > v2 cover letter: > > https://lore.kernel.org/lkml/20221102203405.1797491-1-ogabbay@kernel.org/T/ > > > > v3 cover letter: > > https://lore.kernel.org/lkml/20221106210225.2065371-1-ogabbay@kernel.org/T/ > > Thanks for defining the new accel subsystem. We are currently working on > DRM based drivers for unannounced acceleration devices. I am fine with > these changes with the assumption that the choice of using classic DRM > or accel is left up to the individual driver. I don't think that decision should be up to any individual driver author. It will have to be consensus with me/Daniel/Oded and the driver authors. Dave.