Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5475035rwb; Tue, 22 Nov 2022 00:00:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf78/4liRQ3SEinNq3N2TQJslheXjAcdk5G4xVxcdf8wisxXKjLkpfgRs//aZy218jibmPDi X-Received: by 2002:a05:6402:138f:b0:461:5b75:d3df with SMTP id b15-20020a056402138f00b004615b75d3dfmr20529051edv.367.1669104012534; Tue, 22 Nov 2022 00:00:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669104012; cv=none; d=google.com; s=arc-20160816; b=I9Fw8Ycqe5OA5JfmOvwYvS5XOhl1Boe2Rv8v5ujmRUki2pdFx/t1P6mtO2EY/7zxrC cBbTAyDqudi4Ix+dLK/KxkKjtOI/qpLYLG2cpVizVZRuMis49hjqdYxbjtrapbyIi/hp ddmmu0o5PHXOLz04U4D7eFohcOWi+R/rXOTCe9fOdVvtmM7l3vM8x984cM/P2UCUPG44 KMfBMuWPfGruCJtl6wc37tND8HRfB7odT+qSpyrSg5dxYViHj8Vz7DsfJJHbMLZHIG2T rkDUzj35vQEtNBlrogTiikRAezumEILYlmsz/dCWdYDZNKndmxrkz9itMzmWd2zX/yDU qBog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MSSoozAZzRH9A1wAx3O1UtGKYxpTu5VxtCoRrtwK2vs=; b=EYn3ZbUTS9M8M38bRQaTSiyTx5jHKdDijGkCpZkXRxnTzcsNfUg2Q1f3HDLIFn4Cnk jhqNsCW8mWIGzrd2nPUsecU5NJq0tXjWX4wNbSQx6ZEHvLm3GKB8eDEOFPVHjGaCqu99 p2/LZQHtU6qBBwuSaDMrOtM5qrs1yzHaHe2pUCREVHVkPHDLI6+a50rfUIfSE6qbm/SW phkNcbhcErHIE5gVI/SJXRpQTkMFMlt9wWUd++dOAPWXqORgFoClVp3M1FgiZCY8llHx 3nk3qV+38NYARq34Mmz3wlL3dEb9JNZ4vLzXNfTq5pl9xFprUCt6lM3/fOhl712mjmNJ PFeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="B/dBYyTT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020a05640240d300b00468cd0b1cafsi12242572edb.163.2022.11.21.23.59.47; Tue, 22 Nov 2022 00:00:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="B/dBYyTT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232580AbiKVHtU (ORCPT + 92 others); Tue, 22 Nov 2022 02:49:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232552AbiKVHtP (ORCPT ); Tue, 22 Nov 2022 02:49:15 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78FE9326E3; Mon, 21 Nov 2022 23:49:15 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id q1so13368095pgl.11; Mon, 21 Nov 2022 23:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MSSoozAZzRH9A1wAx3O1UtGKYxpTu5VxtCoRrtwK2vs=; b=B/dBYyTTnKT7UAez0oRgLP+5AYwNFEkcu8aKlEgvqpvRqqb4fueqo2RyXLOpy6ZhCY UYdSzoMPTd7EEtiwosfh2XIhTLqQXLyY2rRdbIXYIFHecdA/0rXnFJq9NkM5xiJ2sDGb njNRp9Jt4CAUic8/SCiSTsKXCV191YK5Mp1H4od3csFZByMS0OLUU6OJLu5U5A+4HUQN ddUFN1yyptOldI5pc88s7DbGRvStFtHKiOH2mK9ZeVu25xruId53Sdipgk43gJeqwjbe p2JtNKs5R/pJ3XhrezhQ6TeVffl0OkIs+MyIpl46/DlLD+V7jvqn5KimqkNv55CVbVIi E8Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MSSoozAZzRH9A1wAx3O1UtGKYxpTu5VxtCoRrtwK2vs=; b=xDYRF1GMxOqbChmn7O4fIyKRBfV36rV0a2UvXS3lh6AtGo/lt72Qh5bZGZtIM7FyE9 deB25d+ZOZH6fXi6EC+elE+N6cmKYu+kl7+rSClD7FlHZZr8XkzSHHJhJl5dvCvy7AXx Cm3+ad77a5JsUePqpxlOCK7gcIKTJ9A4/A6j89NwnNWI+5BO/dlmlRJbZ87EZhI60i09 LMvAdX+ltqHLcu6GDECh/PGpzDR1v9tr7rgcFWqk5i650+B4TlWwo0DYU/kgPQkniK/i HZ0sepgVfMtaXjBpHVIYLtOvLsqkR2E+HzWPpLSzNA8L8obZUxVBoBd0G0SAoeGrz02e Jmbw== X-Gm-Message-State: ANoB5pkRIdLGeQ7apPC7P4XCNJJwxDJ032f/s1lrciipfp/dnsMnuFf0 89tWiUtK31eqQcv15aEn0A4= X-Received: by 2002:aa7:9635:0:b0:56b:6936:ddf6 with SMTP id r21-20020aa79635000000b0056b6936ddf6mr2588811pfg.84.1669103354867; Mon, 21 Nov 2022 23:49:14 -0800 (PST) Received: from localhost.localdomain ([43.132.141.3]) by smtp.gmail.com with ESMTPSA id mv13-20020a17090b198d00b0021896fa945asm5951141pjb.15.2022.11.21.23.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 23:49:14 -0800 (PST) From: zys.zljxml@gmail.com To: bbrezillon@kernel.org, arno@natisbad.org, schalla@marvell.com, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Yushan Zhou Subject: [PATCH] crypto: marvell/octeontx - remove redundant NULL check Date: Tue, 22 Nov 2022 15:49:00 +0800 Message-Id: <20221122074900.3660531-1-zys.zljxml@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HK_RANDOM_ENVFROM, HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yushan Zhou release_firmware() checks whether firmware pointer is NULL. Remove the redundant NULL check in release_tar_archive(). Signed-off-by: Yushan Zhou --- drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c index df9c2b8747e6..c4250e5fcf8f 100644 --- a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c +++ b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c @@ -345,8 +345,7 @@ static void release_tar_archive(struct tar_arch_info_t *tar_arch) kfree(curr); } - if (tar_arch->fw) - release_firmware(tar_arch->fw); + release_firmware(tar_arch->fw); kfree(tar_arch); } -- 2.27.0