Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5522772rwb; Tue, 22 Nov 2022 00:53:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf6mBQXCfbtlETKL4IecpxbKLvHg6EWiJg+9vWl9ZsrL2lznHiHJPuLL+tCyJr+XwMmzeXIl X-Received: by 2002:a17:903:1314:b0:17f:def6:a483 with SMTP id iy20-20020a170903131400b0017fdef6a483mr3638292plb.66.1669107198723; Tue, 22 Nov 2022 00:53:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669107198; cv=none; d=google.com; s=arc-20160816; b=S4dUSCFGb0jys7P+sPwAV1X5WsB9AL7Xybrw+jCjhAmIxu62shwPO6cePZyLYhdacZ JAGYd6rvmC7VosNsAh3UkGKZautm1PJU/Eyq0MZzAYHCmppeH0TOU3iQhBssehTWPgOU XGe1kZx5r+kx87O9Roz9iEsjRSWbr4voKBXYkFBSeS+FV90sI+GQrsy+2bdwt/NOfQMa 5rTaezhClhUpC0UKt6nWWOohwfCxuk2Y93fM/Cimr0+TQyQBw+STbzslvhczs8lSvf/m TEzNyT8zs9uQFExsChN/xg/vHgUARQmWkKX15FEmlq8cpAW+6wanWISYI42uFCM+dhnX JbxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=NBwxUgJR8NGe1DGEeONE6WsC29VoXRjD7bpTza6BfUg=; b=bxu5K3WbWEIUDFQrUE9rUUibOuIbt5kOA3HPgaw2wUhKxu0PSWPxxCq7dvkqQ2mIKL wOviPC9QLyfWRJxz2ExPD2QeN2q8KGMtpKiPhaCEfa5MaSx4EJIymObeQ+MxwupSTn83 vbvSYT1G12h22SfS7dPR9H4U8jYnziThetCcccz10aTYgtBOoOsvJ/T31Q9YyxJczWuZ RqUbQOsdFSgW69BMlm7Fc+/lDqYi/e9X0mFvg8HUc+HeXs1cXjYckdN3HbGFNu1ZTfRc 4af61F+slnf/+bMRUjWPAh6jiwTbXsDjirRTWrQq9bWd5yIVcMh7sd7xRtbirCFjkhwc DpMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hYAbwKH5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b16-20020a170902d51000b0018666611f85si15152550plg.508.2022.11.22.00.53.05; Tue, 22 Nov 2022 00:53:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hYAbwKH5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232249AbiKVI2J (ORCPT + 92 others); Tue, 22 Nov 2022 03:28:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232389AbiKVI2F (ORCPT ); Tue, 22 Nov 2022 03:28:05 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECC51EEFB for ; Tue, 22 Nov 2022 00:27:54 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id f13so966885lfa.6 for ; Tue, 22 Nov 2022 00:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NBwxUgJR8NGe1DGEeONE6WsC29VoXRjD7bpTza6BfUg=; b=hYAbwKH5QwjJOnfG9yEqUEgsnSseVoMPMrJp+TMXhBuNDQRxQ7RGD2NZcJx5RF+zdA zUEk6UCdzfHcUK/i4onhOvHK87UBvBaTtB6peOCWfiL0E9taxsBJKQAuhXQwodrEkVkC xL4sq0zWy3xh5+IAfFLbnPn5FT4ksU/GwbnVR5jX1LdlxqpGUKomwAIjVft2/AjPof62 nm50CPe+4nUcYIm+1y65yNh83iK7eQx3FdObF/vzsX2WvFcNjpF1qtxTlHNfXSG4+isj phqUXSEniYZJ9DRmp46DvhNRcA2pOtPfiMCiJJGMU5CJvzQiRv4Avf8fRcdDjWA1DeiX dzGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NBwxUgJR8NGe1DGEeONE6WsC29VoXRjD7bpTza6BfUg=; b=WqmGDkNPWa9iYQYQaFaAENDzFHh6AIgly8Hx1ei3LulA1OKfwccmxCzWfc8RGsqhho aN35q8YTEr6JfXZeGRj0uRJOfyQ9+UW3vv/jgXiN9xITg8ZKQh9wsNh30J7m9jmAyg42 eInDa/fQ6fPwNwa9sGnQ8o35v1LK/pPAI0CiblUWILHt95IVBU2se6YmcvcFqUIQZwZi Za1cSpoHXePOgZbJ4l9IqElo9uSuBp7yoDBMdW8AgxkVyzQSREvqmLBrjjMkqPeRiTcI 42zbq2CxS3qvXtUDWCA3ZuejyGH75nUWQxfVdfoNkqFV2qO13NVjfb3A0vPc1CLfcSRj D2mQ== X-Gm-Message-State: ANoB5pm1xLbaNDMf3yASnUTT0q7nQt6Q88+OBzvDYYZGgJebewdumo48 b1HS9EcWLSQEH6/dk6vhf+sz0w== X-Received: by 2002:a05:6512:a93:b0:4a2:6337:872d with SMTP id m19-20020a0565120a9300b004a26337872dmr1801184lfu.35.1669105673210; Tue, 22 Nov 2022 00:27:53 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id n4-20020a195504000000b00492ce573726sm2418776lfe.47.2022.11.22.00.27.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 00:27:52 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 09:27:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 02/10] dt-bindings: display: bridge: Add MHDP DP for i.MX8MQ Content-Language: en-US To: Sandor Yu , andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kishon@ti.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, alexander.stein@ew.tq-group.com Cc: kernel@pengutronix.de, linux-imx@nxp.com, oliver.brown@nxp.com References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/11/2022 08:23, Sandor Yu wrote: > Add bindings for i.MX8MQ MHDP DisplayPort. > > Signed-off-by: Sandor Yu > --- > .../display/bridge/cdns,mhdp-imx8mq-dp.yaml | 93 +++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > new file mode 100644 > index 000000000000..d82f3ceddaa8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-dp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence MHDP Displayport bridge > + > +maintainers: > + - Sandor Yu > + > +description: > + The Cadence MHDP Displayport TX interface. > + > +properties: > + compatible: > + enum: > + - cdns,mhdp-imx8mq-dp > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: MHDP DP APB clock. > + > + phys: > + maxItems: 1 > + > + interrupts: > + items: > + - description: Hotplug cable plugin. > + - description: Hotplug cable plugout. > + > + interrupt-names: > + items: > + - const: plug_in > + - const: plug_out > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port from display controller output. > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port to DP connector. > + > + required: > + - port@0 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - interrupt-names > + - phys > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + mhdp_dp: dp-bridge@32c00000 { > + compatible = "cdns,mhdp-imx8mq-dp"; > + reg = <0x32c00000 0x100000>; > + interrupts = , > + ; > + interrupt-names = "plug_in", "plug_out"; > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + phys = <&dp_phy>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + mhdp_in: endpoint { > + remote-endpoint = <&dcss_out>; > + }; As Rob suggested, you allowed property for output to DP port. However it is not in the example. If this is a bridge, what does it bridge if there is no output connector? Best regards, Krzysztof