Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
        "quic_xiaosenh@quicinc.com" <quic_xiaosenh@quicinc.com>,
        "quic_richardp@quicinc.com" <quic_richardp@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "hare@suse.de" <hare@suse.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/6] ufs: ufs_bsg: Cleanup ufs_bsg_request
Thread-Topic: [PATCH v2 2/6] ufs: ufs_bsg: Cleanup ufs_bsg_request
Thread-Index: AQHY/S6maCN3xUC9iU6nCajbprM+ka5Kk+Ug
Date:   Tue, 22 Nov 2022 07:51:43 +0000
Message-ID: <DM6PR04MB657526124CB8A463C1093CB4FC0D9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20221120222217.108492-1-beanhuo@iokpp.de>
 <20221120222217.108492-3-beanhuo@iokpp.de>
In-Reply-To: <20221120222217.108492-3-beanhuo@iokpp.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fgVLpggNP5cimifSRST/Wp6qrc7ZJf2kBHXT2ncTgs+ORfyjnUqRpUQpdKnd?=
 =?us-ascii?Q?7rFvngpgxyRKzqYnm6ocX8K+avelZxiWkqCJpb0SGH8jOGwwrVcCWR6qzkro?=
 =?us-ascii?Q?MUVSShVqOHBoH9QME8c6dN9mlk3S0bcgtN4ZTVIK0COlJODVkjowRRDJKeLD?=
 =?us-ascii?Q?sm5AKSHfKOkj3FJEzAm77BHUMnvS6EO7tszbASFW13sSXCaZk9ePg7Q2wB/3?=
 =?us-ascii?Q?w+6FioDVqm0AVNxFUY1xZgf0qnkTwQ72QKRNQLPfK87fNIygk8/K/s2I6DwX?=
 =?us-ascii?Q?PHTjggCgjzStmQtg0cJeW9C3fB391Tf3Toael9dSokrvscQFjrSe6eeuaDRg?=
 =?us-ascii?Q?ZUKOBE34M9T+ukbQUkRITilQPW25thmR/84RINg3JPk6Gs5g6lNNux5W9Xw8?=
 =?us-ascii?Q?brEgsLT4tp1JpOHRUrZ8BrmvX1k5r/syU+wu1u2i9agyXY5xavsQ4Qz8rJ3e?=
 =?us-ascii?Q?/TrZ8R+KcDrPu5MpaEF5/+N8K8JLxvm+kkKw+cefR5Hs1oDhs4iUbTdcw/4O?=
 =?us-ascii?Q?GM5I2oJjO6DoXsTUgU97r85HMSjbOP1mHZO+FOjZL8GQDylUErd12cRE578e?=
 =?us-ascii?Q?iCZJ8ENwJ+QipMqwM8EEy7fGnISgla0FLxH7jdezXDblebzVNjUWQ2pvbuVP?=
 =?us-ascii?Q?yeixG7b6j0CItBACJnyoMeP3qeh6/zi1ziBFk3R7eiKOJN0/lzproO8exUKs?=
 =?us-ascii?Q?Ch7BA8aAXlQPSJ/bAoEL6Ity40SXMmbq/hwhLib2s1v2KhrI0cX1viuMIG7m?=
 =?us-ascii?Q?ge04OuL3pifET2jn9o1w1eLZoTxQirc+4SGs3lUlPVofqZo/1PkXXxSCQw3K?=
 =?us-ascii?Q?I+FxiRgseGOZAwmlCBrA9e7dW1JmELoM6GUfLRfkfMofJOqSASYjnyroFP+A?=
 =?us-ascii?Q?Eepco31XZNxB5Q81j43z8WKEqimByHeFcCJoaV3sDM0YYGzarpNzze+F34BJ?=
 =?us-ascii?Q?yGXAZQWy3owMe9n8OMlJWBNzOBx9iUGjO88EeP7KeKUDJle7OZB4FIicDp71?=
 =?us-ascii?Q?vcS36EFQ0Yq7Wd4CFBSSuTfHfztzThRJVK8GfP1asjwGIaNiv3cHTJu9jpEz?=
 =?us-ascii?Q?3yTq9IvaR1GySfPUC5RrTrD+yHufgtAihHqPreyFuQNLxQLpSO9hw0j+ypOq?=
 =?us-ascii?Q?jL6ovLRsMg9MmAIxEfftOvWvxtmNQsCENEfbIhGh62hltQtDQRi5Jp/62JPu?=
 =?us-ascii?Q?XHPQ9/HFU/7RpH7rhi2D+wi/uqx7HNMtJThaJ74KEWrYoY8DFzcr+WCO6tHA?=
 =?us-ascii?Q?vScwLDBMQa+lj2f19qzMhfdRuscY0vSp17/zp5rlzJMLUbTmkdQMTLPuV6Uy?=
 =?us-ascii?Q?or4e+fGvrsQurJOhFWAd4yzvzTZwcIcfRgMj153Df/O0uhP1khf5S2U3FOs2?=
 =?us-ascii?Q?s+R+5oWQxqOJ+j1slbc55QDu/C5GcIHWaaax+ieMLv25AkNA4CmejwIur6Rz?=
 =?us-ascii?Q?8EnYzld//GrnwDjLEGYhBhumw/+VX3WlEyAASW37VJ+xreq9HZ9fK3itp3z8?=
 =?us-ascii?Q?9lOxMUMEHqoFBW+ZaOCUiON3In2uFr/ELw05uC0PXxHH8i9rc2xMpO8cWvHk?=
 =?us-ascii?Q?VumGX4HYKTqOPwH0MAvk0G/INRY9uuF5mYg6u5ae?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?+K3vHAx8zg0ULVXdea/g6/5zHR64jzGTaufoGcIyNr7IK47eMLKfxL5F219L?=
 =?us-ascii?Q?u9MvgRD12+xw7tDIGlwB/fOS45r/qCUTOTshrZLvl4PRRnhZ7seHVMrFfhGe?=
 =?us-ascii?Q?KKDwSxpvw8GPbV4bZouRaN+YWeZoHRlJLk1Lt7bfxZKzPBE4cX9Bj7jSt5Du?=
 =?us-ascii?Q?LWjK9ocKwiY+FV0Vc1zl8u3hmUtfdSeBv17usnYXdRQQGehoXoIxuHXVnvbU?=
 =?us-ascii?Q?rYYDeRvbagxoKNDcku1p2NdWAYARRjxa3VWL4Cw2YW3taWqir4kUfNFtJpqd?=
 =?us-ascii?Q?DPTWcxaovnc3bMBSm81NWPipx7TjqzqQZxfMg/70XS+Cl0SrY9+xMoLPyf9f?=
 =?us-ascii?Q?bRrYkSbu4kN0nU15AO0u4kJB26g2biO2dWZ9CI5xii6Sc31X8RhEtHT4kFOD?=
 =?us-ascii?Q?qz2xzHJdr5QeYSfE9CId8dys/cAaPWynXYv8H/3PKQCW0MAOB5S/kNfEM8mh?=
 =?us-ascii?Q?Vo5LUcFK3RcU2Msoy8y/4pWMlzOq+sxzuk53GDqAn4F+gd8kzYE4fufk0AwI?=
 =?us-ascii?Q?tiaLFukYAOZaIc3sM2pj8MIm4J1Fj/bvI98/7UHEt/N7KEnym+wIH1cA7QAz?=
 =?us-ascii?Q?N2g/FoiLu9jINtl5Tv9nn2XjF9hH9ikHDllZjvTLzLofaNlzAHVyLlX6I8J/?=
 =?us-ascii?Q?798oAZEb6KIRNSHbaWogigU+rWD+OTsO9f5vJVPx66iXEAbNAcQKhHlVbVms?=
 =?us-ascii?Q?iObMaa+mHm4/CMlyim2Eo43EK83LbTMkIW1tpgJXc/s6JAdZHQHQMOB97ovM?=
 =?us-ascii?Q?yULWLeNnUK0KH3KA0iViM9nV6jqEj+tauYv0zlCcSB8B/CSPD639OORWd7MC?=
 =?us-ascii?Q?pErjJeVM620UEK0VJXRWhbakdqnvwdwAfyP36VAYEp5yckMncOBbqkhUOHLS?=
 =?us-ascii?Q?46jVkQhEtwRBDxZC8MTouTnPnWAACzfmdEocLhAE2y+dK/HAHMu6VsBUqeVl?=
 =?us-ascii?Q?j9DRUgiRqey5Hp30qKx3xo4ExVSHkM68OLRwveKMUo9K329eGG7V6zIFPp3S?=
 =?us-ascii?Q?YDOsTQoZQqd5qvVXHFhdM0dEqi0esLCqI5oP285rGqt745WNswR76jR7ktlV?=
 =?us-ascii?Q?N5+SRgzqqju7M0OzVttmAjMr7KdvX27JJY9tVvCyHM8vIqJe6ouz8yruy390?=
 =?us-ascii?Q?MR5Zkq+HEaxd28/szRwkwTJzZPVggUFij5gOKSSntHybGIt9LoJjPJtq+e31?=
 =?us-ascii?Q?r6nhcFn5WKh0SnXEK4XX/9vUIV2AfFvObxf1akKEp5sVNARqUfYjCpSdrimU?=
 =?us-ascii?Q?Jo1qeRFdwu/z+BDGpxFZEIu+4HGxCkHShGwJ/Foy/w=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c40e9c0b-4940-40b0-399c-08dacc5e65f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2022 07:51:43.4995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rRsXpF43Ca9haFPM7DcyGbNdcz+JDYamxC2/a/op74PoCSARppBXmUZTVGvXrOlEu8YfCWOLZ9rgdfS4QbqYgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4086
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> From: Bean Huo <beanhuo@micron.com>
>=20
> Move sg_copy_from_buffer() below its associated case statement.
>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/ufs/core/ufs_bsg.c | 27 ++++++++-------------------
>  1 file changed, 8 insertions(+), 19 deletions(-)
>=20
> diff --git a/drivers/ufs/core/ufs_bsg.c b/drivers/ufs/core/ufs_bsg.c inde=
x
> 9ac8204f1ee6..850a0d798f63 100644
> --- a/drivers/ufs/core/ufs_bsg.c
> +++ b/drivers/ufs/core/ufs_bsg.c
> @@ -90,11 +90,8 @@ static int ufs_bsg_request(struct bsg_job *job)
>                 desc_op =3D bsg_request->upiu_req.qr.opcode;
>                 ret =3D ufs_bsg_alloc_desc_buffer(hba, job, &desc_buff,
>                                                 &desc_len, desc_op);
> -               if (ret) {
> -                       ufshcd_rpm_put_sync(hba);
> +               if (ret)
>                         goto out;
> -               }
> -
>                 fallthrough;
>         case UPIU_TRANSACTION_NOP_OUT:
>         case UPIU_TRANSACTION_TASK_REQ:
> @@ -102,9 +99,12 @@ static int ufs_bsg_request(struct bsg_job *job)
>                                                &bsg_reply->upiu_rsp, msgc=
ode,
>                                                desc_buff, &desc_len, desc=
_op);
>                 if (ret)
> -                       dev_err(hba->dev,
> -                               "exe raw upiu: error code %d\n", ret);
> -
> +                       dev_err(hba->dev, "exe raw upiu: error code %d\n"=
, ret);
> +               else if (desc_op =3D=3D UPIU_QUERY_OPCODE_READ_DESC && de=
sc_len)
> +                       bsg_reply->reply_payload_rcv_len =3D
> +                               sg_copy_from_buffer(job->request_payload.=
sg_list,
> +                                                   job->request_payload.=
sg_cnt,
> +                                                   desc_buff,
> + desc_len);
>                 break;
>         case UPIU_TRANSACTION_UIC_CMD:
>                 memcpy(&uc, &bsg_request->upiu_req.uc, UIC_CMD_SIZE); @@ =
-
> 123,20 +123,9 @@ static int ufs_bsg_request(struct bsg_job *job)
>                 break;
>         }
>=20
> +out:
>         ufshcd_rpm_put_sync(hba);
> -
> -       if (!desc_buff)
> -               goto out;
> -
> -       if (desc_op =3D=3D UPIU_QUERY_OPCODE_READ_DESC && desc_len)
> -               bsg_reply->reply_payload_rcv_len =3D
> -                       sg_copy_from_buffer(job->request_payload.sg_list,
> -                                           job->request_payload.sg_cnt,
> -                                           desc_buff, desc_len);
> -
>         kfree(desc_buff);
> -
> -out:
>         bsg_reply->result =3D ret;
>         job->reply_len =3D sizeof(struct ufs_bsg_reply);
>         /* complete the job here only if no error */
> --
> 2.25.1