Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 10:08:33 +0100
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     ye.xingchen@zte.com.cn
Cc:     shawnguo@kernel.org, chi.minghao@zte.com.cn,
        s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: imx-weim: use
 devm_platform_get_and_ioremap_resource()
Message-ID: <20221122090833.5nqm52jzoxxxu2sj@pengutronix.de>
References: <202211220940526866294@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202211220940526866294@zte.com.cn>
User-Agent: NeoMutt/20180716
Precedence: bulk

Hi Chi,

thanks for your patch.

On 22-11-22, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

LGTM, feel free to add my

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

> ---
>  drivers/bus/imx-weim.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 828c66bbaa67..2a6b4f676458 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
>  static int weim_probe(struct platform_device *pdev)
>  {
>  	struct weim_priv *priv;
> -	struct resource *res;
>  	struct clk *clk;
>  	void __iomem *base;
>  	int ret;
> @@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
>  		return -ENOMEM;
> 
>  	/* get the resource */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>  	if (IS_ERR(base))
>  		return PTR_ERR(base);
> 
> -- 
> 2.25.1
> 
>