Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 11:14:47 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Rahul Tanwar <rtanwar@maxlinear.com>
Cc:     bigeasy@linutronix.de, robh@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
        dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
        linux-lgm-soc@maxlinear.com
Subject: Re: [PATCH v3 3/4] x86/of: Replace printk(KERN_LVL) with pr_lvl()
Message-ID: <Y3yTB7mGOPm3rFfb@smile.fi.intel.com>
References: <cover.1669100394.git.rtanwar@maxlinear.com>
 <64a905649accf1b68f03c31a9b6ce205b03c6703.1669100394.git.rtanwar@maxlinear.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <64a905649accf1b68f03c31a9b6ce205b03c6703.1669100394.git.rtanwar@maxlinear.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Nov 22, 2022 at 03:39:09PM +0800, Rahul Tanwar wrote:
> Use latest available pr_lvl() instead of older printk(KERN_LVL)
> Just a upgrade of print utilities usage no functional changes.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
> ---
>  arch/x86/kernel/devicetree.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 5cd51f25f446..fcc6f1b7818f 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -248,7 +248,7 @@ static void __init dtb_add_ioapic(struct device_node *dn)
>  
>  	ret = of_address_to_resource(dn, 0, &r);
>  	if (ret) {
> -		printk(KERN_ERR "Can't obtain address from device node %pOF.\n", dn);
> +		pr_err("Can't obtain address from device node %pOF.\n", dn);
>  		return;
>  	}
>  	mp_register_ioapic(++ioapic_id, r.start, gsi_top, &cfg);
> @@ -265,7 +265,7 @@ static void __init dtb_ioapic_setup(void)
>  		of_ioapic = 1;
>  		return;
>  	}
> -	printk(KERN_ERR "Error: No information about IO-APIC in OF.\n");
> +	pr_err("Error: No information about IO-APIC in OF.\n");
>  }
>  #else
>  static void __init dtb_ioapic_setup(void) {}
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko